diff options
author | Dan Carpenter <dan.carpenter@oracle.com> | 2016-04-19 10:30:56 -0400 |
---|---|---|
committer | David S. Miller <davem@davemloft.net> | 2016-04-21 14:08:00 -0400 |
commit | 1ba64facae5739d91884f8f34f25fef1cb66d930 (patch) | |
tree | 6750e9a93dabd8548661980068117e8ebc460038 | |
parent | f937572925d8d7beb5aca1cf180e8b9af623a903 (diff) |
geneve: testing the wrong variable in geneve6_build_skb()
We intended to test "err" and not "skb".
Fixes: aed069df099c ('ip_tunnel_core: iptunnel_handle_offloads returns int and doesn't free skb')
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Acked-by: Alexander Duyck <aduyck@mirantis.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
-rw-r--r-- | drivers/net/geneve.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/net/geneve.c b/drivers/net/geneve.c index efbc7ceedc3a..512dbe013713 100644 --- a/drivers/net/geneve.c +++ b/drivers/net/geneve.c | |||
@@ -733,7 +733,7 @@ static int geneve6_build_skb(struct dst_entry *dst, struct sk_buff *skb, | |||
733 | goto free_dst; | 733 | goto free_dst; |
734 | 734 | ||
735 | err = udp_tunnel_handle_offloads(skb, udp_sum); | 735 | err = udp_tunnel_handle_offloads(skb, udp_sum); |
736 | if (IS_ERR(skb)) | 736 | if (err) |
737 | goto free_dst; | 737 | goto free_dst; |
738 | 738 | ||
739 | gnvh = (struct genevehdr *)__skb_push(skb, sizeof(*gnvh) + opt_len); | 739 | gnvh = (struct genevehdr *)__skb_push(skb, sizeof(*gnvh) + opt_len); |