diff options
| author | Christian König <christian.koenig@amd.com> | 2018-04-10 07:42:29 -0400 |
|---|---|---|
| committer | Alex Deucher <alexander.deucher@amd.com> | 2018-05-15 14:43:19 -0400 |
| commit | 1afd30efeddbb1b32cf35d3bf6477b35690eeca6 (patch) | |
| tree | b3cc4263897e3726e856093ab9e3b1abc330dc2c | |
| parent | 63c2f7ed7bb3e98b4b22d5b136f4749706f17d36 (diff) | |
drm/amdgpu: revert "add new bo flag that indicates BOs don't need fallback (v2)"
This reverts commit 6f51d28bfe8e1a676de5cd877639245bed3cc818.
Makes fallback handling to complicated. This is just a feature for the
GEM interface and shouldn't leak into the core BO create function.
Signed-off-by: Christian König <christian.koenig@amd.com>
Acked-by: Chunming Zhou <david1.zhou@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
| -rw-r--r-- | drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c | 3 | ||||
| -rw-r--r-- | drivers/gpu/drm/amd/amdgpu/amdgpu_object.c | 5 | ||||
| -rw-r--r-- | include/uapi/drm/amdgpu_drm.h | 2 |
3 files changed, 2 insertions, 8 deletions
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c index 68af2f878bc9..e1756b68a17b 100644 --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c | |||
| @@ -385,8 +385,7 @@ retry: | |||
| 385 | amdgpu_bo_in_cpu_visible_vram(bo)) | 385 | amdgpu_bo_in_cpu_visible_vram(bo)) |
| 386 | p->bytes_moved_vis += ctx.bytes_moved; | 386 | p->bytes_moved_vis += ctx.bytes_moved; |
| 387 | 387 | ||
| 388 | if (unlikely(r == -ENOMEM) && domain != bo->allowed_domains && | 388 | if (unlikely(r == -ENOMEM) && domain != bo->allowed_domains) { |
| 389 | !(bo->flags & AMDGPU_GEM_CREATE_NO_FALLBACK)) { | ||
| 390 | domain = bo->allowed_domains; | 389 | domain = bo->allowed_domains; |
| 391 | goto retry; | 390 | goto retry; |
| 392 | } | 391 | } |
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_object.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_object.c index a160ef0332d6..1de6864da717 100644 --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_object.c +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_object.c | |||
| @@ -388,8 +388,6 @@ retry: | |||
| 388 | drm_gem_private_object_init(adev->ddev, &bo->gem_base, size); | 388 | drm_gem_private_object_init(adev->ddev, &bo->gem_base, size); |
| 389 | INIT_LIST_HEAD(&bo->shadow_list); | 389 | INIT_LIST_HEAD(&bo->shadow_list); |
| 390 | INIT_LIST_HEAD(&bo->va); | 390 | INIT_LIST_HEAD(&bo->va); |
| 391 | bo->preferred_domains = preferred_domains; | ||
| 392 | bo->allowed_domains = allowed_domains; | ||
| 393 | 391 | ||
| 394 | bo->flags = flags; | 392 | bo->flags = flags; |
| 395 | 393 | ||
| @@ -426,8 +424,7 @@ retry: | |||
| 426 | r = ttm_bo_init_reserved(&adev->mman.bdev, &bo->tbo, size, type, | 424 | r = ttm_bo_init_reserved(&adev->mman.bdev, &bo->tbo, size, type, |
| 427 | &bo->placement, page_align, &ctx, acc_size, | 425 | &bo->placement, page_align, &ctx, acc_size, |
| 428 | NULL, resv, &amdgpu_ttm_bo_destroy); | 426 | NULL, resv, &amdgpu_ttm_bo_destroy); |
| 429 | if (unlikely(r && r != -ERESTARTSYS) && type == ttm_bo_type_device && | 427 | if (unlikely(r && r != -ERESTARTSYS) && type == ttm_bo_type_device) { |
| 430 | !(flags & AMDGPU_GEM_CREATE_NO_FALLBACK)) { | ||
| 431 | if (flags & AMDGPU_GEM_CREATE_CPU_ACCESS_REQUIRED) { | 428 | if (flags & AMDGPU_GEM_CREATE_CPU_ACCESS_REQUIRED) { |
| 432 | flags &= ~AMDGPU_GEM_CREATE_CPU_ACCESS_REQUIRED; | 429 | flags &= ~AMDGPU_GEM_CREATE_CPU_ACCESS_REQUIRED; |
| 433 | goto retry; | 430 | goto retry; |
diff --git a/include/uapi/drm/amdgpu_drm.h b/include/uapi/drm/amdgpu_drm.h index 4f5a27d64c54..c363b67f2d0a 100644 --- a/include/uapi/drm/amdgpu_drm.h +++ b/include/uapi/drm/amdgpu_drm.h | |||
| @@ -95,8 +95,6 @@ extern "C" { | |||
| 95 | #define AMDGPU_GEM_CREATE_VM_ALWAYS_VALID (1 << 6) | 95 | #define AMDGPU_GEM_CREATE_VM_ALWAYS_VALID (1 << 6) |
| 96 | /* Flag that BO sharing will be explicitly synchronized */ | 96 | /* Flag that BO sharing will be explicitly synchronized */ |
| 97 | #define AMDGPU_GEM_CREATE_EXPLICIT_SYNC (1 << 7) | 97 | #define AMDGPU_GEM_CREATE_EXPLICIT_SYNC (1 << 7) |
| 98 | /* Flag that BO doesn't need fallback */ | ||
| 99 | #define AMDGPU_GEM_CREATE_NO_FALLBACK (1 << 8) | ||
| 100 | 98 | ||
| 101 | struct drm_amdgpu_gem_create_in { | 99 | struct drm_amdgpu_gem_create_in { |
| 102 | /** the requested memory size */ | 100 | /** the requested memory size */ |
