aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorLinus Torvalds <torvalds@linux-foundation.org>2015-07-21 17:42:40 -0400
committerLinus Torvalds <torvalds@linux-foundation.org>2015-07-21 17:42:40 -0400
commit1ad474de9349870f085b61c90bc80022702a78cc (patch)
tree0e0a9f9b48bd073f80a3b6a86b8402354d2ea39a
parent9d634c410b07be7bf637ea03362d3ff132088fe3 (diff)
parentd6726c8145290bef950ae2538ea6ae1d96a1944b (diff)
Merge tag 'trace-v4.2-rc2-fix2' of git://git.kernel.org/pub/scm/linux/kernel/git/rostedt/linux-trace
Pull tracing sample code fix from Steven Rostedt: "He Kuang noticed that the sample code using the trace_event helper function __get_dynamic_array_len() is broken. This only changes the sample code, and I'm pushing this now instead of later because I don't want others using the broken code as an example when using it for real" * tag 'trace-v4.2-rc2-fix2' of git://git.kernel.org/pub/scm/linux/kernel/git/rostedt/linux-trace: tracing: Fix sample output of dynamic arrays
-rw-r--r--samples/trace_events/trace-events-sample.h7
1 files changed, 5 insertions, 2 deletions
diff --git a/samples/trace_events/trace-events-sample.h b/samples/trace_events/trace-events-sample.h
index 8965d1bb8811..125d6402f64f 100644
--- a/samples/trace_events/trace-events-sample.h
+++ b/samples/trace_events/trace-events-sample.h
@@ -168,7 +168,10 @@
168 * 168 *
169 * For __dynamic_array(int, foo, bar) use __get_dynamic_array(foo) 169 * For __dynamic_array(int, foo, bar) use __get_dynamic_array(foo)
170 * Use __get_dynamic_array_len(foo) to get the length of the array 170 * Use __get_dynamic_array_len(foo) to get the length of the array
171 * saved. 171 * saved. Note, __get_dynamic_array_len() returns the total allocated
172 * length of the dynamic array; __print_array() expects the second
173 * parameter to be the number of elements. To get that, the array length
174 * needs to be divided by the element size.
172 * 175 *
173 * For __string(foo, bar) use __get_str(foo) 176 * For __string(foo, bar) use __get_str(foo)
174 * 177 *
@@ -288,7 +291,7 @@ TRACE_EVENT(foo_bar,
288 * This prints out the array that is defined by __array in a nice format. 291 * This prints out the array that is defined by __array in a nice format.
289 */ 292 */
290 __print_array(__get_dynamic_array(list), 293 __print_array(__get_dynamic_array(list),
291 __get_dynamic_array_len(list), 294 __get_dynamic_array_len(list) / sizeof(int),
292 sizeof(int)), 295 sizeof(int)),
293 __get_str(str), __get_bitmask(cpus)) 296 __get_str(str), __get_bitmask(cpus))
294); 297);