aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorDongsheng Yang <yangds.fnst@cn.fujitsu.com>2015-12-21 06:14:42 -0500
committerIngo Molnar <mingo@kernel.org>2016-03-21 05:59:29 -0400
commit1a736b77a3f50910843d076623204ba6e5057dc1 (patch)
treea50c42c957b5b3ebb15d727001669276e7521799
parentd4335581dc30ec6545999c7443bb9fead274a980 (diff)
sched/cpuacct: Rename parameter in cpuusage_write() for readability
The name of the 'reset' parameter to cpuusage_write() is quite confusing, because the only valid value we allow is '0', so !reset is actually the case that resets ... Rename it to 'val' and explain it in a comment that we only allow 0. Signed-off-by: Dongsheng Yang <yangds.fnst@cn.fujitsu.com> Cc: Linus Torvalds <torvalds@linux-foundation.org> Cc: Peter Zijlstra <peterz@infradead.org> Cc: Thomas Gleixner <tglx@linutronix.de> Cc: cgroups@vger.kernel.org Cc: tj@kernel.org Link: http://lkml.kernel.org/r/1450696483-2864-1-git-send-email-yangds.fnst@cn.fujitsu.com Signed-off-by: Ingo Molnar <mingo@kernel.org>
-rw-r--r--kernel/sched/cpuacct.c7
1 files changed, 5 insertions, 2 deletions
diff --git a/kernel/sched/cpuacct.c b/kernel/sched/cpuacct.c
index dd7cbb55bbf2..9c2bbf7efa1a 100644
--- a/kernel/sched/cpuacct.c
+++ b/kernel/sched/cpuacct.c
@@ -145,13 +145,16 @@ static u64 cpuusage_read(struct cgroup_subsys_state *css, struct cftype *cft)
145} 145}
146 146
147static int cpuusage_write(struct cgroup_subsys_state *css, struct cftype *cft, 147static int cpuusage_write(struct cgroup_subsys_state *css, struct cftype *cft,
148 u64 reset) 148 u64 val)
149{ 149{
150 struct cpuacct *ca = css_ca(css); 150 struct cpuacct *ca = css_ca(css);
151 int err = 0; 151 int err = 0;
152 int i; 152 int i;
153 153
154 if (reset) { 154 /*
155 * Only allow '0' here to do a reset.
156 */
157 if (val) {
155 err = -EINVAL; 158 err = -EINVAL;
156 goto out; 159 goto out;
157 } 160 }