aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorMathieu Malaterre <malat@debian.org>2018-07-20 20:53:31 -0400
committerLinus Torvalds <torvalds@linux-foundation.org>2018-07-21 15:50:46 -0400
commit1937367205d930deafb11c387b0a71dd215254d5 (patch)
tree393cbfdbd7429403a0e1f2039744ed622344dcae
parent28c20cc73b9cc4288c86c2a3fc62af4087de4b19 (diff)
mm/memblock: add missing include <linux/bootmem.h>
Commit 26f09e9b3a06 ("mm/memblock: add memblock memory allocation apis") introduced two new function definitions: memblock_virt_alloc_try_nid_nopanic() memblock_virt_alloc_try_nid() and commit ea1f5f3712af ("mm: define memblock_virt_alloc_try_nid_raw") introduced the following function definition: memblock_virt_alloc_try_nid_raw() This commit adds an include of header file <linux/bootmem.h> to provide the missing function prototypes. This silences the following gcc warning (W=1): mm/memblock.c:1334:15: warning: no previous prototype for `memblock_virt_alloc_try_nid_raw' [-Wmissing-prototypes] mm/memblock.c:1371:15: warning: no previous prototype for `memblock_virt_alloc_try_nid_nopanic' [-Wmissing-prototypes] mm/memblock.c:1407:15: warning: no previous prototype for `memblock_virt_alloc_try_nid' [-Wmissing-prototypes] Also adds #ifdef blockers to prevent compilation failure on mips/ia64 where CONFIG_NO_BOOTMEM=n as could be seen in commit commit 6cc22dc08a24 ("revert "mm/memblock: add missing include <linux/bootmem.h>""). Because Makefile already does: obj-$(CONFIG_HAVE_MEMBLOCK) += memblock.o The #ifdef has been simplified from: #if defined(CONFIG_HAVE_MEMBLOCK) && defined(CONFIG_NO_BOOTMEM) to simply: #if defined(CONFIG_NO_BOOTMEM) Link: http://lkml.kernel.org/r/20180626184422.24974-1-malat@debian.org Signed-off-by: Mathieu Malaterre <malat@debian.org> Suggested-by: Tony Luck <tony.luck@intel.com> Suggested-by: Michal Hocko <mhocko@kernel.org> Acked-by: Michal Hocko <mhocko@suse.com> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
-rw-r--r--mm/memblock.c3
1 files changed, 3 insertions, 0 deletions
diff --git a/mm/memblock.c b/mm/memblock.c
index 11e46f83e1ad..4b5d245fafc1 100644
--- a/mm/memblock.c
+++ b/mm/memblock.c
@@ -20,6 +20,7 @@
20#include <linux/kmemleak.h> 20#include <linux/kmemleak.h>
21#include <linux/seq_file.h> 21#include <linux/seq_file.h>
22#include <linux/memblock.h> 22#include <linux/memblock.h>
23#include <linux/bootmem.h>
23 24
24#include <asm/sections.h> 25#include <asm/sections.h>
25#include <linux/io.h> 26#include <linux/io.h>
@@ -1225,6 +1226,7 @@ phys_addr_t __init memblock_alloc_try_nid(phys_addr_t size, phys_addr_t align, i
1225 return memblock_alloc_base(size, align, MEMBLOCK_ALLOC_ACCESSIBLE); 1226 return memblock_alloc_base(size, align, MEMBLOCK_ALLOC_ACCESSIBLE);
1226} 1227}
1227 1228
1229#if defined(CONFIG_NO_BOOTMEM)
1228/** 1230/**
1229 * memblock_virt_alloc_internal - allocate boot memory block 1231 * memblock_virt_alloc_internal - allocate boot memory block
1230 * @size: size of memory block to be allocated in bytes 1232 * @size: size of memory block to be allocated in bytes
@@ -1432,6 +1434,7 @@ void * __init memblock_virt_alloc_try_nid(
1432 (u64)max_addr); 1434 (u64)max_addr);
1433 return NULL; 1435 return NULL;
1434} 1436}
1437#endif
1435 1438
1436/** 1439/**
1437 * __memblock_free_early - free boot memory block 1440 * __memblock_free_early - free boot memory block