diff options
| author | Toshi Kani <toshi.kani@hpe.com> | 2018-03-13 13:03:46 -0400 |
|---|---|---|
| committer | Thomas Gleixner <tglx@linutronix.de> | 2018-03-14 15:22:42 -0400 |
| commit | 18a955219bf7d9008ce480d4451b6b8bf4483a22 (patch) | |
| tree | c9f1466cdcb2c0a3ce14aea2b2520f0547191af3 | |
| parent | fc6eabbbf8ef99efed778dd5afabc83c21dba585 (diff) | |
x86/mm: Fix vmalloc_fault to use pXd_large
Gratian Crisan reported that vmalloc_fault() crashes when CONFIG_HUGETLBFS
is not set since the function inadvertently uses pXn_huge(), which always
return 0 in this case. ioremap() does not depend on CONFIG_HUGETLBFS.
Fix vmalloc_fault() to call pXd_large() instead.
Fixes: f4eafd8bcd52 ("x86/mm: Fix vmalloc_fault() to handle large pages properly")
Reported-by: Gratian Crisan <gratian.crisan@ni.com>
Signed-off-by: Toshi Kani <toshi.kani@hpe.com>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Cc: stable@vger.kernel.org
Cc: linux-mm@kvack.org
Cc: Borislav Petkov <bp@alien8.de>
Cc: Andy Lutomirski <luto@kernel.org>
Link: https://lkml.kernel.org/r/20180313170347.3829-2-toshi.kani@hpe.com
| -rw-r--r-- | arch/x86/mm/fault.c | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/arch/x86/mm/fault.c b/arch/x86/mm/fault.c index c88573d90f3e..25a30b5d6582 100644 --- a/arch/x86/mm/fault.c +++ b/arch/x86/mm/fault.c | |||
| @@ -330,7 +330,7 @@ static noinline int vmalloc_fault(unsigned long address) | |||
| 330 | if (!pmd_k) | 330 | if (!pmd_k) |
| 331 | return -1; | 331 | return -1; |
| 332 | 332 | ||
| 333 | if (pmd_huge(*pmd_k)) | 333 | if (pmd_large(*pmd_k)) |
| 334 | return 0; | 334 | return 0; |
| 335 | 335 | ||
| 336 | pte_k = pte_offset_kernel(pmd_k, address); | 336 | pte_k = pte_offset_kernel(pmd_k, address); |
| @@ -475,7 +475,7 @@ static noinline int vmalloc_fault(unsigned long address) | |||
| 475 | if (pud_none(*pud) || pud_pfn(*pud) != pud_pfn(*pud_ref)) | 475 | if (pud_none(*pud) || pud_pfn(*pud) != pud_pfn(*pud_ref)) |
| 476 | BUG(); | 476 | BUG(); |
| 477 | 477 | ||
| 478 | if (pud_huge(*pud)) | 478 | if (pud_large(*pud)) |
| 479 | return 0; | 479 | return 0; |
| 480 | 480 | ||
| 481 | pmd = pmd_offset(pud, address); | 481 | pmd = pmd_offset(pud, address); |
| @@ -486,7 +486,7 @@ static noinline int vmalloc_fault(unsigned long address) | |||
| 486 | if (pmd_none(*pmd) || pmd_pfn(*pmd) != pmd_pfn(*pmd_ref)) | 486 | if (pmd_none(*pmd) || pmd_pfn(*pmd) != pmd_pfn(*pmd_ref)) |
| 487 | BUG(); | 487 | BUG(); |
| 488 | 488 | ||
| 489 | if (pmd_huge(*pmd)) | 489 | if (pmd_large(*pmd)) |
| 490 | return 0; | 490 | return 0; |
| 491 | 491 | ||
| 492 | pte_ref = pte_offset_kernel(pmd_ref, address); | 492 | pte_ref = pte_offset_kernel(pmd_ref, address); |
