diff options
author | Anatolij Gustschin <agust@denx.de> | 2018-11-07 12:51:45 -0500 |
---|---|---|
committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2018-11-11 15:58:27 -0500 |
commit | 187fade88ca0ff2df9d360ca751d948d73db7095 (patch) | |
tree | a1fdcf21de6dc72cb7f1e0a68ead114f5be76702 | |
parent | 1e5106031f298af4ad29c2eb866780d9a21e9ab4 (diff) |
fpga: altera-cvp: fix 'bad IO access' on x86_64
If mapping the CvP BAR fails, we still can configure the FPGA via
PCI config space access. In this case the iomap pointer is NULL.
On x86_64, passing NULL address to pci_iounmap() generates
"Bad IO access at port 0x0" output with stack call trace. Fix it.
Signed-off-by: Anatolij Gustschin <agust@denx.de>
Acked-by: Alan Tull <atull@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-rw-r--r-- | drivers/fpga/altera-cvp.c | 6 |
1 files changed, 4 insertions, 2 deletions
diff --git a/drivers/fpga/altera-cvp.c b/drivers/fpga/altera-cvp.c index 610a1558e0ed..144fa2a4d4cc 100644 --- a/drivers/fpga/altera-cvp.c +++ b/drivers/fpga/altera-cvp.c | |||
@@ -477,7 +477,8 @@ static int altera_cvp_probe(struct pci_dev *pdev, | |||
477 | return 0; | 477 | return 0; |
478 | 478 | ||
479 | err_unmap: | 479 | err_unmap: |
480 | pci_iounmap(pdev, conf->map); | 480 | if (conf->map) |
481 | pci_iounmap(pdev, conf->map); | ||
481 | pci_release_region(pdev, CVP_BAR); | 482 | pci_release_region(pdev, CVP_BAR); |
482 | err_disable: | 483 | err_disable: |
483 | cmd &= ~PCI_COMMAND_MEMORY; | 484 | cmd &= ~PCI_COMMAND_MEMORY; |
@@ -493,7 +494,8 @@ static void altera_cvp_remove(struct pci_dev *pdev) | |||
493 | 494 | ||
494 | driver_remove_file(&altera_cvp_driver.driver, &driver_attr_chkcfg); | 495 | driver_remove_file(&altera_cvp_driver.driver, &driver_attr_chkcfg); |
495 | fpga_mgr_unregister(mgr); | 496 | fpga_mgr_unregister(mgr); |
496 | pci_iounmap(pdev, conf->map); | 497 | if (conf->map) |
498 | pci_iounmap(pdev, conf->map); | ||
497 | pci_release_region(pdev, CVP_BAR); | 499 | pci_release_region(pdev, CVP_BAR); |
498 | pci_read_config_word(pdev, PCI_COMMAND, &cmd); | 500 | pci_read_config_word(pdev, PCI_COMMAND, &cmd); |
499 | cmd &= ~PCI_COMMAND_MEMORY; | 501 | cmd &= ~PCI_COMMAND_MEMORY; |