aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorMasahiro Yamada <yamada.masahiro@socionext.com>2018-12-31 03:24:08 -0500
committerMasahiro Yamada <yamada.masahiro@socionext.com>2019-01-05 19:46:51 -0500
commit172caf1993b7a6503a9f7faf589e2cf26eb1f219 (patch)
tree1bf9a94732270a001752735cf99fa038ebaedd21
parentf5688663db9b207d7d31f30f388417504b16b76c (diff)
kbuild: remove redundant target cleaning on failure
Since commit 9c2af1c7377a ("kbuild: add .DELETE_ON_ERROR special target"), the target file is automatically deleted on failure. The boilerplate code ... || { rm -f $@; false; } is unneeded. Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
-rw-r--r--arch/arm/boot/Makefile2
-rw-r--r--arch/arm/boot/compressed/Makefile2
-rw-r--r--arch/arm/tools/Makefile3
-rw-r--r--arch/sh/tools/Makefile2
-rw-r--r--arch/x86/boot/compressed/Makefile2
-rw-r--r--arch/x86/lib/Makefile2
-rw-r--r--certs/Makefile2
-rw-r--r--lib/raid6/Makefile5
-rw-r--r--scripts/Makefile.lib21
9 files changed, 16 insertions, 25 deletions
diff --git a/arch/arm/boot/Makefile b/arch/arm/boot/Makefile
index a3af4dc08c3e..0b3cd7a33a26 100644
--- a/arch/arm/boot/Makefile
+++ b/arch/arm/boot/Makefile
@@ -32,7 +32,7 @@ targets := Image zImage xipImage bootpImage uImage
32ifeq ($(CONFIG_XIP_KERNEL),y) 32ifeq ($(CONFIG_XIP_KERNEL),y)
33 33
34cmd_deflate_xip_data = $(CONFIG_SHELL) -c \ 34cmd_deflate_xip_data = $(CONFIG_SHELL) -c \
35 '$(srctree)/$(src)/deflate_xip_data.sh $< $@ || { rm -f $@; false; }' 35 '$(srctree)/$(src)/deflate_xip_data.sh $< $@'
36 36
37ifeq ($(CONFIG_XIP_DEFLATED_DATA),y) 37ifeq ($(CONFIG_XIP_DEFLATED_DATA),y)
38quiet_cmd_mkxip = XIPZ $@ 38quiet_cmd_mkxip = XIPZ $@
diff --git a/arch/arm/boot/compressed/Makefile b/arch/arm/boot/compressed/Makefile
index 01bf2585a0fa..6114ae6ea466 100644
--- a/arch/arm/boot/compressed/Makefile
+++ b/arch/arm/boot/compressed/Makefile
@@ -170,7 +170,7 @@ check_for_bad_syms = \
170bad_syms=$$($(CROSS_COMPILE)nm $@ | sed -n 's/^.\{8\} [bc] \(.*\)/\1/p') && \ 170bad_syms=$$($(CROSS_COMPILE)nm $@ | sed -n 's/^.\{8\} [bc] \(.*\)/\1/p') && \
171[ -z "$$bad_syms" ] || \ 171[ -z "$$bad_syms" ] || \
172 ( echo "following symbols must have non local/private scope:" >&2; \ 172 ( echo "following symbols must have non local/private scope:" >&2; \
173 echo "$$bad_syms" >&2; rm -f $@; false ) 173 echo "$$bad_syms" >&2; false )
174 174
175check_for_multiple_zreladdr = \ 175check_for_multiple_zreladdr = \
176if [ $(words $(ZRELADDR)) -gt 1 -a "$(CONFIG_AUTO_ZRELADDR)" = "" ]; then \ 176if [ $(words $(ZRELADDR)) -gt 1 -a "$(CONFIG_AUTO_ZRELADDR)" = "" ]; then \
diff --git a/arch/arm/tools/Makefile b/arch/arm/tools/Makefile
index ddb89a7db36f..27d8beb7c941 100644
--- a/arch/arm/tools/Makefile
+++ b/arch/arm/tools/Makefile
@@ -35,8 +35,7 @@ _dummy := $(shell [ -d '$(kapi)' ] || mkdir -p '$(kapi)') \
35 35
36quiet_cmd_gen_mach = GEN $@ 36quiet_cmd_gen_mach = GEN $@
37 cmd_gen_mach = mkdir -p $(dir $@) && \ 37 cmd_gen_mach = mkdir -p $(dir $@) && \
38 $(AWK) -f $(filter-out $(PHONY),$^) > $@ || \ 38 $(AWK) -f $(filter-out $(PHONY),$^) > $@
39 { rm -f $@; /bin/false; }
40 39
41$(kapi)/mach-types.h: $(src)/gen-mach-types $(src)/mach-types FORCE 40$(kapi)/mach-types.h: $(src)/gen-mach-types $(src)/mach-types FORCE
42 $(call if_changed,gen_mach) 41 $(call if_changed,gen_mach)
diff --git a/arch/sh/tools/Makefile b/arch/sh/tools/Makefile
index 2082af1f3fef..e5ba31c79fe0 100644
--- a/arch/sh/tools/Makefile
+++ b/arch/sh/tools/Makefile
@@ -13,4 +13,4 @@
13include/generated/machtypes.h: $(src)/gen-mach-types $(src)/mach-types 13include/generated/machtypes.h: $(src)/gen-mach-types $(src)/mach-types
14 @echo ' Generating $@' 14 @echo ' Generating $@'
15 $(Q)mkdir -p $(dir $@) 15 $(Q)mkdir -p $(dir $@)
16 $(Q)LC_ALL=C $(AWK) -f $^ > $@ || { rm -f $@; /bin/false; } 16 $(Q)LC_ALL=C $(AWK) -f $^ > $@
diff --git a/arch/x86/boot/compressed/Makefile b/arch/x86/boot/compressed/Makefile
index 466f66c8a7f8..f0515ac895a4 100644
--- a/arch/x86/boot/compressed/Makefile
+++ b/arch/x86/boot/compressed/Makefile
@@ -151,7 +151,7 @@ suffix-$(CONFIG_KERNEL_LZO) := lzo
151suffix-$(CONFIG_KERNEL_LZ4) := lz4 151suffix-$(CONFIG_KERNEL_LZ4) := lz4
152 152
153quiet_cmd_mkpiggy = MKPIGGY $@ 153quiet_cmd_mkpiggy = MKPIGGY $@
154 cmd_mkpiggy = $(obj)/mkpiggy $< > $@ || ( rm -f $@ ; false ) 154 cmd_mkpiggy = $(obj)/mkpiggy $< > $@
155 155
156targets += piggy.S 156targets += piggy.S
157$(obj)/piggy.S: $(obj)/vmlinux.bin.$(suffix-y) $(obj)/mkpiggy FORCE 157$(obj)/piggy.S: $(obj)/vmlinux.bin.$(suffix-y) $(obj)/mkpiggy FORCE
diff --git a/arch/x86/lib/Makefile b/arch/x86/lib/Makefile
index ce28829f1281..140e61843a07 100644
--- a/arch/x86/lib/Makefile
+++ b/arch/x86/lib/Makefile
@@ -9,7 +9,7 @@ KCOV_INSTRUMENT_delay.o := n
9inat_tables_script = $(srctree)/arch/x86/tools/gen-insn-attr-x86.awk 9inat_tables_script = $(srctree)/arch/x86/tools/gen-insn-attr-x86.awk
10inat_tables_maps = $(srctree)/arch/x86/lib/x86-opcode-map.txt 10inat_tables_maps = $(srctree)/arch/x86/lib/x86-opcode-map.txt
11quiet_cmd_inat_tables = GEN $@ 11quiet_cmd_inat_tables = GEN $@
12 cmd_inat_tables = $(AWK) -f $(inat_tables_script) $(inat_tables_maps) > $@ || rm -f $@ 12 cmd_inat_tables = $(AWK) -f $(inat_tables_script) $(inat_tables_maps) > $@
13 13
14$(obj)/inat-tables.c: $(inat_tables_script) $(inat_tables_maps) 14$(obj)/inat-tables.c: $(inat_tables_script) $(inat_tables_maps)
15 $(call cmd,inat_tables) 15 $(call cmd,inat_tables)
diff --git a/certs/Makefile b/certs/Makefile
index 5d0999b9e21b..f4c25b67aad9 100644
--- a/certs/Makefile
+++ b/certs/Makefile
@@ -22,7 +22,7 @@ $(obj)/system_certificates.o: $(obj)/x509_certificate_list
22AFLAGS_system_certificates.o := -I$(srctree) 22AFLAGS_system_certificates.o := -I$(srctree)
23 23
24quiet_cmd_extract_certs = EXTRACT_CERTS $(patsubst "%",%,$(2)) 24quiet_cmd_extract_certs = EXTRACT_CERTS $(patsubst "%",%,$(2))
25 cmd_extract_certs = scripts/extract-cert $(2) $@ || ( rm $@; exit 1) 25 cmd_extract_certs = scripts/extract-cert $(2) $@
26 26
27targets += x509_certificate_list 27targets += x509_certificate_list
28$(obj)/x509_certificate_list: scripts/extract-cert $(SYSTEM_TRUSTED_KEYS_SRCPREFIX)$(SYSTEM_TRUSTED_KEYS_FILENAME) FORCE 28$(obj)/x509_certificate_list: scripts/extract-cert $(SYSTEM_TRUSTED_KEYS_SRCPREFIX)$(SYSTEM_TRUSTED_KEYS_FILENAME) FORCE
diff --git a/lib/raid6/Makefile b/lib/raid6/Makefile
index 7ed43eaa02ef..4e90d443d1b0 100644
--- a/lib/raid6/Makefile
+++ b/lib/raid6/Makefile
@@ -13,8 +13,7 @@ raid6_pq-$(CONFIG_S390) += s390vx8.o recov_s390xc.o
13hostprogs-y += mktables 13hostprogs-y += mktables
14 14
15quiet_cmd_unroll = UNROLL $@ 15quiet_cmd_unroll = UNROLL $@
16 cmd_unroll = $(AWK) -f$(srctree)/$(src)/unroll.awk -vN=$(UNROLL) \ 16 cmd_unroll = $(AWK) -f$(srctree)/$(src)/unroll.awk -vN=$(UNROLL) < $< > $@
17 < $< > $@ || ( rm -f $@ && exit 1 )
18 17
19ifeq ($(CONFIG_ALTIVEC),y) 18ifeq ($(CONFIG_ALTIVEC),y)
20altivec_flags := -maltivec $(call cc-option,-mabi=altivec) 19altivec_flags := -maltivec $(call cc-option,-mabi=altivec)
@@ -160,7 +159,7 @@ $(obj)/s390vx8.c: $(src)/s390vx.uc $(src)/unroll.awk FORCE
160 $(call if_changed,unroll) 159 $(call if_changed,unroll)
161 160
162quiet_cmd_mktable = TABLE $@ 161quiet_cmd_mktable = TABLE $@
163 cmd_mktable = $(obj)/mktables > $@ || ( rm -f $@ && exit 1 ) 162 cmd_mktable = $(obj)/mktables > $@
164 163
165targets += tables.c 164targets += tables.c
166$(obj)/tables.c: $(obj)/mktables FORCE 165$(obj)/tables.c: $(obj)/mktables FORCE
diff --git a/scripts/Makefile.lib b/scripts/Makefile.lib
index d10c61e5c6b9..390957f9306f 100644
--- a/scripts/Makefile.lib
+++ b/scripts/Makefile.lib
@@ -242,8 +242,7 @@ cmd_objcopy = $(OBJCOPY) $(OBJCOPYFLAGS) $(OBJCOPYFLAGS_$(@F)) $< $@
242# --------------------------------------------------------------------------- 242# ---------------------------------------------------------------------------
243 243
244quiet_cmd_gzip = GZIP $@ 244quiet_cmd_gzip = GZIP $@
245cmd_gzip = (cat $(filter-out FORCE,$^) | gzip -n -f -9 > $@) || \ 245 cmd_gzip = cat $(filter-out FORCE,$^) | gzip -n -f -9 > $@
246 (rm -f $@ ; false)
247 246
248# DTC 247# DTC
249# --------------------------------------------------------------------------- 248# ---------------------------------------------------------------------------
@@ -336,26 +335,22 @@ printf "%08x\n" $$dec_size | \
336 335
337quiet_cmd_bzip2 = BZIP2 $@ 336quiet_cmd_bzip2 = BZIP2 $@
338cmd_bzip2 = (cat $(filter-out FORCE,$^) | \ 337cmd_bzip2 = (cat $(filter-out FORCE,$^) | \
339 bzip2 -9 && $(call size_append, $(filter-out FORCE,$^))) > $@ || \ 338 bzip2 -9 && $(call size_append, $(filter-out FORCE,$^))) > $@
340 (rm -f $@ ; false)
341 339
342# Lzma 340# Lzma
343# --------------------------------------------------------------------------- 341# ---------------------------------------------------------------------------
344 342
345quiet_cmd_lzma = LZMA $@ 343quiet_cmd_lzma = LZMA $@
346cmd_lzma = (cat $(filter-out FORCE,$^) | \ 344cmd_lzma = (cat $(filter-out FORCE,$^) | \
347 lzma -9 && $(call size_append, $(filter-out FORCE,$^))) > $@ || \ 345 lzma -9 && $(call size_append, $(filter-out FORCE,$^))) > $@
348 (rm -f $@ ; false)
349 346
350quiet_cmd_lzo = LZO $@ 347quiet_cmd_lzo = LZO $@
351cmd_lzo = (cat $(filter-out FORCE,$^) | \ 348cmd_lzo = (cat $(filter-out FORCE,$^) | \
352 lzop -9 && $(call size_append, $(filter-out FORCE,$^))) > $@ || \ 349 lzop -9 && $(call size_append, $(filter-out FORCE,$^))) > $@
353 (rm -f $@ ; false)
354 350
355quiet_cmd_lz4 = LZ4 $@ 351quiet_cmd_lz4 = LZ4 $@
356cmd_lz4 = (cat $(filter-out FORCE,$^) | \ 352cmd_lz4 = (cat $(filter-out FORCE,$^) | \
357 lz4c -l -c1 stdin stdout && $(call size_append, $(filter-out FORCE,$^))) > $@ || \ 353 lz4c -l -c1 stdin stdout && $(call size_append, $(filter-out FORCE,$^))) > $@
358 (rm -f $@ ; false)
359 354
360# U-Boot mkimage 355# U-Boot mkimage
361# --------------------------------------------------------------------------- 356# ---------------------------------------------------------------------------
@@ -399,13 +394,11 @@ quiet_cmd_uimage = UIMAGE $@
399quiet_cmd_xzkern = XZKERN $@ 394quiet_cmd_xzkern = XZKERN $@
400cmd_xzkern = (cat $(filter-out FORCE,$^) | \ 395cmd_xzkern = (cat $(filter-out FORCE,$^) | \
401 sh $(srctree)/scripts/xz_wrap.sh && \ 396 sh $(srctree)/scripts/xz_wrap.sh && \
402 $(call size_append, $(filter-out FORCE,$^))) > $@ || \ 397 $(call size_append, $(filter-out FORCE,$^))) > $@
403 (rm -f $@ ; false)
404 398
405quiet_cmd_xzmisc = XZMISC $@ 399quiet_cmd_xzmisc = XZMISC $@
406cmd_xzmisc = (cat $(filter-out FORCE,$^) | \ 400cmd_xzmisc = (cat $(filter-out FORCE,$^) | \
407 xz --check=crc32 --lzma2=dict=1MiB) > $@ || \ 401 xz --check=crc32 --lzma2=dict=1MiB) > $@
408 (rm -f $@ ; false)
409 402
410# ASM offsets 403# ASM offsets
411# --------------------------------------------------------------------------- 404# ---------------------------------------------------------------------------