diff options
author | Arnd Bergmann <arnd@arndb.de> | 2018-02-02 09:56:18 -0500 |
---|---|---|
committer | Rafael J. Wysocki <rafael.j.wysocki@intel.com> | 2018-02-07 06:18:23 -0500 |
commit | 168b6511e8e09de45bed272aaf76ef4d4ca3c05d (patch) | |
tree | 0b339ebad722dcba4473480e90a12a4349ed2327 | |
parent | 7f3fdd40a7dfaa7405185250974b0fabd08c1f8b (diff) |
x86: hibernate: fix swsusp_arch_resume() prototype
The declaration for swsusp_arch_resume() marks it as 'asmlinkage',
but the definition in x86-32 does not, and it fails to include
the header with the declaration. This leads to a warning when
building with link-time-optimizations:
kernel/power/power.h:108:23: error: type of 'swsusp_arch_resume' does not match original declaration [-Werror=lto-type-mismatch]
extern asmlinkage int swsusp_arch_resume(void);
^
arch/x86/power/hibernate_32.c:148:0: note: 'swsusp_arch_resume' was previously declared here
int swsusp_arch_resume(void)
This moves the declaration into a globally visible header file
and fixes up both x86 definitions to match it.
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
-rw-r--r-- | arch/x86/power/hibernate_32.c | 2 | ||||
-rw-r--r-- | arch/x86/power/hibernate_64.c | 2 | ||||
-rw-r--r-- | include/linux/suspend.h | 2 | ||||
-rw-r--r-- | kernel/power/power.h | 3 |
4 files changed, 4 insertions, 5 deletions
diff --git a/arch/x86/power/hibernate_32.c b/arch/x86/power/hibernate_32.c index c35fdb585c68..afc4ed7b1578 100644 --- a/arch/x86/power/hibernate_32.c +++ b/arch/x86/power/hibernate_32.c | |||
@@ -145,7 +145,7 @@ static inline void resume_init_first_level_page_table(pgd_t *pg_dir) | |||
145 | #endif | 145 | #endif |
146 | } | 146 | } |
147 | 147 | ||
148 | int swsusp_arch_resume(void) | 148 | asmlinkage int swsusp_arch_resume(void) |
149 | { | 149 | { |
150 | int error; | 150 | int error; |
151 | 151 | ||
diff --git a/arch/x86/power/hibernate_64.c b/arch/x86/power/hibernate_64.c index f910c514438f..0ef5e5204968 100644 --- a/arch/x86/power/hibernate_64.c +++ b/arch/x86/power/hibernate_64.c | |||
@@ -174,7 +174,7 @@ out: | |||
174 | return 0; | 174 | return 0; |
175 | } | 175 | } |
176 | 176 | ||
177 | int swsusp_arch_resume(void) | 177 | asmlinkage int swsusp_arch_resume(void) |
178 | { | 178 | { |
179 | int error; | 179 | int error; |
180 | 180 | ||
diff --git a/include/linux/suspend.h b/include/linux/suspend.h index cc22a24516d6..440b62f7502e 100644 --- a/include/linux/suspend.h +++ b/include/linux/suspend.h | |||
@@ -384,6 +384,8 @@ extern int swsusp_page_is_forbidden(struct page *); | |||
384 | extern void swsusp_set_page_free(struct page *); | 384 | extern void swsusp_set_page_free(struct page *); |
385 | extern void swsusp_unset_page_free(struct page *); | 385 | extern void swsusp_unset_page_free(struct page *); |
386 | extern unsigned long get_safe_page(gfp_t gfp_mask); | 386 | extern unsigned long get_safe_page(gfp_t gfp_mask); |
387 | extern asmlinkage int swsusp_arch_suspend(void); | ||
388 | extern asmlinkage int swsusp_arch_resume(void); | ||
387 | 389 | ||
388 | extern void hibernation_set_ops(const struct platform_hibernation_ops *ops); | 390 | extern void hibernation_set_ops(const struct platform_hibernation_ops *ops); |
389 | extern int hibernate(void); | 391 | extern int hibernate(void); |
diff --git a/kernel/power/power.h b/kernel/power/power.h index f29cd178df90..9e58bdc8a562 100644 --- a/kernel/power/power.h +++ b/kernel/power/power.h | |||
@@ -104,9 +104,6 @@ extern int in_suspend; | |||
104 | extern dev_t swsusp_resume_device; | 104 | extern dev_t swsusp_resume_device; |
105 | extern sector_t swsusp_resume_block; | 105 | extern sector_t swsusp_resume_block; |
106 | 106 | ||
107 | extern asmlinkage int swsusp_arch_suspend(void); | ||
108 | extern asmlinkage int swsusp_arch_resume(void); | ||
109 | |||
110 | extern int create_basic_memory_bitmaps(void); | 107 | extern int create_basic_memory_bitmaps(void); |
111 | extern void free_basic_memory_bitmaps(void); | 108 | extern void free_basic_memory_bitmaps(void); |
112 | extern int hibernate_preallocate_memory(void); | 109 | extern int hibernate_preallocate_memory(void); |