diff options
author | Linus Torvalds <torvalds@linux-foundation.org> | 2019-01-05 20:51:36 -0500 |
---|---|---|
committer | Linus Torvalds <torvalds@linux-foundation.org> | 2019-01-05 20:51:36 -0500 |
commit | 1686cc1a31f45a3fd090e5d0c6fce777422e13fa (patch) | |
tree | ec4bac3bb19e47a1d81c30e7e35a0b5380c9e99f | |
parent | 5c4a60831aa6d937cec9cf17aef8eb6c1851bfcd (diff) | |
parent | 5f30b2e823484ce6a79f2b59901b6351c15effa6 (diff) |
Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/jikos/livepatching
Pull livepatch update from Jiri Kosina:
"Return value checking fixup in livepatching samples, from Nicholas Mc
Guire"
* 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/jikos/livepatching:
livepatch: check kzalloc return values
-rw-r--r-- | samples/livepatch/livepatch-shadow-fix1.c | 5 | ||||
-rw-r--r-- | samples/livepatch/livepatch-shadow-mod.c | 4 |
2 files changed, 9 insertions, 0 deletions
diff --git a/samples/livepatch/livepatch-shadow-fix1.c b/samples/livepatch/livepatch-shadow-fix1.c index 49b13553eaae..e8f1bd6b29b1 100644 --- a/samples/livepatch/livepatch-shadow-fix1.c +++ b/samples/livepatch/livepatch-shadow-fix1.c | |||
@@ -89,6 +89,11 @@ struct dummy *livepatch_fix1_dummy_alloc(void) | |||
89 | * pointer to handle resource release. | 89 | * pointer to handle resource release. |
90 | */ | 90 | */ |
91 | leak = kzalloc(sizeof(int), GFP_KERNEL); | 91 | leak = kzalloc(sizeof(int), GFP_KERNEL); |
92 | if (!leak) { | ||
93 | kfree(d); | ||
94 | return NULL; | ||
95 | } | ||
96 | |||
92 | klp_shadow_alloc(d, SV_LEAK, sizeof(leak), GFP_KERNEL, | 97 | klp_shadow_alloc(d, SV_LEAK, sizeof(leak), GFP_KERNEL, |
93 | shadow_leak_ctor, leak); | 98 | shadow_leak_ctor, leak); |
94 | 99 | ||
diff --git a/samples/livepatch/livepatch-shadow-mod.c b/samples/livepatch/livepatch-shadow-mod.c index 4c54b250332d..4aa8a88d3cd6 100644 --- a/samples/livepatch/livepatch-shadow-mod.c +++ b/samples/livepatch/livepatch-shadow-mod.c | |||
@@ -118,6 +118,10 @@ noinline struct dummy *dummy_alloc(void) | |||
118 | 118 | ||
119 | /* Oops, forgot to save leak! */ | 119 | /* Oops, forgot to save leak! */ |
120 | leak = kzalloc(sizeof(int), GFP_KERNEL); | 120 | leak = kzalloc(sizeof(int), GFP_KERNEL); |
121 | if (!leak) { | ||
122 | kfree(d); | ||
123 | return NULL; | ||
124 | } | ||
121 | 125 | ||
122 | pr_info("%s: dummy @ %p, expires @ %lx\n", | 126 | pr_info("%s: dummy @ %p, expires @ %lx\n", |
123 | __func__, d, d->jiffies_expire); | 127 | __func__, d, d->jiffies_expire); |