aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorWill Deacon <will.deacon@arm.com>2019-02-22 12:18:02 -0500
committerWill Deacon <will.deacon@arm.com>2019-04-08 07:09:05 -0400
commit161861a4c8279f136e5419deb95c58176af83e48 (patch)
tree021f3aa8c03d950fbb530f05b1ce1fb6258643d4
parentfb24ea52f78e0d595852e09e3a55697c8f442189 (diff)
scsi/qla1280: Remove stale comment about mmiowb()
All mmiowb() invocations have been removed, so there's no need to keep banging on about it. Acked-by: Linus Torvalds <torvalds@linux-foundation.org> Signed-off-by: Will Deacon <will.deacon@arm.com>
-rw-r--r--drivers/scsi/qla1280.c10
1 files changed, 0 insertions, 10 deletions
diff --git a/drivers/scsi/qla1280.c b/drivers/scsi/qla1280.c
index 93acbc5094f0..327eff67a1ee 100644
--- a/drivers/scsi/qla1280.c
+++ b/drivers/scsi/qla1280.c
@@ -3363,16 +3363,6 @@ qla1280_isp_cmd(struct scsi_qla_host *ha)
3363 3363
3364 /* 3364 /*
3365 * Update request index to mailbox4 (Request Queue In). 3365 * Update request index to mailbox4 (Request Queue In).
3366 * The mmiowb() ensures that this write is ordered with writes by other
3367 * CPUs. Without the mmiowb(), it is possible for the following:
3368 * CPUA posts write of index 5 to mailbox4
3369 * CPUA releases host lock
3370 * CPUB acquires host lock
3371 * CPUB posts write of index 6 to mailbox4
3372 * On PCI bus, order reverses and write of 6 posts, then index 5,
3373 * causing chip to issue full queue of stale commands
3374 * The mmiowb() prevents future writes from crossing the barrier.
3375 * See Documentation/driver-api/device-io.rst for more information.
3376 */ 3366 */
3377 WRT_REG_WORD(&reg->mailbox4, ha->req_ring_index); 3367 WRT_REG_WORD(&reg->mailbox4, ha->req_ring_index);
3378 3368