Merge branch 'qed-fixes'

Sudarsana Reddy Kalluru says:

====================
qed*: Bug fix series.

The series contains minor bug fixes for qed/qede drivers.

Please consider applying it to 'net' branch.
====================

Signed-off-by: David S. Miller <davem@davemloft.net>

6 files changed, 24 insertions, 12 deletions

diff --git a/drivers/net/ethernet/qlogic/qed/qed_dev.c b/drivers/net/ethernet/qlogic/qed/qed_dev.c
index 5f31140d0b77..bb70522ad362 100644
--- a/drivers/net/ethernet/qlogic/qed/qed_dev.c
+++ b/drivers/net/ethernet/qlogic/qed/qed_dev.c
@@ -2536,6 +2536,9 @@ static int qed_hw_get_nvm_info(struct qed_hwfn *p_hwfn, struct qed_ptt *p_ptt)
                 DP_NOTICE(p_hwfn, "Unknown Speed in 0x%08x\n", link_temp);
         }
 
+        p_hwfn->mcp_info->link_capabilities.default_speed_autoneg =
+                link->speed.autoneg;
+
         link_temp &= NVM_CFG1_PORT_DRV_FLOW_CONTROL_MASK;
         link_temp >>= NVM_CFG1_PORT_DRV_FLOW_CONTROL_OFFSET;
         link->pause.autoneg = !!(link_temp &
@@ -3586,7 +3589,7 @@ static int qed_set_coalesce(struct qed_hwfn *p_hwfn, struct qed_ptt *p_ptt,
 }
 
 int qed_set_rxq_coalesce(struct qed_hwfn *p_hwfn, struct qed_ptt *p_ptt,
-                         u16 coalesce, u8 qid, u16 sb_id)
+                         u16 coalesce, u16 qid, u16 sb_id)
 {
         struct ustorm_eth_queue_zone eth_qzone;
         u8 timeset, timer_res;
@@ -3607,7 +3610,7 @@ int qed_set_rxq_coalesce(struct qed_hwfn *p_hwfn, struct qed_ptt *p_ptt,
         }
         timeset = (u8)(coalesce >> timer_res);
 
-        rc = qed_fw_l2_queue(p_hwfn, (u16)qid, &fw_qid);
+        rc = qed_fw_l2_queue(p_hwfn, qid, &fw_qid);
         if (rc)
                 return rc;
 
@@ -3628,7 +3631,7 @@ out:
 }
 
 int qed_set_txq_coalesce(struct qed_hwfn *p_hwfn, struct qed_ptt *p_ptt,
-                         u16 coalesce, u8 qid, u16 sb_id)
+                         u16 coalesce, u16 qid, u16 sb_id)
 {
         struct xstorm_eth_queue_zone eth_qzone;
         u8 timeset, timer_res;
@@ -3649,7 +3652,7 @@ int qed_set_txq_coalesce(struct qed_hwfn *p_hwfn, struct qed_ptt *p_ptt,
         }
         timeset = (u8)(coalesce >> timer_res);
 
-        rc = qed_fw_l2_queue(p_hwfn, (u16)qid, &fw_qid);
+        rc = qed_fw_l2_queue(p_hwfn, qid, &fw_qid);
         if (rc)
                 return rc;
 
diff --git a/drivers/net/ethernet/qlogic/qed/qed_dev_api.h b/drivers/net/ethernet/qlogic/qed/qed_dev_api.h
index cefe3ee9064a..12d16c096e36 100644
--- a/drivers/net/ethernet/qlogic/qed/qed_dev_api.h
+++ b/drivers/net/ethernet/qlogic/qed/qed_dev_api.h
@@ -454,7 +454,7 @@ int qed_final_cleanup(struct qed_hwfn *p_hwfn,
  * @return int
  */
 int qed_set_rxq_coalesce(struct qed_hwfn *p_hwfn, struct qed_ptt *p_ptt,
-                         u16 coalesce, u8 qid, u16 sb_id);
+                         u16 coalesce, u16 qid, u16 sb_id);
 
 /**
  * @brief qed_set_txq_coalesce - Configure coalesce parameters for a Tx queue
@@ -471,7 +471,7 @@ int qed_set_rxq_coalesce(struct qed_hwfn *p_hwfn, struct qed_ptt *p_ptt,
  * @return int
  */
 int qed_set_txq_coalesce(struct qed_hwfn *p_hwfn, struct qed_ptt *p_ptt,
-                         u16 coalesce, u8 qid, u16 sb_id);
+                         u16 coalesce, u16 qid, u16 sb_id);
 
 const char *qed_hw_get_resc_name(enum qed_resources res_id);
 #endif
diff --git a/drivers/net/ethernet/qlogic/qed/qed_main.c b/drivers/net/ethernet/qlogic/qed/qed_main.c
index 59992cf20d42..b7ad36b91e12 100644
--- a/drivers/net/ethernet/qlogic/qed/qed_main.c
+++ b/drivers/net/ethernet/qlogic/qed/qed_main.c
@@ -1372,7 +1372,7 @@ static void qed_fill_link(struct qed_hwfn *hwfn,
 
         /* TODO - at the moment assume supported and advertised speed equal */
         if_link->supported_caps = QED_LM_FIBRE_BIT;
-        if (params.speed.autoneg)
+        if (link_caps.default_speed_autoneg)
                 if_link->supported_caps |= QED_LM_Autoneg_BIT;
         if (params.pause.autoneg ||
             (params.pause.forced_rx && params.pause.forced_tx))
@@ -1382,6 +1382,10 @@ static void qed_fill_link(struct qed_hwfn *hwfn,
                 if_link->supported_caps |= QED_LM_Pause_BIT;
 
         if_link->advertised_caps = if_link->supported_caps;
+        if (params.speed.autoneg)
+                if_link->advertised_caps |= QED_LM_Autoneg_BIT;
+        else
+                if_link->advertised_caps &= ~QED_LM_Autoneg_BIT;
         if (params.speed.advertised_speeds &
             NVM_CFG1_PORT_DRV_SPEED_CAPABILITY_MASK_1G)
                 if_link->advertised_caps |= QED_LM_1000baseT_Half_BIT |
@@ -1521,7 +1525,7 @@ static void qed_get_coalesce(struct qed_dev *cdev, u16 *rx_coal, u16 *tx_coal)
 }
 
 static int qed_set_coalesce(struct qed_dev *cdev, u16 rx_coal, u16 tx_coal,
-                            u8 qid, u16 sb_id)
+                            u16 qid, u16 sb_id)
 {
         struct qed_hwfn *hwfn;
         struct qed_ptt *ptt;
diff --git a/drivers/net/ethernet/qlogic/qed/qed_mcp.h b/drivers/net/ethernet/qlogic/qed/qed_mcp.h
index 5ae35d6cc7d1..2b09b8545236 100644
--- a/drivers/net/ethernet/qlogic/qed/qed_mcp.h
+++ b/drivers/net/ethernet/qlogic/qed/qed_mcp.h
@@ -61,6 +61,7 @@ struct qed_mcp_link_params {
 
 struct qed_mcp_link_capabilities {
         u32 speed_capabilities;
+        bool default_speed_autoneg;
 };
 
 struct qed_mcp_link_state {
diff --git a/drivers/net/ethernet/qlogic/qede/qede_ethtool.c b/drivers/net/ethernet/qlogic/qede/qede_ethtool.c
index 4dcfe9614731..172b292241a5 100644
--- a/drivers/net/ethernet/qlogic/qede/qede_ethtool.c
+++ b/drivers/net/ethernet/qlogic/qede/qede_ethtool.c
@@ -493,6 +493,11 @@ static int qede_set_link_ksettings(struct net_device *dev,
         params.override_flags |= QED_LINK_OVERRIDE_SPEED_ADV_SPEEDS;
         params.override_flags |= QED_LINK_OVERRIDE_SPEED_AUTONEG;
         if (base->autoneg == AUTONEG_ENABLE) {
+                if (!(current_link.supported_caps & QED_LM_Autoneg_BIT)) {
+                        DP_INFO(edev, "Auto negotiation is not supported\n");
+                        return -EOPNOTSUPP;
+                }
+
                 params.autoneg = true;
                 params.forced_speed = 0;
                 QEDE_ETHTOOL_TO_DRV_CAPS(params.adv_speeds, cmd, advertising)
@@ -706,8 +711,7 @@ static int qede_set_coalesce(struct net_device *dev,
 {
         struct qede_dev *edev = netdev_priv(dev);
         int i, rc = 0;
-        u16 rxc, txc;
-        u8 sb_id;
+        u16 rxc, txc, sb_id;
 
         if (!netif_running(dev)) {
                 DP_INFO(edev, "Interface is down\n");
@@ -729,7 +733,7 @@ static int qede_set_coalesce(struct net_device *dev,
         for_each_queue(i) {
                 sb_id = edev->fp_array[i].sb_info->igu_sb_id;
                 rc = edev->ops->common->set_coalesce(edev->cdev, rxc, txc,
-                                                     (u8)i, sb_id);
+                                                     (u16)i, sb_id);
                 if (rc) {
                         DP_INFO(edev, "Set coalesce error, rc = %d\n", rc);
                         return rc;
diff --git a/include/linux/qed/qed_if.h b/include/linux/qed/qed_if.h
index 5544d7b2f2bb..c70ac13a97e6 100644
--- a/include/linux/qed/qed_if.h
+++ b/include/linux/qed/qed_if.h
@@ -635,7 +635,7 @@ struct qed_common_ops {
  * @return 0 on success, error otherwise.
  */
         int (*set_coalesce)(struct qed_dev *cdev, u16 rx_coal, u16 tx_coal,
-                            u8 qid, u16 sb_id);
+                            u16 qid, u16 sb_id);
 
 /**
  * @brief set_led - Configure LED mode