diff options
author | Linus Walleij <linus.walleij@linaro.org> | 2018-01-13 16:52:33 -0500 |
---|---|---|
committer | Linus Walleij <linus.walleij@linaro.org> | 2018-01-13 16:54:05 -0500 |
commit | 14ec018e15595d3e5c11160eef3f18c0b9c72e3f (patch) | |
tree | ae124168fce84458123711f6b4440389ce26a727 | |
parent | 2e21ec4c40eb9d40d1b2d719fcb40726ae8bf4b2 (diff) |
gpio: bcm-kona: Include proper header
This driver has no business including <linux/gpio.h>, it is a
driver so include <linux/gpio/driver.h>.
GPIOF_DIR_IN/GPIOF_DIR_OUT are for consumers and should not be
used in drivers to use just 1/0 instead.
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
-rw-r--r-- | drivers/gpio/gpio-bcm-kona.c | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/drivers/gpio/gpio-bcm-kona.c b/drivers/gpio/gpio-bcm-kona.c index dfcf56ee3c61..f4c793e9a92b 100644 --- a/drivers/gpio/gpio-bcm-kona.c +++ b/drivers/gpio/gpio-bcm-kona.c | |||
@@ -17,7 +17,7 @@ | |||
17 | #include <linux/bitops.h> | 17 | #include <linux/bitops.h> |
18 | #include <linux/err.h> | 18 | #include <linux/err.h> |
19 | #include <linux/io.h> | 19 | #include <linux/io.h> |
20 | #include <linux/gpio.h> | 20 | #include <linux/gpio/driver.h> |
21 | #include <linux/of_device.h> | 21 | #include <linux/of_device.h> |
22 | #include <linux/of_irq.h> | 22 | #include <linux/of_irq.h> |
23 | #include <linux/init.h> | 23 | #include <linux/init.h> |
@@ -127,7 +127,7 @@ static int bcm_kona_gpio_get_dir(struct gpio_chip *chip, unsigned gpio) | |||
127 | u32 val; | 127 | u32 val; |
128 | 128 | ||
129 | val = readl(reg_base + GPIO_CONTROL(gpio)) & GPIO_GPCTR0_IOTR_MASK; | 129 | val = readl(reg_base + GPIO_CONTROL(gpio)) & GPIO_GPCTR0_IOTR_MASK; |
130 | return val ? GPIOF_DIR_IN : GPIOF_DIR_OUT; | 130 | return !!val; |
131 | } | 131 | } |
132 | 132 | ||
133 | static void bcm_kona_gpio_set(struct gpio_chip *chip, unsigned gpio, int value) | 133 | static void bcm_kona_gpio_set(struct gpio_chip *chip, unsigned gpio, int value) |
@@ -144,7 +144,7 @@ static void bcm_kona_gpio_set(struct gpio_chip *chip, unsigned gpio, int value) | |||
144 | raw_spin_lock_irqsave(&kona_gpio->lock, flags); | 144 | raw_spin_lock_irqsave(&kona_gpio->lock, flags); |
145 | 145 | ||
146 | /* this function only applies to output pin */ | 146 | /* this function only applies to output pin */ |
147 | if (bcm_kona_gpio_get_dir(chip, gpio) == GPIOF_DIR_IN) | 147 | if (bcm_kona_gpio_get_dir(chip, gpio) == 1) |
148 | goto out; | 148 | goto out; |
149 | 149 | ||
150 | reg_offset = value ? GPIO_OUT_SET(bank_id) : GPIO_OUT_CLEAR(bank_id); | 150 | reg_offset = value ? GPIO_OUT_SET(bank_id) : GPIO_OUT_CLEAR(bank_id); |
@@ -170,7 +170,7 @@ static int bcm_kona_gpio_get(struct gpio_chip *chip, unsigned gpio) | |||
170 | reg_base = kona_gpio->reg_base; | 170 | reg_base = kona_gpio->reg_base; |
171 | raw_spin_lock_irqsave(&kona_gpio->lock, flags); | 171 | raw_spin_lock_irqsave(&kona_gpio->lock, flags); |
172 | 172 | ||
173 | if (bcm_kona_gpio_get_dir(chip, gpio) == GPIOF_DIR_IN) | 173 | if (bcm_kona_gpio_get_dir(chip, gpio) == 1) |
174 | reg_offset = GPIO_IN_STATUS(bank_id); | 174 | reg_offset = GPIO_IN_STATUS(bank_id); |
175 | else | 175 | else |
176 | reg_offset = GPIO_OUT_STATUS(bank_id); | 176 | reg_offset = GPIO_OUT_STATUS(bank_id); |