aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorWu Fengguang <fengguang.wu@intel.com>2011-12-09 07:42:18 -0500
committerKeith Packard <keithp@keithp.com>2011-12-19 22:15:47 -0500
commit1202b4c6782e57a71c4b162a51a4e7ad8402a950 (patch)
tree04efbec349925d70ef1a93322509406007bddddf
parentb3f33cbf7ace8fc149993ee35e0d0fd57f41d6d8 (diff)
drm/i915: rename audio ELD registers
Change the definitions from GEN5 to IBX as they aren't in the CPU and some SNB systems actually shipped with IBX chipsets (or, at least that's a supported configuration). The GEN7_* register addresses actually take effect since GEN6 and should be prefixed by CPT, the PCH code name. Suggested-by: Keith Packard <keithp@keithp.com> Signed-off-by: Wu Fengguang <fengguang.wu@intel.com> Signed-off-by: Keith Packard <keithp@keithp.com>
-rw-r--r--drivers/gpu/drm/i915/i915_reg.h24
-rw-r--r--drivers/gpu/drm/i915/intel_display.c22
2 files changed, 23 insertions, 23 deletions
diff --git a/drivers/gpu/drm/i915/i915_reg.h b/drivers/gpu/drm/i915/i915_reg.h
index a26d5b0a3690..771a05880f19 100644
--- a/drivers/gpu/drm/i915/i915_reg.h
+++ b/drivers/gpu/drm/i915/i915_reg.h
@@ -3569,17 +3569,17 @@
3569#define G4X_ELD_ACK (1 << 4) 3569#define G4X_ELD_ACK (1 << 4)
3570#define G4X_HDMIW_HDMIEDID 0x6210C 3570#define G4X_HDMIW_HDMIEDID 0x6210C
3571 3571
3572#define GEN5_HDMIW_HDMIEDID_A 0xE2050 3572#define IBX_HDMIW_HDMIEDID_A 0xE2050
3573#define GEN5_AUD_CNTL_ST_A 0xE20B4 3573#define IBX_AUD_CNTL_ST_A 0xE20B4
3574#define GEN5_ELD_BUFFER_SIZE (0x1f << 10) 3574#define IBX_ELD_BUFFER_SIZE (0x1f << 10)
3575#define GEN5_ELD_ADDRESS (0x1f << 5) 3575#define IBX_ELD_ADDRESS (0x1f << 5)
3576#define GEN5_ELD_ACK (1 << 4) 3576#define IBX_ELD_ACK (1 << 4)
3577#define GEN5_AUD_CNTL_ST2 0xE20C0 3577#define IBX_AUD_CNTL_ST2 0xE20C0
3578#define GEN5_ELD_VALIDB (1 << 0) 3578#define IBX_ELD_VALIDB (1 << 0)
3579#define GEN5_CP_READYB (1 << 1) 3579#define IBX_CP_READYB (1 << 1)
3580 3580
3581#define GEN7_HDMIW_HDMIEDID_A 0xE5050 3581#define CPT_HDMIW_HDMIEDID_A 0xE5050
3582#define GEN7_AUD_CNTRL_ST_A 0xE50B4 3582#define CPT_AUD_CNTL_ST_A 0xE50B4
3583#define GEN7_AUD_CNTRL_ST2 0xE50C0 3583#define CPT_AUD_CNTRL_ST2 0xE50C0
3584 3584
3585#endif /* _I915_REG_H_ */ 3585#endif /* _I915_REG_H_ */
diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c
index 8a61b819b4bd..8d322ab1a6f0 100644
--- a/drivers/gpu/drm/i915/intel_display.c
+++ b/drivers/gpu/drm/i915/intel_display.c
@@ -5877,13 +5877,13 @@ static void ironlake_write_eld(struct drm_connector *connector,
5877 int aud_cntrl_st2; 5877 int aud_cntrl_st2;
5878 5878
5879 if (HAS_PCH_IBX(connector->dev)) { 5879 if (HAS_PCH_IBX(connector->dev)) {
5880 hdmiw_hdmiedid = GEN5_HDMIW_HDMIEDID_A; 5880 hdmiw_hdmiedid = IBX_HDMIW_HDMIEDID_A;
5881 aud_cntl_st = GEN5_AUD_CNTL_ST_A; 5881 aud_cntl_st = IBX_AUD_CNTL_ST_A;
5882 aud_cntrl_st2 = GEN5_AUD_CNTL_ST2; 5882 aud_cntrl_st2 = IBX_AUD_CNTL_ST2;
5883 } else { 5883 } else {
5884 hdmiw_hdmiedid = GEN7_HDMIW_HDMIEDID_A; 5884 hdmiw_hdmiedid = CPT_HDMIW_HDMIEDID_A;
5885 aud_cntl_st = GEN7_AUD_CNTRL_ST_A; 5885 aud_cntl_st = CPT_AUD_CNTL_ST_A;
5886 aud_cntrl_st2 = GEN7_AUD_CNTRL_ST2; 5886 aud_cntrl_st2 = CPT_AUD_CNTRL_ST2;
5887 } 5887 }
5888 5888
5889 i = to_intel_crtc(crtc)->pipe; 5889 i = to_intel_crtc(crtc)->pipe;
@@ -5897,12 +5897,12 @@ static void ironlake_write_eld(struct drm_connector *connector,
5897 if (!i) { 5897 if (!i) {
5898 DRM_DEBUG_DRIVER("Audio directed to unknown port\n"); 5898 DRM_DEBUG_DRIVER("Audio directed to unknown port\n");
5899 /* operate blindly on all ports */ 5899 /* operate blindly on all ports */
5900 eldv = GEN5_ELD_VALIDB; 5900 eldv = IBX_ELD_VALIDB;
5901 eldv |= GEN5_ELD_VALIDB << 4; 5901 eldv |= IBX_ELD_VALIDB << 4;
5902 eldv |= GEN5_ELD_VALIDB << 8; 5902 eldv |= IBX_ELD_VALIDB << 8;
5903 } else { 5903 } else {
5904 DRM_DEBUG_DRIVER("ELD on port %c\n", 'A' + i); 5904 DRM_DEBUG_DRIVER("ELD on port %c\n", 'A' + i);
5905 eldv = GEN5_ELD_VALIDB << ((i - 1) * 4); 5905 eldv = IBX_ELD_VALIDB << ((i - 1) * 4);
5906 } 5906 }
5907 5907
5908 i = I915_READ(aud_cntrl_st2); 5908 i = I915_READ(aud_cntrl_st2);
@@ -5918,7 +5918,7 @@ static void ironlake_write_eld(struct drm_connector *connector,
5918 } 5918 }
5919 5919
5920 i = I915_READ(aud_cntl_st); 5920 i = I915_READ(aud_cntl_st);
5921 i &= ~GEN5_ELD_ADDRESS; 5921 i &= ~IBX_ELD_ADDRESS;
5922 I915_WRITE(aud_cntl_st, i); 5922 I915_WRITE(aud_cntl_st, i);
5923 5923
5924 len = min_t(uint8_t, eld[2], 21); /* 84 bytes of hw ELD buffer */ 5924 len = min_t(uint8_t, eld[2], 21); /* 84 bytes of hw ELD buffer */