diff options
author | Dan Carpenter <dan.carpenter@oracle.com> | 2017-04-21 06:49:37 -0400 |
---|---|---|
committer | David S. Miller <davem@davemloft.net> | 2017-04-24 12:38:03 -0400 |
commit | 11faa7b0359aaf7efd406b7a6a077fda2b037d8e (patch) | |
tree | 2fc20f5dad734fd57c99220811882b48741ed824 | |
parent | 1510d728639e183b60bd1285b09a49c393923ba5 (diff) |
net: tc35815: move free after the dereference
We dereference "skb" to get "skb->len" so we should probably do that
step before freeing the skb.
Fixes: eea221ce4880 ("tc35815 driver update (take 2)")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
-rw-r--r-- | drivers/net/ethernet/toshiba/tc35815.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/net/ethernet/toshiba/tc35815.c b/drivers/net/ethernet/toshiba/tc35815.c index a45f98fa4aa7..3dadee1080b9 100644 --- a/drivers/net/ethernet/toshiba/tc35815.c +++ b/drivers/net/ethernet/toshiba/tc35815.c | |||
@@ -1017,8 +1017,8 @@ tc35815_free_queues(struct net_device *dev) | |||
1017 | BUG_ON(lp->tx_skbs[i].skb != skb); | 1017 | BUG_ON(lp->tx_skbs[i].skb != skb); |
1018 | #endif | 1018 | #endif |
1019 | if (skb) { | 1019 | if (skb) { |
1020 | dev_kfree_skb(skb); | ||
1021 | pci_unmap_single(lp->pci_dev, lp->tx_skbs[i].skb_dma, skb->len, PCI_DMA_TODEVICE); | 1020 | pci_unmap_single(lp->pci_dev, lp->tx_skbs[i].skb_dma, skb->len, PCI_DMA_TODEVICE); |
1021 | dev_kfree_skb(skb); | ||
1022 | lp->tx_skbs[i].skb = NULL; | 1022 | lp->tx_skbs[i].skb = NULL; |
1023 | lp->tx_skbs[i].skb_dma = 0; | 1023 | lp->tx_skbs[i].skb_dma = 0; |
1024 | } | 1024 | } |