diff options
author | Imre Deak <imre.deak@intel.com> | 2016-06-28 06:37:31 -0400 |
---|---|---|
committer | Jani Nikula <jani.nikula@intel.com> | 2016-06-29 04:17:50 -0400 |
commit | 11f6145791775ce41b8993fd29e19eb53ef0ff14 (patch) | |
tree | 49905c76f8d7898ef6ec421d55a29cf9a01f9037 | |
parent | ea12e2a0cad62f6d634da62e7bf50ffe077de13b (diff) |
drm/i915/lpt: Avoid early timeout during FDI PHY reset
Since wait_for_atomic doesn't re-check the wait-for condition after
expiry of the timeout it can fail when called from non-atomic context
even if the condition is set correctly before the expiry. Fix this by
using the non-atomic wait_for instead.
Fixes: 0351b93992aa ("drm/i915: Do not lie about atomic timeout granularity")
CC: Chris Wilson <chris@chris-wilson.co.uk>
CC: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Signed-off-by: Imre Deak <imre.deak@intel.com>
Reviewed-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
CC: drm-intel-fixes@lists.freedesktop.org
Link: http://patchwork.freedesktop.org/patch/msgid/1467110253-16046-3-git-send-email-imre.deak@intel.com
(cherry picked from commit cf3598c23cd09d5f063fa8c12fe9ddd5a352d3d5)
Signed-off-by: Jani Nikula <jani.nikula@intel.com>
-rw-r--r-- | drivers/gpu/drm/i915/intel_display.c | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c index 56a1637c864f..a164ea44f668 100644 --- a/drivers/gpu/drm/i915/intel_display.c +++ b/drivers/gpu/drm/i915/intel_display.c | |||
@@ -8447,16 +8447,16 @@ static void lpt_reset_fdi_mphy(struct drm_i915_private *dev_priv) | |||
8447 | tmp |= FDI_MPHY_IOSFSB_RESET_CTL; | 8447 | tmp |= FDI_MPHY_IOSFSB_RESET_CTL; |
8448 | I915_WRITE(SOUTH_CHICKEN2, tmp); | 8448 | I915_WRITE(SOUTH_CHICKEN2, tmp); |
8449 | 8449 | ||
8450 | if (wait_for_atomic_us(I915_READ(SOUTH_CHICKEN2) & | 8450 | if (wait_for_us(I915_READ(SOUTH_CHICKEN2) & |
8451 | FDI_MPHY_IOSFSB_RESET_STATUS, 100)) | 8451 | FDI_MPHY_IOSFSB_RESET_STATUS, 100)) |
8452 | DRM_ERROR("FDI mPHY reset assert timeout\n"); | 8452 | DRM_ERROR("FDI mPHY reset assert timeout\n"); |
8453 | 8453 | ||
8454 | tmp = I915_READ(SOUTH_CHICKEN2); | 8454 | tmp = I915_READ(SOUTH_CHICKEN2); |
8455 | tmp &= ~FDI_MPHY_IOSFSB_RESET_CTL; | 8455 | tmp &= ~FDI_MPHY_IOSFSB_RESET_CTL; |
8456 | I915_WRITE(SOUTH_CHICKEN2, tmp); | 8456 | I915_WRITE(SOUTH_CHICKEN2, tmp); |
8457 | 8457 | ||
8458 | if (wait_for_atomic_us((I915_READ(SOUTH_CHICKEN2) & | 8458 | if (wait_for_us((I915_READ(SOUTH_CHICKEN2) & |
8459 | FDI_MPHY_IOSFSB_RESET_STATUS) == 0, 100)) | 8459 | FDI_MPHY_IOSFSB_RESET_STATUS) == 0, 100)) |
8460 | DRM_ERROR("FDI mPHY reset de-assert timeout\n"); | 8460 | DRM_ERROR("FDI mPHY reset de-assert timeout\n"); |
8461 | } | 8461 | } |
8462 | 8462 | ||