diff options
author | Bart Van Assche <bart.vanassche@sandisk.com> | 2016-11-21 13:21:41 -0500 |
---|---|---|
committer | Doug Ledford <dledford@redhat.com> | 2016-12-14 13:27:34 -0500 |
commit | 11b642b84e8c43e8597de031678d15c08dd057bc (patch) | |
tree | 80b496fed472503f83f55cc63e19d11b6a3064d5 | |
parent | 2fe2f378dd45847d2643638c07a7658822087836 (diff) |
IPoIB: Avoid reading an uninitialized member variable
This patch avoids that Coverity reports the following:
Using uninitialized value port_attr.state when calling printk
Fixes: commit 94232d9ce817 ("IPoIB: Start multicast join process only on active ports")
Signed-off-by: Bart Van Assche <bart.vanassche@sandisk.com>
Cc: Erez Shitrit <erezsh@mellanox.com>
Cc: <stable@vger.kernel.org>
Reviewed-by: Leon Romanovsky <leonro@mellanox.com>
Signed-off-by: Doug Ledford <dledford@redhat.com>
-rw-r--r-- | drivers/infiniband/ulp/ipoib/ipoib_multicast.c | 7 |
1 files changed, 5 insertions, 2 deletions
diff --git a/drivers/infiniband/ulp/ipoib/ipoib_multicast.c b/drivers/infiniband/ulp/ipoib/ipoib_multicast.c index d3394b6add24..2a3980c2c670 100644 --- a/drivers/infiniband/ulp/ipoib/ipoib_multicast.c +++ b/drivers/infiniband/ulp/ipoib/ipoib_multicast.c | |||
@@ -575,8 +575,11 @@ void ipoib_mcast_join_task(struct work_struct *work) | |||
575 | if (!test_bit(IPOIB_FLAG_OPER_UP, &priv->flags)) | 575 | if (!test_bit(IPOIB_FLAG_OPER_UP, &priv->flags)) |
576 | return; | 576 | return; |
577 | 577 | ||
578 | if (ib_query_port(priv->ca, priv->port, &port_attr) || | 578 | if (ib_query_port(priv->ca, priv->port, &port_attr)) { |
579 | port_attr.state != IB_PORT_ACTIVE) { | 579 | ipoib_dbg(priv, "ib_query_port() failed\n"); |
580 | return; | ||
581 | } | ||
582 | if (port_attr.state != IB_PORT_ACTIVE) { | ||
580 | ipoib_dbg(priv, "port state is not ACTIVE (state = %d) suspending join task\n", | 583 | ipoib_dbg(priv, "port state is not ACTIVE (state = %d) suspending join task\n", |
581 | port_attr.state); | 584 | port_attr.state); |
582 | return; | 585 | return; |