diff options
author | Anna Schumaker <Anna.Schumaker@netapp.com> | 2015-06-10 16:54:28 -0400 |
---|---|---|
committer | Trond Myklebust <trond.myklebust@primarydata.com> | 2015-06-10 18:32:40 -0400 |
commit | 11598b8ff2b97cf034d0c025cf125c92b574bafc (patch) | |
tree | 5867d1835d951902f47ab03d32f8b3d87519e3cd | |
parent | c86c90c656fa2c94c2491dd86cf09501193f0dad (diff) |
NFS: Remove unused nfs_rw_ops->rw_release() function
This was only ever set to nfs_writeback_release_common(), a function
which is completely empty. Let's just drop this function pointer and
simplify the code a bit.
Signed-off-by: Anna Schumaker <Anna.Schumaker@Netapp.com>
Signed-off-by: Trond Myklebust <trond.myklebust@primarydata.com>
-rw-r--r-- | fs/nfs/pagelist.c | 2 | ||||
-rw-r--r-- | fs/nfs/write.c | 6 | ||||
-rw-r--r-- | include/linux/nfs_page.h | 1 |
3 files changed, 0 insertions, 9 deletions
diff --git a/fs/nfs/pagelist.c b/fs/nfs/pagelist.c index 282b39369510..e9953ab1ac40 100644 --- a/fs/nfs/pagelist.c +++ b/fs/nfs/pagelist.c | |||
@@ -690,8 +690,6 @@ static int nfs_pgio_error(struct nfs_pageio_descriptor *desc, | |||
690 | static void nfs_pgio_release(void *calldata) | 690 | static void nfs_pgio_release(void *calldata) |
691 | { | 691 | { |
692 | struct nfs_pgio_header *hdr = calldata; | 692 | struct nfs_pgio_header *hdr = calldata; |
693 | if (hdr->rw_ops->rw_release) | ||
694 | hdr->rw_ops->rw_release(hdr); | ||
695 | nfs_pgio_data_destroy(hdr); | 693 | nfs_pgio_data_destroy(hdr); |
696 | hdr->completion_ops->completion(hdr); | 694 | hdr->completion_ops->completion(hdr); |
697 | } | 695 | } |
diff --git a/fs/nfs/write.c b/fs/nfs/write.c index dfc19f1575a1..d0f1f210342e 100644 --- a/fs/nfs/write.c +++ b/fs/nfs/write.c | |||
@@ -1347,11 +1347,6 @@ void nfs_commit_prepare(struct rpc_task *task, void *calldata) | |||
1347 | NFS_PROTO(data->inode)->commit_rpc_prepare(task, data); | 1347 | NFS_PROTO(data->inode)->commit_rpc_prepare(task, data); |
1348 | } | 1348 | } |
1349 | 1349 | ||
1350 | static void nfs_writeback_release_common(struct nfs_pgio_header *hdr) | ||
1351 | { | ||
1352 | /* do nothing! */ | ||
1353 | } | ||
1354 | |||
1355 | /* | 1350 | /* |
1356 | * Special version of should_remove_suid() that ignores capabilities. | 1351 | * Special version of should_remove_suid() that ignores capabilities. |
1357 | */ | 1352 | */ |
@@ -2012,7 +2007,6 @@ static const struct nfs_rw_ops nfs_rw_write_ops = { | |||
2012 | .rw_mode = FMODE_WRITE, | 2007 | .rw_mode = FMODE_WRITE, |
2013 | .rw_alloc_header = nfs_writehdr_alloc, | 2008 | .rw_alloc_header = nfs_writehdr_alloc, |
2014 | .rw_free_header = nfs_writehdr_free, | 2009 | .rw_free_header = nfs_writehdr_free, |
2015 | .rw_release = nfs_writeback_release_common, | ||
2016 | .rw_done = nfs_writeback_done, | 2010 | .rw_done = nfs_writeback_done, |
2017 | .rw_result = nfs_writeback_result, | 2011 | .rw_result = nfs_writeback_result, |
2018 | .rw_initiate = nfs_initiate_write, | 2012 | .rw_initiate = nfs_initiate_write, |
diff --git a/include/linux/nfs_page.h b/include/linux/nfs_page.h index 3eb072dbce83..f2f650f136ee 100644 --- a/include/linux/nfs_page.h +++ b/include/linux/nfs_page.h | |||
@@ -67,7 +67,6 @@ struct nfs_rw_ops { | |||
67 | const fmode_t rw_mode; | 67 | const fmode_t rw_mode; |
68 | struct nfs_pgio_header *(*rw_alloc_header)(void); | 68 | struct nfs_pgio_header *(*rw_alloc_header)(void); |
69 | void (*rw_free_header)(struct nfs_pgio_header *); | 69 | void (*rw_free_header)(struct nfs_pgio_header *); |
70 | void (*rw_release)(struct nfs_pgio_header *); | ||
71 | int (*rw_done)(struct rpc_task *, struct nfs_pgio_header *, | 70 | int (*rw_done)(struct rpc_task *, struct nfs_pgio_header *, |
72 | struct inode *); | 71 | struct inode *); |
73 | void (*rw_result)(struct rpc_task *, struct nfs_pgio_header *); | 72 | void (*rw_result)(struct rpc_task *, struct nfs_pgio_header *); |