aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorBryant G. Ly <bgly@us.ibm.com>2017-01-09 11:21:20 -0500
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>2017-01-19 14:18:03 -0500
commit0edcc47cdb7f2d80c1e7236f5f797b7443cb2142 (patch)
tree28ba78e7a75391619f4c988d73b9cdb11c8c80d9
parentba04d869974ed02c8ac1769a6693d925bd861f68 (diff)
ibmvscsis: Fix srp_transfer_data fail return code
commit 7c9d8d0c41b3e24473ac7648a7fc2d644ccf08ff upstream. If srp_transfer_data fails within ibmvscsis_write_pending, then the most likely scenario is that the client timed out the op and removed the TCE mapping. Thus it will loop forever retrying the op that is pretty much guaranteed to fail forever. A better return code would be EIO instead of EAGAIN. Reported-by: Steven Royer <seroyer@linux.vnet.ibm.com> Tested-by: Steven Royer <seroyer@linux.vnet.ibm.com> Signed-off-by: Bryant G. Ly <bgly@us.ibm.com> Signed-off-by: Bart Van Assche <bart.vanassche@sandisk.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-rw-r--r--drivers/scsi/ibmvscsi_tgt/ibmvscsi_tgt.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/scsi/ibmvscsi_tgt/ibmvscsi_tgt.c b/drivers/scsi/ibmvscsi_tgt/ibmvscsi_tgt.c
index 642b739ad0da..608140f16d98 100644
--- a/drivers/scsi/ibmvscsi_tgt/ibmvscsi_tgt.c
+++ b/drivers/scsi/ibmvscsi_tgt/ibmvscsi_tgt.c
@@ -3702,7 +3702,7 @@ static int ibmvscsis_write_pending(struct se_cmd *se_cmd)
3702 1, 1); 3702 1, 1);
3703 if (rc) { 3703 if (rc) {
3704 pr_err("srp_transfer_data() failed: %d\n", rc); 3704 pr_err("srp_transfer_data() failed: %d\n", rc);
3705 return -EAGAIN; 3705 return -EIO;
3706 } 3706 }
3707 /* 3707 /*
3708 * We now tell TCM to add this WRITE CDB directly into the TCM storage 3708 * We now tell TCM to add this WRITE CDB directly into the TCM storage