diff options
author | weiyongjun (A) <weiyongjun1@huawei.com> | 2018-01-17 21:23:34 -0500 |
---|---|---|
committer | Johannes Berg <johannes.berg@intel.com> | 2018-01-22 08:03:29 -0500 |
commit | 0ddcff49b672239dda94d70d0fcf50317a9f4b51 (patch) | |
tree | 1f56d918fd6c09941ba415f0bb2f03cf11c8c898 | |
parent | 9cb05f93d618ff414a9d0e982c0c93f3daba7463 (diff) |
mac80211_hwsim: fix possible memory leak in hwsim_new_radio_nl()
'hwname' is malloced in hwsim_new_radio_nl() and should be freed
before leaving from the error handling cases, otherwise it will cause
memory leak.
Fixes: ff4dd73dd2b4 ("mac80211_hwsim: check HWSIM_ATTR_RADIO_NAME length")
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
Reviewed-by: Ben Hutchings <ben.hutchings@codethink.co.uk>
Signed-off-by: Johannes Berg <johannes.berg@intel.com>
-rw-r--r-- | drivers/net/wireless/mac80211_hwsim.c | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/drivers/net/wireless/mac80211_hwsim.c b/drivers/net/wireless/mac80211_hwsim.c index 6bf063adcbde..66c2ac0397da 100644 --- a/drivers/net/wireless/mac80211_hwsim.c +++ b/drivers/net/wireless/mac80211_hwsim.c | |||
@@ -3197,8 +3197,10 @@ static int hwsim_new_radio_nl(struct sk_buff *msg, struct genl_info *info) | |||
3197 | if (info->attrs[HWSIM_ATTR_REG_CUSTOM_REG]) { | 3197 | if (info->attrs[HWSIM_ATTR_REG_CUSTOM_REG]) { |
3198 | u32 idx = nla_get_u32(info->attrs[HWSIM_ATTR_REG_CUSTOM_REG]); | 3198 | u32 idx = nla_get_u32(info->attrs[HWSIM_ATTR_REG_CUSTOM_REG]); |
3199 | 3199 | ||
3200 | if (idx >= ARRAY_SIZE(hwsim_world_regdom_custom)) | 3200 | if (idx >= ARRAY_SIZE(hwsim_world_regdom_custom)) { |
3201 | kfree(hwname); | ||
3201 | return -EINVAL; | 3202 | return -EINVAL; |
3203 | } | ||
3202 | param.regd = hwsim_world_regdom_custom[idx]; | 3204 | param.regd = hwsim_world_regdom_custom[idx]; |
3203 | } | 3205 | } |
3204 | 3206 | ||