aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorFlorian Westphal <fw@strlen.de>2019-07-02 14:41:14 -0400
committerPablo Neira Ayuso <pablo@netfilter.org>2019-07-03 20:29:49 -0400
commit0d9cb300acad29f25ea23d2592e69970bc61f14c (patch)
treebee8478ed6dcdd6ce776675ae497ed4f490f2cb9
parenteca27f14b1168a8962023571b29d2ec593788b61 (diff)
netfilter: nf_queue: remove unused hook entries pointer
Its not used anywhere, so remove this. Signed-off-by: Florian Westphal <fw@strlen.de> Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
-rw-r--r--include/net/netfilter/nf_queue.h3
-rw-r--r--net/bridge/br_input.c2
-rw-r--r--net/netfilter/core.c2
-rw-r--r--net/netfilter/nf_queue.c8
4 files changed, 6 insertions, 9 deletions
diff --git a/include/net/netfilter/nf_queue.h b/include/net/netfilter/nf_queue.h
index 7239105d9d2e..3cb6dcf53a4e 100644
--- a/include/net/netfilter/nf_queue.h
+++ b/include/net/netfilter/nf_queue.h
@@ -120,6 +120,5 @@ nfqueue_hash(const struct sk_buff *skb, u16 queue, u16 queues_total, u8 family,
120} 120}
121 121
122int nf_queue(struct sk_buff *skb, struct nf_hook_state *state, 122int nf_queue(struct sk_buff *skb, struct nf_hook_state *state,
123 const struct nf_hook_entries *entries, unsigned int index, 123 unsigned int index, unsigned int verdict);
124 unsigned int verdict);
125#endif /* _NF_QUEUE_H */ 124#endif /* _NF_QUEUE_H */
diff --git a/net/bridge/br_input.c b/net/bridge/br_input.c
index 21b74e7a7b2f..512383d5e53f 100644
--- a/net/bridge/br_input.c
+++ b/net/bridge/br_input.c
@@ -234,7 +234,7 @@ static int nf_hook_bridge_pre(struct sk_buff *skb, struct sk_buff **pskb)
234 kfree_skb(skb); 234 kfree_skb(skb);
235 return RX_HANDLER_CONSUMED; 235 return RX_HANDLER_CONSUMED;
236 case NF_QUEUE: 236 case NF_QUEUE:
237 ret = nf_queue(skb, &state, e, i, verdict); 237 ret = nf_queue(skb, &state, i, verdict);
238 if (ret == 1) 238 if (ret == 1)
239 continue; 239 continue;
240 return RX_HANDLER_CONSUMED; 240 return RX_HANDLER_CONSUMED;
diff --git a/net/netfilter/core.c b/net/netfilter/core.c
index 817a9e5d16e4..5d5bdf450091 100644
--- a/net/netfilter/core.c
+++ b/net/netfilter/core.c
@@ -520,7 +520,7 @@ int nf_hook_slow(struct sk_buff *skb, struct nf_hook_state *state,
520 ret = -EPERM; 520 ret = -EPERM;
521 return ret; 521 return ret;
522 case NF_QUEUE: 522 case NF_QUEUE:
523 ret = nf_queue(skb, state, e, s, verdict); 523 ret = nf_queue(skb, state, s, verdict);
524 if (ret == 1) 524 if (ret == 1)
525 continue; 525 continue;
526 return ret; 526 return ret;
diff --git a/net/netfilter/nf_queue.c b/net/netfilter/nf_queue.c
index b5b2be55ca82..c72a5bdd123f 100644
--- a/net/netfilter/nf_queue.c
+++ b/net/netfilter/nf_queue.c
@@ -156,7 +156,6 @@ static void nf_ip6_saveroute(const struct sk_buff *skb,
156} 156}
157 157
158static int __nf_queue(struct sk_buff *skb, const struct nf_hook_state *state, 158static int __nf_queue(struct sk_buff *skb, const struct nf_hook_state *state,
159 const struct nf_hook_entries *entries,
160 unsigned int index, unsigned int queuenum) 159 unsigned int index, unsigned int queuenum)
161{ 160{
162 int status = -ENOENT; 161 int status = -ENOENT;
@@ -225,12 +224,11 @@ err:
225 224
226/* Packets leaving via this function must come back through nf_reinject(). */ 225/* Packets leaving via this function must come back through nf_reinject(). */
227int nf_queue(struct sk_buff *skb, struct nf_hook_state *state, 226int nf_queue(struct sk_buff *skb, struct nf_hook_state *state,
228 const struct nf_hook_entries *entries, unsigned int index, 227 unsigned int index, unsigned int verdict)
229 unsigned int verdict)
230{ 228{
231 int ret; 229 int ret;
232 230
233 ret = __nf_queue(skb, state, entries, index, verdict >> NF_VERDICT_QBITS); 231 ret = __nf_queue(skb, state, index, verdict >> NF_VERDICT_QBITS);
234 if (ret < 0) { 232 if (ret < 0) {
235 if (ret == -ESRCH && 233 if (ret == -ESRCH &&
236 (verdict & NF_VERDICT_FLAG_QUEUE_BYPASS)) 234 (verdict & NF_VERDICT_FLAG_QUEUE_BYPASS))
@@ -336,7 +334,7 @@ next_hook:
336 local_bh_enable(); 334 local_bh_enable();
337 break; 335 break;
338 case NF_QUEUE: 336 case NF_QUEUE:
339 err = nf_queue(skb, &entry->state, hooks, i, verdict); 337 err = nf_queue(skb, &entry->state, i, verdict);
340 if (err == 1) 338 if (err == 1)
341 goto next_hook; 339 goto next_hook;
342 break; 340 break;