diff options
author | Dave Young <dyoung@redhat.com> | 2017-12-06 04:50:10 -0500 |
---|---|---|
committer | Ingo Molnar <mingo@kernel.org> | 2017-12-06 13:32:23 -0500 |
commit | 0b02e448a2ebb46eb9be4f1bdfc87112bd420cbf (patch) | |
tree | 5ffd862e74126b2913fd5dd5e825077dc137b574 | |
parent | 89c5a2d34bda58319e3075e8e7dd727ea25a435c (diff) |
efi: Add comment to avoid future expanding of sysfs systab
/sys/firmware/efi/systab shows several different values, it breaks sysfs
one file one value design. But since there are already userspace tools
depend on it eg. kexec-tools so add code comment to alert future expanding
of this file.
Signed-off-by: Dave Young <dyoung@redhat.com>
Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: H. Peter Anvin <hpa@zytor.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Matt Fleming <matt@codeblueprint.co.uk>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: linux-efi@vger.kernel.org
Link: http://lkml.kernel.org/r/20171206095010.24170-4-ard.biesheuvel@linaro.org
Signed-off-by: Ingo Molnar <mingo@kernel.org>
-rw-r--r-- | drivers/firmware/efi/efi.c | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/drivers/firmware/efi/efi.c b/drivers/firmware/efi/efi.c index c3eefa126e3b..557a47829d03 100644 --- a/drivers/firmware/efi/efi.c +++ b/drivers/firmware/efi/efi.c | |||
@@ -109,6 +109,8 @@ struct kobject *efi_kobj; | |||
109 | /* | 109 | /* |
110 | * Let's not leave out systab information that snuck into | 110 | * Let's not leave out systab information that snuck into |
111 | * the efivars driver | 111 | * the efivars driver |
112 | * Note, do not add more fields in systab sysfs file as it breaks sysfs | ||
113 | * one value per file rule! | ||
112 | */ | 114 | */ |
113 | static ssize_t systab_show(struct kobject *kobj, | 115 | static ssize_t systab_show(struct kobject *kobj, |
114 | struct kobj_attribute *attr, char *buf) | 116 | struct kobj_attribute *attr, char *buf) |