aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorTomas Winkler <tomas.winkler@intel.com>2018-03-06 04:34:15 -0500
committerJarkko Sakkinen <jarkko.sakkinen@linux.intel.com>2018-03-23 04:18:06 -0400
commit09b17f321c15879833bbe072cf28e3f0625d3fb7 (patch)
tree335c67c9e6da089c6c3e3839cf5525816333d3fe
parent62c09e12bbf887d01397323888d5fe89a215a7e2 (diff)
tpm_crb: use __le64 annotated variable for response buffer address
use __le64 annotated variable for response buffer address as this is read in little endian format form the register. This suppresses sparse warning drivers/char/tpm/tpm_crb.c:558:18: warning: cast to restricted __le64 Signed-off-by: Tomas Winkler <tomas.winkler@intel.com> Reviewed-by: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com> Tested-by: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com> Signed-off-by: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
-rw-r--r--drivers/char/tpm/tpm_crb.c5
1 files changed, 3 insertions, 2 deletions
diff --git a/drivers/char/tpm/tpm_crb.c b/drivers/char/tpm/tpm_crb.c
index 497edd9848cd..7f78482cd157 100644
--- a/drivers/char/tpm/tpm_crb.c
+++ b/drivers/char/tpm/tpm_crb.c
@@ -471,6 +471,7 @@ static int crb_map_io(struct acpi_device *device, struct crb_priv *priv,
471 u32 pa_high, pa_low; 471 u32 pa_high, pa_low;
472 u64 cmd_pa; 472 u64 cmd_pa;
473 u32 cmd_size; 473 u32 cmd_size;
474 __le64 __rsp_pa;
474 u64 rsp_pa; 475 u64 rsp_pa;
475 u32 rsp_size; 476 u32 rsp_size;
476 int ret; 477 int ret;
@@ -536,8 +537,8 @@ static int crb_map_io(struct acpi_device *device, struct crb_priv *priv,
536 goto out; 537 goto out;
537 } 538 }
538 539
539 memcpy_fromio(&rsp_pa, &priv->regs_t->ctrl_rsp_pa, 8); 540 memcpy_fromio(&__rsp_pa, &priv->regs_t->ctrl_rsp_pa, 8);
540 rsp_pa = le64_to_cpu(rsp_pa); 541 rsp_pa = le64_to_cpu(__rsp_pa);
541 rsp_size = crb_fixup_cmd_size(dev, &io_res, rsp_pa, 542 rsp_size = crb_fixup_cmd_size(dev, &io_res, rsp_pa,
542 ioread32(&priv->regs_t->ctrl_rsp_size)); 543 ioread32(&priv->regs_t->ctrl_rsp_size));
543 544