aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorJulian Wiedmann <jwi@linux.ibm.com>2018-07-11 11:42:43 -0400
committerDavid S. Miller <davem@davemloft.net>2018-07-12 19:42:39 -0400
commit09960b3a0a474f420894d88ae2e6f09ee4c60f9c (patch)
tree89fd94ce5cd028cdfd58e390e19dfb15869abb7a
parent6d8769abe44ad073bd3d08a9dfbcbd567e96e78b (diff)
s390/qeth: clean up exported symbols
Remove some redundant EXPORTs. While at it, also move some L2-only prototypes into the proper header file. Signed-off-by: Julian Wiedmann <jwi@linux.ibm.com> Signed-off-by: David S. Miller <davem@davemloft.net>
-rw-r--r--drivers/s390/net/qeth_core.h6
-rw-r--r--drivers/s390/net/qeth_core_main.c8
-rw-r--r--drivers/s390/net/qeth_l2.h5
-rw-r--r--drivers/s390/net/qeth_l2_main.c2
4 files changed, 8 insertions, 13 deletions
diff --git a/drivers/s390/net/qeth_core.h b/drivers/s390/net/qeth_core.h
index 082c06d6380b..a932aac62d0e 100644
--- a/drivers/s390/net/qeth_core.h
+++ b/drivers/s390/net/qeth_core.h
@@ -983,7 +983,6 @@ int qeth_send_ipa_cmd(struct qeth_card *, struct qeth_cmd_buffer *,
983 void *); 983 void *);
984struct qeth_cmd_buffer *qeth_get_ipacmd_buffer(struct qeth_card *, 984struct qeth_cmd_buffer *qeth_get_ipacmd_buffer(struct qeth_card *,
985 enum qeth_ipa_cmds, enum qeth_prot_versions); 985 enum qeth_ipa_cmds, enum qeth_prot_versions);
986int qeth_query_setadapterparms(struct qeth_card *);
987struct sk_buff *qeth_core_get_next_skb(struct qeth_card *, 986struct sk_buff *qeth_core_get_next_skb(struct qeth_card *,
988 struct qeth_qdio_buffer *, struct qdio_buffer_element **, int *, 987 struct qeth_qdio_buffer *, struct qdio_buffer_element **, int *,
989 struct qeth_hdr **); 988 struct qeth_hdr **);
@@ -1009,10 +1008,6 @@ int qeth_query_switch_attributes(struct qeth_card *card,
1009int qeth_send_control_data(struct qeth_card *, int, struct qeth_cmd_buffer *, 1008int qeth_send_control_data(struct qeth_card *, int, struct qeth_cmd_buffer *,
1010 int (*reply_cb)(struct qeth_card *, struct qeth_reply*, unsigned long), 1009 int (*reply_cb)(struct qeth_card *, struct qeth_reply*, unsigned long),
1011 void *reply_param); 1010 void *reply_param);
1012int qeth_bridgeport_query_ports(struct qeth_card *card,
1013 enum qeth_sbp_roles *role, enum qeth_sbp_states *state);
1014int qeth_bridgeport_setrole(struct qeth_card *card, enum qeth_sbp_roles role);
1015int qeth_bridgeport_an_set(struct qeth_card *card, int enable);
1016int qeth_get_elements_no(struct qeth_card *card, struct sk_buff *skb, 1011int qeth_get_elements_no(struct qeth_card *card, struct sk_buff *skb,
1017 int extra_elems, int data_offset); 1012 int extra_elems, int data_offset);
1018int qeth_get_elements_for_frags(struct sk_buff *); 1013int qeth_get_elements_for_frags(struct sk_buff *);
@@ -1036,7 +1031,6 @@ int qeth_set_access_ctrl_online(struct qeth_card *card, int fallback);
1036int qeth_hdr_chk_and_bounce(struct sk_buff *, struct qeth_hdr **, int); 1031int qeth_hdr_chk_and_bounce(struct sk_buff *, struct qeth_hdr **, int);
1037int qeth_configure_cq(struct qeth_card *, enum qeth_cq); 1032int qeth_configure_cq(struct qeth_card *, enum qeth_cq);
1038int qeth_hw_trap(struct qeth_card *, enum qeth_diags_trap_action); 1033int qeth_hw_trap(struct qeth_card *, enum qeth_diags_trap_action);
1039int qeth_query_ipassists(struct qeth_card *, enum qeth_prot_versions prot);
1040void qeth_trace_features(struct qeth_card *); 1034void qeth_trace_features(struct qeth_card *);
1041void qeth_close_dev(struct qeth_card *); 1035void qeth_close_dev(struct qeth_card *);
1042int qeth_send_setassparms(struct qeth_card *, struct qeth_cmd_buffer *, __u16, 1036int qeth_send_setassparms(struct qeth_card *, struct qeth_cmd_buffer *, __u16,
diff --git a/drivers/s390/net/qeth_core_main.c b/drivers/s390/net/qeth_core_main.c
index 4ba40a64907a..d80972b9bfc7 100644
--- a/drivers/s390/net/qeth_core_main.c
+++ b/drivers/s390/net/qeth_core_main.c
@@ -3054,7 +3054,7 @@ static struct qeth_cmd_buffer *qeth_get_adapter_cmd(struct qeth_card *card,
3054 return iob; 3054 return iob;
3055} 3055}
3056 3056
3057int qeth_query_setadapterparms(struct qeth_card *card) 3057static int qeth_query_setadapterparms(struct qeth_card *card)
3058{ 3058{
3059 int rc; 3059 int rc;
3060 struct qeth_cmd_buffer *iob; 3060 struct qeth_cmd_buffer *iob;
@@ -3067,7 +3067,6 @@ int qeth_query_setadapterparms(struct qeth_card *card)
3067 rc = qeth_send_ipa_cmd(card, iob, qeth_query_setadapterparms_cb, NULL); 3067 rc = qeth_send_ipa_cmd(card, iob, qeth_query_setadapterparms_cb, NULL);
3068 return rc; 3068 return rc;
3069} 3069}
3070EXPORT_SYMBOL_GPL(qeth_query_setadapterparms);
3071 3070
3072static int qeth_query_ipassists_cb(struct qeth_card *card, 3071static int qeth_query_ipassists_cb(struct qeth_card *card,
3073 struct qeth_reply *reply, unsigned long data) 3072 struct qeth_reply *reply, unsigned long data)
@@ -3107,7 +3106,8 @@ static int qeth_query_ipassists_cb(struct qeth_card *card,
3107 return 0; 3106 return 0;
3108} 3107}
3109 3108
3110int qeth_query_ipassists(struct qeth_card *card, enum qeth_prot_versions prot) 3109static int qeth_query_ipassists(struct qeth_card *card,
3110 enum qeth_prot_versions prot)
3111{ 3111{
3112 int rc; 3112 int rc;
3113 struct qeth_cmd_buffer *iob; 3113 struct qeth_cmd_buffer *iob;
@@ -3119,7 +3119,6 @@ int qeth_query_ipassists(struct qeth_card *card, enum qeth_prot_versions prot)
3119 rc = qeth_send_ipa_cmd(card, iob, qeth_query_ipassists_cb, NULL); 3119 rc = qeth_send_ipa_cmd(card, iob, qeth_query_ipassists_cb, NULL);
3120 return rc; 3120 return rc;
3121} 3121}
3122EXPORT_SYMBOL_GPL(qeth_query_ipassists);
3123 3122
3124static int qeth_query_switch_attributes_cb(struct qeth_card *card, 3123static int qeth_query_switch_attributes_cb(struct qeth_card *card,
3125 struct qeth_reply *reply, unsigned long data) 3124 struct qeth_reply *reply, unsigned long data)
@@ -3158,7 +3157,6 @@ int qeth_query_switch_attributes(struct qeth_card *card,
3158 return qeth_send_ipa_cmd(card, iob, 3157 return qeth_send_ipa_cmd(card, iob,
3159 qeth_query_switch_attributes_cb, sw_info); 3158 qeth_query_switch_attributes_cb, sw_info);
3160} 3159}
3161EXPORT_SYMBOL_GPL(qeth_query_switch_attributes);
3162 3160
3163static int qeth_query_setdiagass_cb(struct qeth_card *card, 3161static int qeth_query_setdiagass_cb(struct qeth_card *card,
3164 struct qeth_reply *reply, unsigned long data) 3162 struct qeth_reply *reply, unsigned long data)
diff --git a/drivers/s390/net/qeth_l2.h b/drivers/s390/net/qeth_l2.h
index f2130051ca11..ddc615b431a8 100644
--- a/drivers/s390/net/qeth_l2.h
+++ b/drivers/s390/net/qeth_l2.h
@@ -14,6 +14,11 @@ extern const struct attribute_group *qeth_l2_attr_groups[];
14int qeth_l2_create_device_attributes(struct device *); 14int qeth_l2_create_device_attributes(struct device *);
15void qeth_l2_remove_device_attributes(struct device *); 15void qeth_l2_remove_device_attributes(struct device *);
16void qeth_l2_setup_bridgeport_attrs(struct qeth_card *card); 16void qeth_l2_setup_bridgeport_attrs(struct qeth_card *card);
17int qeth_bridgeport_query_ports(struct qeth_card *card,
18 enum qeth_sbp_roles *role,
19 enum qeth_sbp_states *state);
20int qeth_bridgeport_setrole(struct qeth_card *card, enum qeth_sbp_roles role);
21int qeth_bridgeport_an_set(struct qeth_card *card, int enable);
17 22
18int qeth_l2_vnicc_set_state(struct qeth_card *card, u32 vnicc, bool state); 23int qeth_l2_vnicc_set_state(struct qeth_card *card, u32 vnicc, bool state);
19int qeth_l2_vnicc_get_state(struct qeth_card *card, u32 vnicc, bool *state); 24int qeth_l2_vnicc_get_state(struct qeth_card *card, u32 vnicc, bool *state);
diff --git a/drivers/s390/net/qeth_l2_main.c b/drivers/s390/net/qeth_l2_main.c
index 5910fd524872..8ac243de7a9e 100644
--- a/drivers/s390/net/qeth_l2_main.c
+++ b/drivers/s390/net/qeth_l2_main.c
@@ -1869,7 +1869,6 @@ int qeth_bridgeport_query_ports(struct qeth_card *card,
1869 return rc; 1869 return rc;
1870 return qeth_bridgeport_makerc(card, &cbctl, IPA_SBP_QUERY_BRIDGE_PORTS); 1870 return qeth_bridgeport_makerc(card, &cbctl, IPA_SBP_QUERY_BRIDGE_PORTS);
1871} 1871}
1872EXPORT_SYMBOL_GPL(qeth_bridgeport_query_ports);
1873 1872
1874static int qeth_bridgeport_set_cb(struct qeth_card *card, 1873static int qeth_bridgeport_set_cb(struct qeth_card *card,
1875 struct qeth_reply *reply, unsigned long data) 1874 struct qeth_reply *reply, unsigned long data)
@@ -2017,7 +2016,6 @@ int qeth_bridgeport_an_set(struct qeth_card *card, int enable)
2017 rc = qdio_pnso_brinfo(schid, 0, &response, NULL, NULL); 2016 rc = qdio_pnso_brinfo(schid, 0, &response, NULL, NULL);
2018 return qeth_anset_makerc(card, rc, response); 2017 return qeth_anset_makerc(card, rc, response);
2019} 2018}
2020EXPORT_SYMBOL_GPL(qeth_bridgeport_an_set);
2021 2019
2022static bool qeth_bridgeport_is_in_use(struct qeth_card *card) 2020static bool qeth_bridgeport_is_in_use(struct qeth_card *card)
2023{ 2021{