aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorThierry Reding <treding@nvidia.com>2018-12-20 12:20:00 -0500
committerJassi Brar <jaswinder.singh@linaro.org>2018-12-21 17:49:25 -0500
commit08f2f88a3bbf3cdfdf3b890159d45519e2d5bbeb (patch)
tree2a67b6340754f5a0123743240f4d24140559281b
parent83dd44a17d40ab258aede6f560d27444e7dcfba7 (diff)
mailbox: rockchip: Use device-managed registration API
Get rid of some boilerplate driver removal code by using the newly added device-managed registration API. Reviewed-by: Caesar Wang <wxt@rock-chips.com> Signed-off-by: Thierry Reding <treding@nvidia.com> Signed-off-by: Jassi Brar <jaswinder.singh@linaro.org>
-rw-r--r--drivers/mailbox/rockchip-mailbox.c15
1 files changed, 1 insertions, 14 deletions
diff --git a/drivers/mailbox/rockchip-mailbox.c b/drivers/mailbox/rockchip-mailbox.c
index d702a204f5c1..f24a77b1a0ff 100644
--- a/drivers/mailbox/rockchip-mailbox.c
+++ b/drivers/mailbox/rockchip-mailbox.c
@@ -247,28 +247,15 @@ static int rockchip_mbox_probe(struct platform_device *pdev)
247 mb->chans[i].msg = NULL; 247 mb->chans[i].msg = NULL;
248 } 248 }
249 249
250 ret = mbox_controller_register(&mb->mbox); 250 ret = devm_mbox_controller_register(&pdev->dev, &mb->mbox);
251 if (ret < 0) 251 if (ret < 0)
252 dev_err(&pdev->dev, "Failed to register mailbox: %d\n", ret); 252 dev_err(&pdev->dev, "Failed to register mailbox: %d\n", ret);
253 253
254 return ret; 254 return ret;
255} 255}
256 256
257static int rockchip_mbox_remove(struct platform_device *pdev)
258{
259 struct rockchip_mbox *mb = platform_get_drvdata(pdev);
260
261 if (!mb)
262 return -EINVAL;
263
264 mbox_controller_unregister(&mb->mbox);
265
266 return 0;
267}
268
269static struct platform_driver rockchip_mbox_driver = { 257static struct platform_driver rockchip_mbox_driver = {
270 .probe = rockchip_mbox_probe, 258 .probe = rockchip_mbox_probe,
271 .remove = rockchip_mbox_remove,
272 .driver = { 259 .driver = {
273 .name = "rockchip-mailbox", 260 .name = "rockchip-mailbox",
274 .of_match_table = of_match_ptr(rockchip_mbox_of_match), 261 .of_match_table = of_match_ptr(rockchip_mbox_of_match),