diff options
author | Martin Sperl <kernel@martin.sperl.org> | 2015-10-15 06:10:20 -0400 |
---|---|---|
committer | Mark Brown <broonie@kernel.org> | 2015-10-16 10:35:33 -0400 |
commit | 07bce09e11f5007635d7f9e6bc55679dd6ed18bd (patch) | |
tree | e5f073eb8e787acbd6d11903eaadf2bf7901434e | |
parent | 72aac02b3730fa0e2e1ccab57712a94400344f8a (diff) |
spi: bcm2835aux: change initialization order and switch to platform_get_irq
Change the initialization order of the HW so that the interrupt
is only requested after the HW is initialized
Also the use of irq_of_parse_and_map is replaced by platform_get_irq.
Signed-off-by: Martin Sperl <kernel@martin.sperl.org>
Signed-off-by: Mark Brown <broonie@kernel.org>
-rw-r--r-- | drivers/spi/spi-bcm2835aux.c | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/drivers/spi/spi-bcm2835aux.c b/drivers/spi/spi-bcm2835aux.c index 05d2d6eb7bfa..7de6f8472a81 100644 --- a/drivers/spi/spi-bcm2835aux.c +++ b/drivers/spi/spi-bcm2835aux.c | |||
@@ -429,7 +429,7 @@ static int bcm2835aux_spi_probe(struct platform_device *pdev) | |||
429 | goto out_master_put; | 429 | goto out_master_put; |
430 | } | 430 | } |
431 | 431 | ||
432 | bs->irq = irq_of_parse_and_map(pdev->dev.of_node, 0); | 432 | bs->irq = platform_get_irq(pdev, 0); |
433 | if (bs->irq <= 0) { | 433 | if (bs->irq <= 0) { |
434 | dev_err(&pdev->dev, "could not get IRQ: %d\n", bs->irq); | 434 | dev_err(&pdev->dev, "could not get IRQ: %d\n", bs->irq); |
435 | err = bs->irq ? bs->irq : -ENODEV; | 435 | err = bs->irq ? bs->irq : -ENODEV; |
@@ -451,6 +451,9 @@ static int bcm2835aux_spi_probe(struct platform_device *pdev) | |||
451 | goto out_clk_disable; | 451 | goto out_clk_disable; |
452 | } | 452 | } |
453 | 453 | ||
454 | /* reset SPI-HW block */ | ||
455 | bcm2835aux_spi_reset_hw(bs); | ||
456 | |||
454 | err = devm_request_irq(&pdev->dev, bs->irq, | 457 | err = devm_request_irq(&pdev->dev, bs->irq, |
455 | bcm2835aux_spi_interrupt, | 458 | bcm2835aux_spi_interrupt, |
456 | IRQF_SHARED, | 459 | IRQF_SHARED, |
@@ -460,9 +463,6 @@ static int bcm2835aux_spi_probe(struct platform_device *pdev) | |||
460 | goto out_clk_disable; | 463 | goto out_clk_disable; |
461 | } | 464 | } |
462 | 465 | ||
463 | /* reset SPI-HW block */ | ||
464 | bcm2835aux_spi_reset_hw(bs); | ||
465 | |||
466 | err = devm_spi_register_master(&pdev->dev, master); | 466 | err = devm_spi_register_master(&pdev->dev, master); |
467 | if (err) { | 467 | if (err) { |
468 | dev_err(&pdev->dev, "could not register SPI master: %d\n", err); | 468 | dev_err(&pdev->dev, "could not register SPI master: %d\n", err); |