aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorDamien Le Moal <damien.lemoal@wdc.com>2018-05-08 20:28:10 -0400
committerTejun Heo <tj@kernel.org>2018-05-10 14:43:20 -0400
commit07b9b6d6e1bb823e278d1afb255ad057cf53960b (patch)
treef0d007b26fc8443385f833f82f5f96a7407e4d65
parent54fb131b325c663b368b2be150f6875124df1d76 (diff)
libata: Make ata_dev_set_mode() less verbose
For a successful setting of the device transfer speed mode in ata_dev_set_mode(), do not print the message "ataX.XX: configured for xxx" if the EH context has the quiet flag set, unless the device port is being reset. This preserves the output of the message during device scan but removes it in the case of a simple device revalidation such as trigerred by enabling the NCQ I/O priority feature of the device e.g. echo 1 > /sys/block/sdxx/device/ncq_iprio_enable Signed-off-by: Damien Le Moal <damien.lemoal@wdc.com> Reviewed-by: Hannes Reinecke <hare@suse.com> Signed-off-by: Tejun Heo <tj@kernel.org>
-rw-r--r--drivers/ata/libata-core.c8
1 files changed, 5 insertions, 3 deletions
diff --git a/drivers/ata/libata-core.c b/drivers/ata/libata-core.c
index 8bc71ca61e7f..40caad1d8b43 100644
--- a/drivers/ata/libata-core.c
+++ b/drivers/ata/libata-core.c
@@ -3573,9 +3573,11 @@ static int ata_dev_set_mode(struct ata_device *dev)
3573 DPRINTK("xfer_shift=%u, xfer_mode=0x%x\n", 3573 DPRINTK("xfer_shift=%u, xfer_mode=0x%x\n",
3574 dev->xfer_shift, (int)dev->xfer_mode); 3574 dev->xfer_shift, (int)dev->xfer_mode);
3575 3575
3576 ata_dev_info(dev, "configured for %s%s\n", 3576 if (!(ehc->i.flags & ATA_EHI_QUIET) ||
3577 ata_mode_string(ata_xfer_mode2mask(dev->xfer_mode)), 3577 ehc->i.flags & ATA_EHI_DID_HARDRESET)
3578 dev_err_whine); 3578 ata_dev_info(dev, "configured for %s%s\n",
3579 ata_mode_string(ata_xfer_mode2mask(dev->xfer_mode)),
3580 dev_err_whine);
3579 3581
3580 return 0; 3582 return 0;
3581 3583