diff options
author | Chunming Zhou <david1.zhou@amd.com> | 2018-03-29 22:23:48 -0400 |
---|---|---|
committer | Alex Deucher <alexander.deucher@amd.com> | 2018-04-03 14:08:44 -0400 |
commit | 073997ccd9dd8eb8015f5371ff0ea85a48814bb4 (patch) | |
tree | ef95f43d251aa13783aafe5d2d06c8584e50c5d1 | |
parent | 46bce67f62e7daa00ad908c4c17e9750df2acf52 (diff) |
Revert "drm/amdgpu: Don't change preferred domian when fallback GTT v5"
This reverts commit bbaf1871ea1d7b7021e350a3e8bb1ec8408c2030.
Felix reports this commit causes regression.
Signed-off-by: Chunming Zhou <david1.zhou@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
-rw-r--r-- | drivers/gpu/drm/amd/amdgpu/amdgpu_gem.c | 16 | ||||
-rw-r--r-- | drivers/gpu/drm/amd/amdgpu/amdgpu_object.c | 18 |
2 files changed, 17 insertions, 17 deletions
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_gem.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_gem.c index 28c2706e48d7..46b9ea4e6103 100644 --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_gem.c +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_gem.c | |||
@@ -56,11 +56,23 @@ int amdgpu_gem_object_create(struct amdgpu_device *adev, unsigned long size, | |||
56 | alignment = PAGE_SIZE; | 56 | alignment = PAGE_SIZE; |
57 | } | 57 | } |
58 | 58 | ||
59 | retry: | ||
59 | r = amdgpu_bo_create(adev, size, alignment, initial_domain, | 60 | r = amdgpu_bo_create(adev, size, alignment, initial_domain, |
60 | flags, type, resv, &bo); | 61 | flags, type, resv, &bo); |
61 | if (r) { | 62 | if (r) { |
62 | DRM_DEBUG("Failed to allocate GEM object (%ld, %d, %u, %d)\n", | 63 | if (r != -ERESTARTSYS) { |
63 | size, initial_domain, alignment, r); | 64 | if (flags & AMDGPU_GEM_CREATE_CPU_ACCESS_REQUIRED) { |
65 | flags &= ~AMDGPU_GEM_CREATE_CPU_ACCESS_REQUIRED; | ||
66 | goto retry; | ||
67 | } | ||
68 | |||
69 | if (initial_domain == AMDGPU_GEM_DOMAIN_VRAM) { | ||
70 | initial_domain |= AMDGPU_GEM_DOMAIN_GTT; | ||
71 | goto retry; | ||
72 | } | ||
73 | DRM_DEBUG("Failed to allocate GEM object (%ld, %d, %u, %d)\n", | ||
74 | size, initial_domain, alignment, r); | ||
75 | } | ||
64 | return r; | 76 | return r; |
65 | } | 77 | } |
66 | *obj = &bo->gem_base; | 78 | *obj = &bo->gem_base; |
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_object.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_object.c index 5ad985c40d49..6d08cde8443c 100644 --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_object.c +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_object.c | |||
@@ -356,7 +356,6 @@ static int amdgpu_bo_do_create(struct amdgpu_device *adev, unsigned long size, | |||
356 | struct amdgpu_bo *bo; | 356 | struct amdgpu_bo *bo; |
357 | unsigned long page_align; | 357 | unsigned long page_align; |
358 | size_t acc_size; | 358 | size_t acc_size; |
359 | u32 domains; | ||
360 | int r; | 359 | int r; |
361 | 360 | ||
362 | page_align = roundup(byte_align, PAGE_SIZE) >> PAGE_SHIFT; | 361 | page_align = roundup(byte_align, PAGE_SIZE) >> PAGE_SHIFT; |
@@ -418,23 +417,12 @@ static int amdgpu_bo_do_create(struct amdgpu_device *adev, unsigned long size, | |||
418 | #endif | 417 | #endif |
419 | 418 | ||
420 | bo->tbo.bdev = &adev->mman.bdev; | 419 | bo->tbo.bdev = &adev->mman.bdev; |
421 | domains = bo->preferred_domains; | 420 | amdgpu_ttm_placement_from_domain(bo, domain); |
422 | retry: | 421 | |
423 | amdgpu_ttm_placement_from_domain(bo, domains); | ||
424 | r = ttm_bo_init_reserved(&adev->mman.bdev, &bo->tbo, size, type, | 422 | r = ttm_bo_init_reserved(&adev->mman.bdev, &bo->tbo, size, type, |
425 | &bo->placement, page_align, &ctx, acc_size, | 423 | &bo->placement, page_align, &ctx, acc_size, |
426 | NULL, resv, &amdgpu_ttm_bo_destroy); | 424 | NULL, resv, &amdgpu_ttm_bo_destroy); |
427 | 425 | if (unlikely(r != 0)) | |
428 | if (unlikely(r && r != -ERESTARTSYS)) { | ||
429 | if (bo->flags & AMDGPU_GEM_CREATE_CPU_ACCESS_REQUIRED) { | ||
430 | bo->flags &= ~AMDGPU_GEM_CREATE_CPU_ACCESS_REQUIRED; | ||
431 | goto retry; | ||
432 | } else if (domains != bo->allowed_domains) { | ||
433 | domains = bo->allowed_domains; | ||
434 | goto retry; | ||
435 | } | ||
436 | } | ||
437 | if (unlikely(r)) | ||
438 | return r; | 426 | return r; |
439 | 427 | ||
440 | if (adev->gmc.visible_vram_size < adev->gmc.real_vram_size && | 428 | if (adev->gmc.visible_vram_size < adev->gmc.real_vram_size && |