diff options
author | Roi Dayan <roid@mellanox.com> | 2018-08-19 01:56:09 -0400 |
---|---|---|
committer | Saeed Mahameed <saeedm@mellanox.com> | 2018-09-05 20:08:33 -0400 |
commit | 071304772fc747d5df13c51f1cf48a4b922a5e0d (patch) | |
tree | 085912ca0e9a14f7025b22b7a57fbcf1a8e12ad4 | |
parent | c88a026e01219488e745f4f0267fd76c2bb68421 (diff) |
net/mlx5: Fix not releasing read lock when adding flow rules
If building match list fg fails and we never jumped to
search_again_locked label then the function returned without
unlocking the read lock.
Fixes: bd71b08ec2ee ("net/mlx5: Support multiple updates of steering rules in parallel")
Signed-off-by: Roi Dayan <roid@mellanox.com>
Reviewed-by: Maor Gottlieb <maorg@mellanox.com>
Signed-off-by: Saeed Mahameed <saeedm@mellanox.com>
-rw-r--r-- | drivers/net/ethernet/mellanox/mlx5/core/fs_core.c | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/drivers/net/ethernet/mellanox/mlx5/core/fs_core.c b/drivers/net/ethernet/mellanox/mlx5/core/fs_core.c index f418541af7cf..384b560f2a93 100644 --- a/drivers/net/ethernet/mellanox/mlx5/core/fs_core.c +++ b/drivers/net/ethernet/mellanox/mlx5/core/fs_core.c | |||
@@ -1726,6 +1726,8 @@ search_again_locked: | |||
1726 | if (err) { | 1726 | if (err) { |
1727 | if (take_write) | 1727 | if (take_write) |
1728 | up_write_ref_node(&ft->node); | 1728 | up_write_ref_node(&ft->node); |
1729 | else | ||
1730 | up_read_ref_node(&ft->node); | ||
1729 | return ERR_PTR(err); | 1731 | return ERR_PTR(err); |
1730 | } | 1732 | } |
1731 | 1733 | ||