diff options
author | Christophe JAILLET <christophe.jaillet@wanadoo.fr> | 2017-01-31 03:47:30 -0500 |
---|---|---|
committer | Dmitry Torokhov <dmitry.torokhov@gmail.com> | 2017-01-31 03:51:06 -0500 |
commit | 05e0be7c900797e9164976a6014d534ce3035909 (patch) | |
tree | 6064ddf732b21c686c958cb9da73f6eae6de5a27 | |
parent | 3f5c34c6d4688b3b7e1dbc7bbc68a2f03a0d6b0c (diff) |
Input: synaptics-rmi4 - fix reversed conditions in enable/disable_irq_wake
These tests are reversed. A warning should be displayed if an error is
returned, not on success.
Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Reviewed-by: Benjamin Tissoires <benjamin.tissoires@redhat.com>
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
-rw-r--r-- | drivers/input/rmi4/rmi_driver.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/input/rmi4/rmi_driver.c b/drivers/input/rmi4/rmi_driver.c index 11447ab1055c..bf5c36e229ba 100644 --- a/drivers/input/rmi4/rmi_driver.c +++ b/drivers/input/rmi4/rmi_driver.c | |||
@@ -901,7 +901,7 @@ void rmi_enable_irq(struct rmi_device *rmi_dev, bool clear_wake) | |||
901 | data->enabled = true; | 901 | data->enabled = true; |
902 | if (clear_wake && device_may_wakeup(rmi_dev->xport->dev)) { | 902 | if (clear_wake && device_may_wakeup(rmi_dev->xport->dev)) { |
903 | retval = disable_irq_wake(irq); | 903 | retval = disable_irq_wake(irq); |
904 | if (!retval) | 904 | if (retval) |
905 | dev_warn(&rmi_dev->dev, | 905 | dev_warn(&rmi_dev->dev, |
906 | "Failed to disable irq for wake: %d\n", | 906 | "Failed to disable irq for wake: %d\n", |
907 | retval); | 907 | retval); |
@@ -936,7 +936,7 @@ void rmi_disable_irq(struct rmi_device *rmi_dev, bool enable_wake) | |||
936 | disable_irq(irq); | 936 | disable_irq(irq); |
937 | if (enable_wake && device_may_wakeup(rmi_dev->xport->dev)) { | 937 | if (enable_wake && device_may_wakeup(rmi_dev->xport->dev)) { |
938 | retval = enable_irq_wake(irq); | 938 | retval = enable_irq_wake(irq); |
939 | if (!retval) | 939 | if (retval) |
940 | dev_warn(&rmi_dev->dev, | 940 | dev_warn(&rmi_dev->dev, |
941 | "Failed to enable irq for wake: %d\n", | 941 | "Failed to enable irq for wake: %d\n", |
942 | retval); | 942 | retval); |