diff options
author | Milo Kim <woogyom.kim@gmail.com> | 2016-08-24 09:07:16 -0400 |
---|---|---|
committer | Krzysztof Kozlowski <krzk@kernel.org> | 2016-08-24 15:09:24 -0400 |
commit | 05b01dd936b46f2c3cfbb10bc89c0ec79c745e5d (patch) | |
tree | 9420b5613fa1062098bddc6c89d6636ad5e27cff | |
parent | 5a5232d1932b5d1ca472037bc8b38c21fa0cb6f8 (diff) |
ARM: dts: exynos: Use 'hpd-gpios' instead of 'hpd-gpio'
This patch enables getting a HPD GPIO descriptor quicker.
The exynos-hdmi driver uses "hpd" for HDMI hot plug detection.
static int hdmi_resources_init(struct hdmi_context *hdata)
{
...
hdata->hpd_gpio = devm_gpiod_get(dev, "hpd", GPIOD_IN);
...
}
This calls 'of_find_gpio()' and it generates the GPIO consumer ID by referring
GPIO suffix. So 'hpd-gpios' is preferred on getting a GPIO descriptor.
However, if the device tree uses 'hpd-gpio', then the exynos-hdmi driver
always retries to get a GPIO descriptor because the first GPIO suffix is not
'gpio' but 'gpios'. So you always see the debug message below.
of_get_named_gpiod_flags: can't parse 'hpd-gpios' property of node '/soc/hdmi@14530000[0]'
Use the preferred property, 'hpd-gpios' instead of 'hpd-gpio'.
Acked-by: Rob Herring <robh@kernel.org>
Reviewed-by: Andrzej Hajda <a.hajda@samsung.com>
Cc: devicetree@vger.kernel.org
Cc: linux-arm-kernel@lists.infradead.org
Cc: linux-samsung-soc@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
Signed-off-by: Milo Kim <woogyom.kim@gmail.com>
Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
-rw-r--r-- | Documentation/devicetree/bindings/display/exynos/exynos_hdmi.txt | 4 | ||||
-rw-r--r-- | arch/arm/boot/dts/exynos4210-universal_c210.dts | 2 | ||||
-rw-r--r-- | arch/arm/boot/dts/exynos4412-odroid-common.dtsi | 2 | ||||
-rw-r--r-- | arch/arm/boot/dts/exynos5250-arndale.dts | 2 | ||||
-rw-r--r-- | arch/arm/boot/dts/exynos5250-smdk5250.dts | 2 | ||||
-rw-r--r-- | arch/arm/boot/dts/exynos5250-snow-common.dtsi | 2 | ||||
-rw-r--r-- | arch/arm/boot/dts/exynos5250-spring.dts | 2 | ||||
-rw-r--r-- | arch/arm/boot/dts/exynos5420-peach-pit.dts | 2 | ||||
-rw-r--r-- | arch/arm/boot/dts/exynos5420-smdk5420.dts | 2 | ||||
-rw-r--r-- | arch/arm/boot/dts/exynos5422-odroidxu3-common.dtsi | 2 | ||||
-rw-r--r-- | arch/arm/boot/dts/exynos5800-peach-pi.dts | 2 |
11 files changed, 12 insertions, 12 deletions
diff --git a/Documentation/devicetree/bindings/display/exynos/exynos_hdmi.txt b/Documentation/devicetree/bindings/display/exynos/exynos_hdmi.txt index a2ec4c1c9382..6394ea9e3b9e 100644 --- a/Documentation/devicetree/bindings/display/exynos/exynos_hdmi.txt +++ b/Documentation/devicetree/bindings/display/exynos/exynos_hdmi.txt | |||
@@ -9,7 +9,7 @@ Required properties: | |||
9 | - reg: physical base address of the hdmi and length of memory mapped | 9 | - reg: physical base address of the hdmi and length of memory mapped |
10 | region. | 10 | region. |
11 | - interrupts: interrupt number to the cpu. | 11 | - interrupts: interrupt number to the cpu. |
12 | - hpd-gpio: following information about the hotplug gpio pin. | 12 | - hpd-gpios: following information about the hotplug gpio pin. |
13 | a) phandle of the gpio controller node. | 13 | a) phandle of the gpio controller node. |
14 | b) pin number within the gpio controller. | 14 | b) pin number within the gpio controller. |
15 | c) optional flags and pull up/down. | 15 | c) optional flags and pull up/down. |
@@ -56,7 +56,7 @@ Example: | |||
56 | compatible = "samsung,exynos4212-hdmi"; | 56 | compatible = "samsung,exynos4212-hdmi"; |
57 | reg = <0x14530000 0x100000>; | 57 | reg = <0x14530000 0x100000>; |
58 | interrupts = <0 95 0>; | 58 | interrupts = <0 95 0>; |
59 | hpd-gpio = <&gpx3 7 1>; | 59 | hpd-gpios = <&gpx3 7 1>; |
60 | ddc = <&hdmi_ddc_node>; | 60 | ddc = <&hdmi_ddc_node>; |
61 | phy = <&hdmi_phy_node>; | 61 | phy = <&hdmi_phy_node>; |
62 | samsung,syscon-phandle = <&pmu_system_controller>; | 62 | samsung,syscon-phandle = <&pmu_system_controller>; |
diff --git a/arch/arm/boot/dts/exynos4210-universal_c210.dts b/arch/arm/boot/dts/exynos4210-universal_c210.dts index 9a75e3effbc9..cf95202fa310 100644 --- a/arch/arm/boot/dts/exynos4210-universal_c210.dts +++ b/arch/arm/boot/dts/exynos4210-universal_c210.dts | |||
@@ -269,7 +269,7 @@ | |||
269 | }; | 269 | }; |
270 | 270 | ||
271 | &hdmi { | 271 | &hdmi { |
272 | hpd-gpio = <&gpx3 7 GPIO_ACTIVE_HIGH>; | 272 | hpd-gpios = <&gpx3 7 GPIO_ACTIVE_HIGH>; |
273 | pinctrl-names = "default"; | 273 | pinctrl-names = "default"; |
274 | pinctrl-0 = <&hdmi_hpd>; | 274 | pinctrl-0 = <&hdmi_hpd>; |
275 | hdmi-en-supply = <&hdmi_en>; | 275 | hdmi-en-supply = <&hdmi_en>; |
diff --git a/arch/arm/boot/dts/exynos4412-odroid-common.dtsi b/arch/arm/boot/dts/exynos4412-odroid-common.dtsi index 58ad48e7b8f7..be644fe6a0fd 100644 --- a/arch/arm/boot/dts/exynos4412-odroid-common.dtsi +++ b/arch/arm/boot/dts/exynos4412-odroid-common.dtsi | |||
@@ -227,7 +227,7 @@ | |||
227 | }; | 227 | }; |
228 | 228 | ||
229 | &hdmi { | 229 | &hdmi { |
230 | hpd-gpio = <&gpx3 7 GPIO_ACTIVE_HIGH>; | 230 | hpd-gpios = <&gpx3 7 GPIO_ACTIVE_HIGH>; |
231 | pinctrl-names = "default"; | 231 | pinctrl-names = "default"; |
232 | pinctrl-0 = <&hdmi_hpd>; | 232 | pinctrl-0 = <&hdmi_hpd>; |
233 | vdd-supply = <&ldo8_reg>; | 233 | vdd-supply = <&ldo8_reg>; |
diff --git a/arch/arm/boot/dts/exynos5250-arndale.dts b/arch/arm/boot/dts/exynos5250-arndale.dts index ea70603f660d..3d981f32874d 100644 --- a/arch/arm/boot/dts/exynos5250-arndale.dts +++ b/arch/arm/boot/dts/exynos5250-arndale.dts | |||
@@ -152,7 +152,7 @@ | |||
152 | }; | 152 | }; |
153 | 153 | ||
154 | &hdmi { | 154 | &hdmi { |
155 | hpd-gpio = <&gpx3 7 GPIO_ACTIVE_LOW>; | 155 | hpd-gpios = <&gpx3 7 GPIO_ACTIVE_LOW>; |
156 | vdd_osc-supply = <&ldo10_reg>; | 156 | vdd_osc-supply = <&ldo10_reg>; |
157 | vdd_pll-supply = <&ldo8_reg>; | 157 | vdd_pll-supply = <&ldo8_reg>; |
158 | vdd-supply = <&ldo8_reg>; | 158 | vdd-supply = <&ldo8_reg>; |
diff --git a/arch/arm/boot/dts/exynos5250-smdk5250.dts b/arch/arm/boot/dts/exynos5250-smdk5250.dts index 381af134c4c8..7f27263728a1 100644 --- a/arch/arm/boot/dts/exynos5250-smdk5250.dts +++ b/arch/arm/boot/dts/exynos5250-smdk5250.dts | |||
@@ -116,7 +116,7 @@ | |||
116 | }; | 116 | }; |
117 | 117 | ||
118 | &hdmi { | 118 | &hdmi { |
119 | hpd-gpio = <&gpx3 7 GPIO_ACTIVE_HIGH>; | 119 | hpd-gpios = <&gpx3 7 GPIO_ACTIVE_HIGH>; |
120 | }; | 120 | }; |
121 | 121 | ||
122 | &i2c_0 { | 122 | &i2c_0 { |
diff --git a/arch/arm/boot/dts/exynos5250-snow-common.dtsi b/arch/arm/boot/dts/exynos5250-snow-common.dtsi index fadbea744e1a..1055d25c0ccc 100644 --- a/arch/arm/boot/dts/exynos5250-snow-common.dtsi +++ b/arch/arm/boot/dts/exynos5250-snow-common.dtsi | |||
@@ -260,7 +260,7 @@ | |||
260 | }; | 260 | }; |
261 | 261 | ||
262 | &hdmi { | 262 | &hdmi { |
263 | hpd-gpio = <&gpx3 7 GPIO_ACTIVE_HIGH>; | 263 | hpd-gpios = <&gpx3 7 GPIO_ACTIVE_HIGH>; |
264 | pinctrl-names = "default"; | 264 | pinctrl-names = "default"; |
265 | pinctrl-0 = <&hdmi_hpd_irq>; | 265 | pinctrl-0 = <&hdmi_hpd_irq>; |
266 | phy = <&hdmiphy>; | 266 | phy = <&hdmiphy>; |
diff --git a/arch/arm/boot/dts/exynos5250-spring.dts b/arch/arm/boot/dts/exynos5250-spring.dts index 44f4292bfef6..1d52a79b2f18 100644 --- a/arch/arm/boot/dts/exynos5250-spring.dts +++ b/arch/arm/boot/dts/exynos5250-spring.dts | |||
@@ -91,7 +91,7 @@ | |||
91 | }; | 91 | }; |
92 | 92 | ||
93 | &hdmi { | 93 | &hdmi { |
94 | hpd-gpio = <&gpx3 7 GPIO_ACTIVE_HIGH>; | 94 | hpd-gpios = <&gpx3 7 GPIO_ACTIVE_HIGH>; |
95 | pinctrl-names = "default"; | 95 | pinctrl-names = "default"; |
96 | pinctrl-0 = <&hdmi_hpd_irq>; | 96 | pinctrl-0 = <&hdmi_hpd_irq>; |
97 | phy = <&hdmiphy>; | 97 | phy = <&hdmiphy>; |
diff --git a/arch/arm/boot/dts/exynos5420-peach-pit.dts b/arch/arm/boot/dts/exynos5420-peach-pit.dts index fe4e0915c0c6..f6f256fd9b5e 100644 --- a/arch/arm/boot/dts/exynos5420-peach-pit.dts +++ b/arch/arm/boot/dts/exynos5420-peach-pit.dts | |||
@@ -179,7 +179,7 @@ | |||
179 | 179 | ||
180 | &hdmi { | 180 | &hdmi { |
181 | status = "okay"; | 181 | status = "okay"; |
182 | hpd-gpio = <&gpx3 7 GPIO_ACTIVE_HIGH>; | 182 | hpd-gpios = <&gpx3 7 GPIO_ACTIVE_HIGH>; |
183 | pinctrl-names = "default"; | 183 | pinctrl-names = "default"; |
184 | pinctrl-0 = <&hdmi_hpd_irq>; | 184 | pinctrl-0 = <&hdmi_hpd_irq>; |
185 | ddc = <&i2c_2>; | 185 | ddc = <&i2c_2>; |
diff --git a/arch/arm/boot/dts/exynos5420-smdk5420.dts b/arch/arm/boot/dts/exynos5420-smdk5420.dts index ed8f3426911b..29546465d3da 100644 --- a/arch/arm/boot/dts/exynos5420-smdk5420.dts +++ b/arch/arm/boot/dts/exynos5420-smdk5420.dts | |||
@@ -130,7 +130,7 @@ | |||
130 | 130 | ||
131 | &hdmi { | 131 | &hdmi { |
132 | status = "okay"; | 132 | status = "okay"; |
133 | hpd-gpio = <&gpx3 7 GPIO_ACTIVE_HIGH>; | 133 | hpd-gpios = <&gpx3 7 GPIO_ACTIVE_HIGH>; |
134 | pinctrl-names = "default"; | 134 | pinctrl-names = "default"; |
135 | pinctrl-0 = <&hdmi_hpd_irq>; | 135 | pinctrl-0 = <&hdmi_hpd_irq>; |
136 | }; | 136 | }; |
diff --git a/arch/arm/boot/dts/exynos5422-odroidxu3-common.dtsi b/arch/arm/boot/dts/exynos5422-odroidxu3-common.dtsi index d04490d40b07..7bb8a370072a 100644 --- a/arch/arm/boot/dts/exynos5422-odroidxu3-common.dtsi +++ b/arch/arm/boot/dts/exynos5422-odroidxu3-common.dtsi | |||
@@ -250,7 +250,7 @@ | |||
250 | 250 | ||
251 | &hdmi { | 251 | &hdmi { |
252 | status = "okay"; | 252 | status = "okay"; |
253 | hpd-gpio = <&gpx3 7 GPIO_ACTIVE_HIGH>; | 253 | hpd-gpios = <&gpx3 7 GPIO_ACTIVE_HIGH>; |
254 | pinctrl-names = "default"; | 254 | pinctrl-names = "default"; |
255 | pinctrl-0 = <&hdmi_hpd_irq>; | 255 | pinctrl-0 = <&hdmi_hpd_irq>; |
256 | 256 | ||
diff --git a/arch/arm/boot/dts/exynos5800-peach-pi.dts b/arch/arm/boot/dts/exynos5800-peach-pi.dts index 5ec71e2400fd..51a8bca4691c 100644 --- a/arch/arm/boot/dts/exynos5800-peach-pi.dts +++ b/arch/arm/boot/dts/exynos5800-peach-pi.dts | |||
@@ -179,7 +179,7 @@ | |||
179 | 179 | ||
180 | &hdmi { | 180 | &hdmi { |
181 | status = "okay"; | 181 | status = "okay"; |
182 | hpd-gpio = <&gpx3 7 GPIO_ACTIVE_HIGH>; | 182 | hpd-gpios = <&gpx3 7 GPIO_ACTIVE_HIGH>; |
183 | pinctrl-names = "default"; | 183 | pinctrl-names = "default"; |
184 | pinctrl-0 = <&hdmi_hpd_irq>; | 184 | pinctrl-0 = <&hdmi_hpd_irq>; |
185 | ddc = <&i2c_2>; | 185 | ddc = <&i2c_2>; |