aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorNeilBrown <neilb@suse.com>2017-08-15 22:47:27 -0400
committerTrond Myklebust <trond.myklebust@primarydata.com>2017-09-06 12:32:37 -0400
commit03c6f7d64ac9c0a37cca91392ac4be8993a8f53d (patch)
tree32e056cb779ff859350442f1215cd0d0bc1b78b7
parent779eafab06036fe1e06dea9bbd97cc4b12f0138f (diff)
NFS: remove jiffies field from access cache
This field hasn't been used since commit 57b691819ee2 ("NFS: Cache access checks more aggressively"). Signed-off-by: NeilBrown <neilb@suse.com> Signed-off-by: Trond Myklebust <trond.myklebust@primarydata.com>
-rw-r--r--fs/nfs/dir.c4
-rw-r--r--fs/nfs/nfs4proc.c1
-rw-r--r--include/linux/nfs_fs.h1
3 files changed, 0 insertions, 6 deletions
diff --git a/fs/nfs/dir.c b/fs/nfs/dir.c
index 3522b1249019..5ceaeb1f6fb6 100644
--- a/fs/nfs/dir.c
+++ b/fs/nfs/dir.c
@@ -2260,7 +2260,6 @@ static int nfs_access_get_cached(struct inode *inode, struct rpc_cred *cred, str
2260 spin_lock(&inode->i_lock); 2260 spin_lock(&inode->i_lock);
2261 retry = false; 2261 retry = false;
2262 } 2262 }
2263 res->jiffies = cache->jiffies;
2264 res->cred = cache->cred; 2263 res->cred = cache->cred;
2265 res->mask = cache->mask; 2264 res->mask = cache->mask;
2266 list_move_tail(&cache->lru, &nfsi->access_cache_entry_lru); 2265 list_move_tail(&cache->lru, &nfsi->access_cache_entry_lru);
@@ -2296,7 +2295,6 @@ static int nfs_access_get_cached_rcu(struct inode *inode, struct rpc_cred *cred,
2296 goto out; 2295 goto out;
2297 if (nfs_check_cache_invalid(inode, NFS_INO_INVALID_ACCESS)) 2296 if (nfs_check_cache_invalid(inode, NFS_INO_INVALID_ACCESS))
2298 goto out; 2297 goto out;
2299 res->jiffies = cache->jiffies;
2300 res->cred = cache->cred; 2298 res->cred = cache->cred;
2301 res->mask = cache->mask; 2299 res->mask = cache->mask;
2302 err = 0; 2300 err = 0;
@@ -2344,7 +2342,6 @@ void nfs_access_add_cache(struct inode *inode, struct nfs_access_entry *set)
2344 if (cache == NULL) 2342 if (cache == NULL)
2345 return; 2343 return;
2346 RB_CLEAR_NODE(&cache->rb_node); 2344 RB_CLEAR_NODE(&cache->rb_node);
2347 cache->jiffies = set->jiffies;
2348 cache->cred = get_rpccred(set->cred); 2345 cache->cred = get_rpccred(set->cred);
2349 cache->mask = set->mask; 2346 cache->mask = set->mask;
2350 2347
@@ -2432,7 +2429,6 @@ static int nfs_do_access(struct inode *inode, struct rpc_cred *cred, int mask)
2432 cache.mask = NFS_MAY_LOOKUP | NFS_MAY_EXECUTE 2429 cache.mask = NFS_MAY_LOOKUP | NFS_MAY_EXECUTE
2433 | NFS_MAY_WRITE | NFS_MAY_READ; 2430 | NFS_MAY_WRITE | NFS_MAY_READ;
2434 cache.cred = cred; 2431 cache.cred = cred;
2435 cache.jiffies = jiffies;
2436 status = NFS_PROTO(inode)->access(inode, &cache); 2432 status = NFS_PROTO(inode)->access(inode, &cache);
2437 if (status != 0) { 2433 if (status != 0) {
2438 if (status == -ESTALE) { 2434 if (status == -ESTALE) {
diff --git a/fs/nfs/nfs4proc.c b/fs/nfs/nfs4proc.c
index 08cc97488904..6c61e2b99635 100644
--- a/fs/nfs/nfs4proc.c
+++ b/fs/nfs/nfs4proc.c
@@ -2285,7 +2285,6 @@ static int nfs4_opendata_access(struct rpc_cred *cred,
2285 mask = NFS4_ACCESS_READ; 2285 mask = NFS4_ACCESS_READ;
2286 2286
2287 cache.cred = cred; 2287 cache.cred = cred;
2288 cache.jiffies = jiffies;
2289 nfs_access_set_mask(&cache, opendata->o_res.access_result); 2288 nfs_access_set_mask(&cache, opendata->o_res.access_result);
2290 nfs_access_add_cache(state->inode, &cache); 2289 nfs_access_add_cache(state->inode, &cache);
2291 2290
diff --git a/include/linux/nfs_fs.h b/include/linux/nfs_fs.h
index 238fdc4c46df..a0282ceaa48b 100644
--- a/include/linux/nfs_fs.h
+++ b/include/linux/nfs_fs.h
@@ -49,7 +49,6 @@
49struct nfs_access_entry { 49struct nfs_access_entry {
50 struct rb_node rb_node; 50 struct rb_node rb_node;
51 struct list_head lru; 51 struct list_head lru;
52 unsigned long jiffies;
53 struct rpc_cred * cred; 52 struct rpc_cred * cred;
54 __u32 mask; 53 __u32 mask;
55 struct rcu_head rcu_head; 54 struct rcu_head rcu_head;