aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorSowmini Varadhan <sowmini.varadhan@oracle.com>2016-06-13 12:44:35 -0400
committerDavid S. Miller <davem@davemloft.net>2016-06-15 02:50:43 -0400
commit01ff34ed44a48ed0ae875291b4b6b7dc9ebeea69 (patch)
treebb95e7c1e64034d74643cf7b71b5566a083cc55f
parent1f9ecd7eacfd9ee52a114b87292bfe885aafdb1f (diff)
RDS: Extract rds_conn_path from i_conn_path in rds_send_drop_to() for MP-capable transports
Explicitly set up rds_conn_path, either from i_conn_path (for MP capable transpots) or as c_path[0], and use this in rds_send_drop_to() Signed-off-by: Sowmini Varadhan <sowmini.varadhan@oracle.com> Signed-off-by: David S. Miller <davem@davemloft.net>
-rw-r--r--net/rds/send.c11
1 files changed, 8 insertions, 3 deletions
diff --git a/net/rds/send.c b/net/rds/send.c
index 966311d135af..9c34fd204639 100644
--- a/net/rds/send.c
+++ b/net/rds/send.c
@@ -710,6 +710,7 @@ void rds_send_drop_to(struct rds_sock *rs, struct sockaddr_in *dest)
710{ 710{
711 struct rds_message *rm, *tmp; 711 struct rds_message *rm, *tmp;
712 struct rds_connection *conn; 712 struct rds_connection *conn;
713 struct rds_conn_path *cp;
713 unsigned long flags; 714 unsigned long flags;
714 LIST_HEAD(list); 715 LIST_HEAD(list);
715 716
@@ -738,22 +739,26 @@ void rds_send_drop_to(struct rds_sock *rs, struct sockaddr_in *dest)
738 list_for_each_entry(rm, &list, m_sock_item) { 739 list_for_each_entry(rm, &list, m_sock_item) {
739 740
740 conn = rm->m_inc.i_conn; 741 conn = rm->m_inc.i_conn;
742 if (conn->c_trans->t_mp_capable)
743 cp = rm->m_inc.i_conn_path;
744 else
745 cp = &conn->c_path[0];
741 746
742 spin_lock_irqsave(&conn->c_lock, flags); 747 spin_lock_irqsave(&cp->cp_lock, flags);
743 /* 748 /*
744 * Maybe someone else beat us to removing rm from the conn. 749 * Maybe someone else beat us to removing rm from the conn.
745 * If we race with their flag update we'll get the lock and 750 * If we race with their flag update we'll get the lock and
746 * then really see that the flag has been cleared. 751 * then really see that the flag has been cleared.
747 */ 752 */
748 if (!test_and_clear_bit(RDS_MSG_ON_CONN, &rm->m_flags)) { 753 if (!test_and_clear_bit(RDS_MSG_ON_CONN, &rm->m_flags)) {
749 spin_unlock_irqrestore(&conn->c_lock, flags); 754 spin_unlock_irqrestore(&cp->cp_lock, flags);
750 spin_lock_irqsave(&rm->m_rs_lock, flags); 755 spin_lock_irqsave(&rm->m_rs_lock, flags);
751 rm->m_rs = NULL; 756 rm->m_rs = NULL;
752 spin_unlock_irqrestore(&rm->m_rs_lock, flags); 757 spin_unlock_irqrestore(&rm->m_rs_lock, flags);
753 continue; 758 continue;
754 } 759 }
755 list_del_init(&rm->m_conn_item); 760 list_del_init(&rm->m_conn_item);
756 spin_unlock_irqrestore(&conn->c_lock, flags); 761 spin_unlock_irqrestore(&cp->cp_lock, flags);
757 762
758 /* 763 /*
759 * Couldn't grab m_rs_lock in top loop (lock ordering), 764 * Couldn't grab m_rs_lock in top loop (lock ordering),