aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorMarkus Elfring <elfring@users.sourceforge.net>2017-11-24 04:40:43 -0500
committerMark Brown <broonie@kernel.org>2017-11-27 07:55:58 -0500
commit017b9b35cb107c0aeaad2ad770460c49e3f71395 (patch)
tree9b82bb95e4fbbc614e72221a4fbabe9f715b497e
parentcce7c0ac44832225ca86afff308cf6a5fb19cf2c (diff)
ASoC: wm8903: Improve two size determinations in wm8903_i2c_probe()
Replace the specification of two data structures by pointer dereferences as the parameter for the operator "sizeof" to make the corresponding size determination a bit safer according to the Linux coding style convention. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring <elfring@users.sourceforge.net> Acked-by: Charles Keepax <ckeepax@opensource.cirrus.com> Signed-off-by: Mark Brown <broonie@kernel.org>
-rw-r--r--sound/soc/codecs/wm8903.c8
1 files changed, 3 insertions, 5 deletions
diff --git a/sound/soc/codecs/wm8903.c b/sound/soc/codecs/wm8903.c
index 51eb7d61d446..cba90f21161f 100644
--- a/sound/soc/codecs/wm8903.c
+++ b/sound/soc/codecs/wm8903.c
@@ -1995,8 +1995,7 @@ static int wm8903_i2c_probe(struct i2c_client *i2c,
1995 unsigned int val, irq_pol; 1995 unsigned int val, irq_pol;
1996 int ret, i; 1996 int ret, i;
1997 1997
1998 wm8903 = devm_kzalloc(&i2c->dev, sizeof(struct wm8903_priv), 1998 wm8903 = devm_kzalloc(&i2c->dev, sizeof(*wm8903), GFP_KERNEL);
1999 GFP_KERNEL);
2000 if (wm8903 == NULL) 1999 if (wm8903 == NULL)
2001 return -ENOMEM; 2000 return -ENOMEM;
2002 2001
@@ -2017,9 +2016,8 @@ static int wm8903_i2c_probe(struct i2c_client *i2c,
2017 if (pdata) { 2016 if (pdata) {
2018 wm8903->pdata = pdata; 2017 wm8903->pdata = pdata;
2019 } else { 2018 } else {
2020 wm8903->pdata = devm_kzalloc(&i2c->dev, 2019 wm8903->pdata = devm_kzalloc(&i2c->dev, sizeof(*wm8903->pdata),
2021 sizeof(struct wm8903_platform_data), 2020 GFP_KERNEL);
2022 GFP_KERNEL);
2023 if (!wm8903->pdata) 2021 if (!wm8903->pdata)
2024 return -ENOMEM; 2022 return -ENOMEM;
2025 2023