diff options
author | Nikolay Borisov <nborisov@suse.com> | 2017-07-27 07:22:11 -0400 |
---|---|---|
committer | David Sterba <dsterba@suse.com> | 2017-08-21 11:47:42 -0400 |
commit | 0174484d619460a65e88f594c36983cd2b7f4128 (patch) | |
tree | f78979163a43296459a6168e9b41cbd413932799 | |
parent | 0dde10bed2c44a4024eb446cc72fe4e0cb97ec06 (diff) |
btrfs: Remove chunk_objectid argument from btrfs_make_block_group
btrfs_make_block_group is always called with chunk_objectid set to
BTRFS_FIRST_CHUNK_TREE_OBJECTID. There's no reason why this behavior will
change anytime soon, so let's remove the argument and decrease the cognitive
load when reading the code path. No functional change
Signed-off-by: Nikolay Borisov <nborisov@suse.com>
Signed-off-by: David Sterba <dsterba@suse.com>
-rw-r--r-- | fs/btrfs/ctree.h | 3 | ||||
-rw-r--r-- | fs/btrfs/extent-tree.c | 6 | ||||
-rw-r--r-- | fs/btrfs/volumes.c | 4 |
3 files changed, 5 insertions, 8 deletions
diff --git a/fs/btrfs/ctree.h b/fs/btrfs/ctree.h index 02edcddbcc9c..ca087ad5ac48 100644 --- a/fs/btrfs/ctree.h +++ b/fs/btrfs/ctree.h | |||
@@ -2676,8 +2676,7 @@ int btrfs_read_block_groups(struct btrfs_fs_info *info); | |||
2676 | int btrfs_can_relocate(struct btrfs_fs_info *fs_info, u64 bytenr); | 2676 | int btrfs_can_relocate(struct btrfs_fs_info *fs_info, u64 bytenr); |
2677 | int btrfs_make_block_group(struct btrfs_trans_handle *trans, | 2677 | int btrfs_make_block_group(struct btrfs_trans_handle *trans, |
2678 | struct btrfs_fs_info *fs_info, u64 bytes_used, | 2678 | struct btrfs_fs_info *fs_info, u64 bytes_used, |
2679 | u64 type, u64 chunk_objectid, u64 chunk_offset, | 2679 | u64 type, u64 chunk_offset, u64 size); |
2680 | u64 size); | ||
2681 | struct btrfs_trans_handle *btrfs_start_trans_remove_block_group( | 2680 | struct btrfs_trans_handle *btrfs_start_trans_remove_block_group( |
2682 | struct btrfs_fs_info *fs_info, | 2681 | struct btrfs_fs_info *fs_info, |
2683 | const u64 chunk_offset); | 2682 | const u64 chunk_offset); |
diff --git a/fs/btrfs/extent-tree.c b/fs/btrfs/extent-tree.c index 6a8da7c19182..1a80f6e58296 100644 --- a/fs/btrfs/extent-tree.c +++ b/fs/btrfs/extent-tree.c | |||
@@ -10180,8 +10180,7 @@ next: | |||
10180 | 10180 | ||
10181 | int btrfs_make_block_group(struct btrfs_trans_handle *trans, | 10181 | int btrfs_make_block_group(struct btrfs_trans_handle *trans, |
10182 | struct btrfs_fs_info *fs_info, u64 bytes_used, | 10182 | struct btrfs_fs_info *fs_info, u64 bytes_used, |
10183 | u64 type, u64 chunk_objectid, u64 chunk_offset, | 10183 | u64 type, u64 chunk_offset, u64 size) |
10184 | u64 size) | ||
10185 | { | 10184 | { |
10186 | struct btrfs_block_group_cache *cache; | 10185 | struct btrfs_block_group_cache *cache; |
10187 | int ret; | 10186 | int ret; |
@@ -10193,7 +10192,8 @@ int btrfs_make_block_group(struct btrfs_trans_handle *trans, | |||
10193 | return -ENOMEM; | 10192 | return -ENOMEM; |
10194 | 10193 | ||
10195 | btrfs_set_block_group_used(&cache->item, bytes_used); | 10194 | btrfs_set_block_group_used(&cache->item, bytes_used); |
10196 | btrfs_set_block_group_chunk_objectid(&cache->item, chunk_objectid); | 10195 | btrfs_set_block_group_chunk_objectid(&cache->item, |
10196 | BTRFS_FIRST_CHUNK_TREE_OBJECTID); | ||
10197 | btrfs_set_block_group_flags(&cache->item, type); | 10197 | btrfs_set_block_group_flags(&cache->item, type); |
10198 | 10198 | ||
10199 | cache->flags = type; | 10199 | cache->flags = type; |
diff --git a/fs/btrfs/volumes.c b/fs/btrfs/volumes.c index 3561397a0c29..1df1044e9008 100644 --- a/fs/btrfs/volumes.c +++ b/fs/btrfs/volumes.c | |||
@@ -4826,9 +4826,7 @@ static int __btrfs_alloc_chunk(struct btrfs_trans_handle *trans, | |||
4826 | goto error; | 4826 | goto error; |
4827 | } | 4827 | } |
4828 | 4828 | ||
4829 | ret = btrfs_make_block_group(trans, info, 0, type, | 4829 | ret = btrfs_make_block_group(trans, info, 0, type, start, num_bytes); |
4830 | BTRFS_FIRST_CHUNK_TREE_OBJECTID, | ||
4831 | start, num_bytes); | ||
4832 | if (ret) | 4830 | if (ret) |
4833 | goto error_del_extent; | 4831 | goto error_del_extent; |
4834 | 4832 | ||