diff options
author | Riley Andrews <riandrews@google.com> | 2017-06-29 15:01:37 -0400 |
---|---|---|
committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2017-07-17 08:44:19 -0400 |
commit | 00b40d613352c623aaae88a44e5ded7c912909d7 (patch) | |
tree | eba0887b952a02669f503511be81d05b829d8e9a | |
parent | c4ea41ba195d01c9af66fb28711a16cc97caa9c5 (diff) |
binder: Use wake up hint for synchronous transactions.
Use wake_up_interruptible_sync() to hint to the scheduler binder
transactions are synchronous wakeups. Disable preemption while waking
to avoid ping-ponging on the binder lock.
Signed-off-by: Todd Kjos <tkjos@google.com>
Signed-off-by: Omprakash Dhyade <odhyade@codeaurora.org>
Cc: stable <stable@vger.kernel.org> # 4.4+
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-rw-r--r-- | drivers/android/binder.c | 8 |
1 files changed, 6 insertions, 2 deletions
diff --git a/drivers/android/binder.c b/drivers/android/binder.c index 9393924ae8e8..f7665c31feca 100644 --- a/drivers/android/binder.c +++ b/drivers/android/binder.c | |||
@@ -2200,8 +2200,12 @@ static void binder_transaction(struct binder_proc *proc, | |||
2200 | list_add_tail(&t->work.entry, target_list); | 2200 | list_add_tail(&t->work.entry, target_list); |
2201 | tcomplete->type = BINDER_WORK_TRANSACTION_COMPLETE; | 2201 | tcomplete->type = BINDER_WORK_TRANSACTION_COMPLETE; |
2202 | list_add_tail(&tcomplete->entry, &thread->todo); | 2202 | list_add_tail(&tcomplete->entry, &thread->todo); |
2203 | if (target_wait) | 2203 | if (target_wait) { |
2204 | wake_up_interruptible(target_wait); | 2204 | if (reply || !(t->flags & TF_ONE_WAY)) |
2205 | wake_up_interruptible_sync(target_wait); | ||
2206 | else | ||
2207 | wake_up_interruptible(target_wait); | ||
2208 | } | ||
2205 | return; | 2209 | return; |
2206 | 2210 | ||
2207 | err_translate_failed: | 2211 | err_translate_failed: |