aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorAndrew Lunn <andrew@lunn.ch>2016-01-06 14:11:20 -0500
committerDavid S. Miller <davem@davemloft.net>2016-01-07 14:31:26 -0500
commit0071f56e46dadb88dc3ad1f8d9cf9c3ae014735d (patch)
tree2cd405f123e3b39a85e50d015676c48d316a447e
parent5cf11beef2c4333b511ff9cef5285320616d938b (diff)
dsa: Register netdev before phy
When the phy is connected, an info message is printed. If the netdev it is attached to has not been registered yet, the name 'uninitialised' in the output. By registering the netdev first, then connecting they phy, we can avoid this. Signed-off-by: Andrew Lunn <andrew@lunn.ch> Signed-off-by: David S. Miller <davem@davemloft.net>
-rw-r--r--net/dsa/slave.c14
1 files changed, 7 insertions, 7 deletions
diff --git a/net/dsa/slave.c b/net/dsa/slave.c
index 2771713714f1..40b9ca72aae3 100644
--- a/net/dsa/slave.c
+++ b/net/dsa/slave.c
@@ -1189,13 +1189,6 @@ int dsa_slave_create(struct dsa_switch *ds, struct device *parent,
1189 p->old_link = -1; 1189 p->old_link = -1;
1190 p->old_duplex = -1; 1190 p->old_duplex = -1;
1191 1191
1192 ret = dsa_slave_phy_setup(p, slave_dev);
1193 if (ret) {
1194 netdev_err(master, "error %d setting up slave phy\n", ret);
1195 free_netdev(slave_dev);
1196 return ret;
1197 }
1198
1199 ds->ports[port] = slave_dev; 1192 ds->ports[port] = slave_dev;
1200 ret = register_netdev(slave_dev); 1193 ret = register_netdev(slave_dev);
1201 if (ret) { 1194 if (ret) {
@@ -1209,6 +1202,13 @@ int dsa_slave_create(struct dsa_switch *ds, struct device *parent,
1209 1202
1210 netif_carrier_off(slave_dev); 1203 netif_carrier_off(slave_dev);
1211 1204
1205 ret = dsa_slave_phy_setup(p, slave_dev);
1206 if (ret) {
1207 netdev_err(master, "error %d setting up slave phy\n", ret);
1208 free_netdev(slave_dev);
1209 return ret;
1210 }
1211
1212 return 0; 1212 return 0;
1213} 1213}
1214 1214