2 files changed, 9 insertions, 9 deletions

diff --git a/net/bridge/br.c b/net/bridge/br.c
index a1abe4936fe1..3addc05b9a16 100644
--- a/net/bridge/br.c
+++ b/net/bridge/br.c
@@ -121,6 +121,7 @@ static struct notifier_block br_device_notifier = {
         .notifier_call = br_device_event
 };
 
+/* called with RTNL */
 static int br_switchdev_event(struct notifier_block *unused,
                               unsigned long event, void *ptr)
 {
@@ -130,7 +131,6 @@ static int br_switchdev_event(struct notifier_block *unused,
         struct switchdev_notifier_fdb_info *fdb_info;
         int err = NOTIFY_DONE;
 
-        rtnl_lock();
         p = br_port_get_rtnl(dev);
         if (!p)
                 goto out;
@@ -155,7 +155,6 @@ static int br_switchdev_event(struct notifier_block *unused,
         }
 
 out:
-        rtnl_unlock();
         return err;
 }
 
diff --git a/net/switchdev/switchdev.c b/net/switchdev/switchdev.c
index ebc661d3b6e3..47f7da58a7f0 100644
--- a/net/switchdev/switchdev.c
+++ b/net/switchdev/switchdev.c
@@ -20,6 +20,7 @@
 #include <linux/list.h>
 #include <linux/workqueue.h>
 #include <linux/if_vlan.h>
+#include <linux/rtnetlink.h>
 #include <net/ip_fib.h>
 #include <net/switchdev.h>
 
@@ -567,7 +568,6 @@ int switchdev_port_obj_dump(struct net_device *dev, struct switchdev_obj *obj,
 }
 EXPORT_SYMBOL_GPL(switchdev_port_obj_dump);
 
-static DEFINE_MUTEX(switchdev_mutex);
 static RAW_NOTIFIER_HEAD(switchdev_notif_chain);
 
 /**
@@ -582,9 +582,9 @@ int register_switchdev_notifier(struct notifier_block *nb)
 {
         int err;
 
-        mutex_lock(&switchdev_mutex);
+        rtnl_lock();
         err = raw_notifier_chain_register(&switchdev_notif_chain, nb);
-        mutex_unlock(&switchdev_mutex);
+        rtnl_unlock();
         return err;
 }
 EXPORT_SYMBOL_GPL(register_switchdev_notifier);
@@ -600,9 +600,9 @@ int unregister_switchdev_notifier(struct notifier_block *nb)
 {
         int err;
 
-        mutex_lock(&switchdev_mutex);
+        rtnl_lock();
         err = raw_notifier_chain_unregister(&switchdev_notif_chain, nb);
-        mutex_unlock(&switchdev_mutex);
+        rtnl_unlock();
         return err;
 }
 EXPORT_SYMBOL_GPL(unregister_switchdev_notifier);
@@ -616,16 +616,17 @@ EXPORT_SYMBOL_GPL(unregister_switchdev_notifier);
  *      Call all network notifier blocks. This should be called by driver
  *      when it needs to propagate hardware event.
  *      Return values are same as for atomic_notifier_call_chain().
+ *      rtnl_lock must be held.
  */
 int call_switchdev_notifiers(unsigned long val, struct net_device *dev,
                              struct switchdev_notifier_info *info)
 {
         int err;
 
+        ASSERT_RTNL();
+
         info->dev = dev;
-        mutex_lock(&switchdev_mutex);
         err = raw_notifier_call_chain(&switchdev_notif_chain, val, info);
-        mutex_unlock(&switchdev_mutex);
         return err;
 }
 EXPORT_SYMBOL_GPL(call_switchdev_notifiers);