diff options
Diffstat (limited to 'drivers/usb/gadget/goku_udc.c')
-rw-r--r-- | drivers/usb/gadget/goku_udc.c | 20 |
1 files changed, 2 insertions, 18 deletions
diff --git a/drivers/usb/gadget/goku_udc.c b/drivers/usb/gadget/goku_udc.c index 85742d4c67df..991aba390d9d 100644 --- a/drivers/usb/gadget/goku_udc.c +++ b/drivers/usb/gadget/goku_udc.c | |||
@@ -51,8 +51,6 @@ | |||
51 | #define DRIVER_DESC "TC86C001 USB Device Controller" | 51 | #define DRIVER_DESC "TC86C001 USB Device Controller" |
52 | #define DRIVER_VERSION "30-Oct 2003" | 52 | #define DRIVER_VERSION "30-Oct 2003" |
53 | 53 | ||
54 | #define DMA_ADDR_INVALID (~(dma_addr_t)0) | ||
55 | |||
56 | static const char driver_name [] = "goku_udc"; | 54 | static const char driver_name [] = "goku_udc"; |
57 | static const char driver_desc [] = DRIVER_DESC; | 55 | static const char driver_desc [] = DRIVER_DESC; |
58 | 56 | ||
@@ -275,7 +273,6 @@ goku_alloc_request(struct usb_ep *_ep, gfp_t gfp_flags) | |||
275 | if (!req) | 273 | if (!req) |
276 | return NULL; | 274 | return NULL; |
277 | 275 | ||
278 | req->req.dma = DMA_ADDR_INVALID; | ||
279 | INIT_LIST_HEAD(&req->queue); | 276 | INIT_LIST_HEAD(&req->queue); |
280 | return &req->req; | 277 | return &req->req; |
281 | } | 278 | } |
@@ -1354,7 +1351,6 @@ static int goku_udc_start(struct usb_gadget *g, | |||
1354 | /* hook up the driver */ | 1351 | /* hook up the driver */ |
1355 | driver->driver.bus = NULL; | 1352 | driver->driver.bus = NULL; |
1356 | dev->driver = driver; | 1353 | dev->driver = driver; |
1357 | dev->gadget.dev.driver = &driver->driver; | ||
1358 | 1354 | ||
1359 | /* | 1355 | /* |
1360 | * then enable host detection and ep0; and we're ready | 1356 | * then enable host detection and ep0; and we're ready |
@@ -1394,7 +1390,6 @@ static int goku_udc_stop(struct usb_gadget *g, | |||
1394 | dev->driver = NULL; | 1390 | dev->driver = NULL; |
1395 | stop_activity(dev, driver); | 1391 | stop_activity(dev, driver); |
1396 | spin_unlock_irqrestore(&dev->lock, flags); | 1392 | spin_unlock_irqrestore(&dev->lock, flags); |
1397 | dev->gadget.dev.driver = NULL; | ||
1398 | 1393 | ||
1399 | return 0; | 1394 | return 0; |
1400 | } | 1395 | } |
@@ -1716,8 +1711,6 @@ static void goku_remove(struct pci_dev *pdev) | |||
1716 | pci_resource_len (pdev, 0)); | 1711 | pci_resource_len (pdev, 0)); |
1717 | if (dev->enabled) | 1712 | if (dev->enabled) |
1718 | pci_disable_device(pdev); | 1713 | pci_disable_device(pdev); |
1719 | if (dev->registered) | ||
1720 | device_unregister(&dev->gadget.dev); | ||
1721 | 1714 | ||
1722 | pci_set_drvdata(pdev, NULL); | 1715 | pci_set_drvdata(pdev, NULL); |
1723 | dev->regs = NULL; | 1716 | dev->regs = NULL; |
@@ -1756,10 +1749,6 @@ static int goku_probe(struct pci_dev *pdev, const struct pci_device_id *id) | |||
1756 | dev->gadget.max_speed = USB_SPEED_FULL; | 1749 | dev->gadget.max_speed = USB_SPEED_FULL; |
1757 | 1750 | ||
1758 | /* the "gadget" abstracts/virtualizes the controller */ | 1751 | /* the "gadget" abstracts/virtualizes the controller */ |
1759 | dev_set_name(&dev->gadget.dev, "gadget"); | ||
1760 | dev->gadget.dev.parent = &pdev->dev; | ||
1761 | dev->gadget.dev.dma_mask = pdev->dev.dma_mask; | ||
1762 | dev->gadget.dev.release = gadget_release; | ||
1763 | dev->gadget.name = driver_name; | 1752 | dev->gadget.name = driver_name; |
1764 | 1753 | ||
1765 | /* now all the pci goodies ... */ | 1754 | /* now all the pci goodies ... */ |
@@ -1810,13 +1799,8 @@ static int goku_probe(struct pci_dev *pdev, const struct pci_device_id *id) | |||
1810 | create_proc_read_entry(proc_node_name, 0, NULL, udc_proc_read, dev); | 1799 | create_proc_read_entry(proc_node_name, 0, NULL, udc_proc_read, dev); |
1811 | #endif | 1800 | #endif |
1812 | 1801 | ||
1813 | retval = device_register(&dev->gadget.dev); | 1802 | retval = usb_add_gadget_udc_release(&pdev->dev, &dev->gadget, |
1814 | if (retval) { | 1803 | gadget_release); |
1815 | put_device(&dev->gadget.dev); | ||
1816 | goto err; | ||
1817 | } | ||
1818 | dev->registered = 1; | ||
1819 | retval = usb_add_gadget_udc(&pdev->dev, &dev->gadget); | ||
1820 | if (retval) | 1804 | if (retval) |
1821 | goto err; | 1805 | goto err; |
1822 | 1806 | ||