1 files changed, 16 insertions, 26 deletions

diff --git a/drivers/usb/gadget/f_obex.c b/drivers/usb/gadget/f_obex.c
index 5f400f66aa9b..d8dd8782768c 100644
--- a/drivers/usb/gadget/f_obex.c
+++ b/drivers/usb/gadget/f_obex.c
@@ -331,23 +331,19 @@ obex_bind(struct usb_configuration *c, struct usb_function *f)
         obex->port.out = ep;
         ep->driver_data = cdev; /* claim */
 
-        /* copy descriptors, and track endpoint copies */
-        f->descriptors = usb_copy_descriptors(fs_function);
-
         /* support all relevant hardware speeds... we expect that when
          * hardware is dual speed, all bulk-capable endpoints work at
          * both speeds
          */
-        if (gadget_is_dualspeed(c->cdev->gadget)) {
 
-                obex_hs_ep_in_desc.bEndpointAddress =
-                                obex_fs_ep_in_desc.bEndpointAddress;
-                obex_hs_ep_out_desc.bEndpointAddress =
-                                obex_fs_ep_out_desc.bEndpointAddress;
+        obex_hs_ep_in_desc.bEndpointAddress =
+                obex_fs_ep_in_desc.bEndpointAddress;
+        obex_hs_ep_out_desc.bEndpointAddress =
+                obex_fs_ep_out_desc.bEndpointAddress;
 
-                /* copy descriptors, and track endpoint copies */
-                f->hs_descriptors = usb_copy_descriptors(hs_function);
-        }
+        status = usb_assign_descriptors(f, fs_function, hs_function, NULL);
+        if (status)
+                goto fail;
 
         /* Avoid letting this gadget enumerate until the userspace
          * OBEX server is active.
@@ -368,6 +364,7 @@ obex_bind(struct usb_configuration *c, struct usb_function *f)
         return 0;
 
 fail:
+        usb_free_all_descriptors(f);
         /* we might as well release our claims on endpoints */
         if (obex->port.out)
                 obex->port.out->driver_data = NULL;
@@ -382,9 +379,8 @@ fail:
 static void
 obex_unbind(struct usb_configuration *c, struct usb_function *f)
 {
-        if (gadget_is_dualspeed(c->cdev->gadget))
-                usb_free_descriptors(f->hs_descriptors);
-        usb_free_descriptors(f->descriptors);
+        obex_string_defs[OBEX_CTRL_IDX].id = 0;
+        usb_free_all_descriptors(f);
         kfree(func_to_obex(f));
 }
 
@@ -423,22 +419,16 @@ int __init obex_bind_config(struct usb_configuration *c, u8 port_num)
         if (!can_support_obex(c))
                 return -EINVAL;
 
-        /* maybe allocate device-global string IDs, and patch descriptors */
         if (obex_string_defs[OBEX_CTRL_IDX].id == 0) {
-                status = usb_string_id(c->cdev);
-                if (status < 0)
-                        return status;
-                obex_string_defs[OBEX_CTRL_IDX].id = status;
-
-                obex_control_intf.iInterface = status;
-
-                status = usb_string_id(c->cdev);
+                status = usb_string_ids_tab(c->cdev, obex_string_defs);
                 if (status < 0)
                         return status;
-                obex_string_defs[OBEX_DATA_IDX].id = status;
+                obex_control_intf.iInterface =
+                        obex_string_defs[OBEX_CTRL_IDX].id;
 
-                obex_data_nop_intf.iInterface =
-                        obex_data_intf.iInterface = status;
+                status = obex_string_defs[OBEX_DATA_IDX].id;
+                obex_data_nop_intf.iInterface = status;
+                obex_data_intf.iInterface = status;
         }
 
         /* allocate and initialize one new instance */