5 files changed, 67 insertions, 39 deletions

diff --git a/drivers/pnp/base.h b/drivers/pnp/base.h
index c8873b0ca551..3151fd164614 100644
--- a/drivers/pnp/base.h
+++ b/drivers/pnp/base.h
@@ -3,7 +3,7 @@
  *      Bjorn Helgaas <bjorn.helgaas@hp.com>
  */
 
-extern spinlock_t pnp_lock;
+extern struct mutex pnp_lock;
 extern const struct attribute_group *pnp_dev_groups[];
 void *pnp_alloc(long size);
 
diff --git a/drivers/pnp/card.c b/drivers/pnp/card.c
index 874c236ac1a7..31ad9fc3f701 100644
--- a/drivers/pnp/card.c
+++ b/drivers/pnp/card.c
@@ -5,6 +5,7 @@
  */
 
 #include <linux/module.h>
+#include <linux/mutex.h>
 #include <linux/ctype.h>
 #include <linux/slab.h>
 #include <linux/pnp.h>
@@ -244,10 +245,10 @@ int pnp_add_card(struct pnp_card *card)
         }
 
         pnp_interface_attach_card(card);
-        spin_lock(&pnp_lock);
+        mutex_lock(&pnp_lock);
         list_add_tail(&card->global_list, &pnp_cards);
         list_add_tail(&card->protocol_list, &card->protocol->cards);
-        spin_unlock(&pnp_lock);
+        mutex_unlock(&pnp_lock);
 
         /* we wait until now to add devices in order to ensure the drivers
          * will be able to use all of the related devices on the card
@@ -276,10 +277,10 @@ void pnp_remove_card(struct pnp_card *card)
         struct list_head *pos, *temp;
 
         device_unregister(&card->dev);
-        spin_lock(&pnp_lock);
+        mutex_lock(&pnp_lock);
         list_del(&card->global_list);
         list_del(&card->protocol_list);
-        spin_unlock(&pnp_lock);
+        mutex_unlock(&pnp_lock);
         list_for_each_safe(pos, temp, &card->devices) {
                 struct pnp_dev *dev = card_to_pnp_dev(pos);
                 pnp_remove_card_device(dev);
@@ -297,10 +298,10 @@ int pnp_add_card_device(struct pnp_card *card, struct pnp_dev *dev)
         dev->card_link = NULL;
         dev_set_name(&dev->dev, "%02x:%02x.%02x",
                      dev->protocol->number, card->number, dev->number);
-        spin_lock(&pnp_lock);
+        mutex_lock(&pnp_lock);
         dev->card = card;
         list_add_tail(&dev->card_list, &card->devices);
-        spin_unlock(&pnp_lock);
+        mutex_unlock(&pnp_lock);
         return 0;
 }
 
@@ -310,10 +311,10 @@ int pnp_add_card_device(struct pnp_card *card, struct pnp_dev *dev)
  */
 void pnp_remove_card_device(struct pnp_dev *dev)
 {
-        spin_lock(&pnp_lock);
+        mutex_lock(&pnp_lock);
         dev->card = NULL;
         list_del(&dev->card_list);
-        spin_unlock(&pnp_lock);
+        mutex_unlock(&pnp_lock);
         __pnp_remove_device(dev);
 }
 
@@ -426,9 +427,9 @@ int pnp_register_card_driver(struct pnp_card_driver *drv)
         if (error < 0)
                 return error;
 
-        spin_lock(&pnp_lock);
+        mutex_lock(&pnp_lock);
         list_add_tail(&drv->global_list, &pnp_card_drivers);
-        spin_unlock(&pnp_lock);
+        mutex_unlock(&pnp_lock);
 
         list_for_each_safe(pos, temp, &pnp_cards) {
                 struct pnp_card *card =
@@ -444,9 +445,9 @@ int pnp_register_card_driver(struct pnp_card_driver *drv)
  */
 void pnp_unregister_card_driver(struct pnp_card_driver *drv)
 {
-        spin_lock(&pnp_lock);
+        mutex_lock(&pnp_lock);
         list_del(&drv->global_list);
-        spin_unlock(&pnp_lock);
+        mutex_unlock(&pnp_lock);
         pnp_unregister_driver(&drv->link);
 }
 
diff --git a/drivers/pnp/core.c b/drivers/pnp/core.c
index cb6ce42f8e77..b54620e53830 100644
--- a/drivers/pnp/core.c
+++ b/drivers/pnp/core.c
@@ -9,6 +9,7 @@
 #include <linux/list.h>
 #include <linux/device.h>
 #include <linux/module.h>
+#include <linux/mutex.h>
 #include <linux/init.h>
 #include <linux/string.h>
 #include <linux/slab.h>
@@ -19,7 +20,7 @@
 
 static LIST_HEAD(pnp_protocols);
 LIST_HEAD(pnp_global);
-DEFINE_SPINLOCK(pnp_lock);
+DEFINE_MUTEX(pnp_lock);
 
 /*
  * ACPI or PNPBIOS should tell us about all platform devices, so we can
@@ -41,6 +42,13 @@ void *pnp_alloc(long size)
         return result;
 }
 
+static void pnp_remove_protocol(struct pnp_protocol *protocol)
+{
+        mutex_lock(&pnp_lock);
+        list_del(&protocol->protocol_list);
+        mutex_unlock(&pnp_lock);
+}
+
 /**
  * pnp_protocol_register - adds a pnp protocol to the pnp layer
  * @protocol: pointer to the corresponding pnp_protocol structure
@@ -49,13 +57,14 @@ void *pnp_alloc(long size)
  */
 int pnp_register_protocol(struct pnp_protocol *protocol)
 {
-        int nodenum;
         struct list_head *pos;
+        int nodenum, ret;
 
         INIT_LIST_HEAD(&protocol->devices);
         INIT_LIST_HEAD(&protocol->cards);
         nodenum = 0;
-        spin_lock(&pnp_lock);
+
+        mutex_lock(&pnp_lock);
 
         /* assign the lowest unused number */
         list_for_each(pos, &pnp_protocols) {
@@ -66,12 +75,18 @@ int pnp_register_protocol(struct pnp_protocol *protocol)
                 }
         }
 
-        list_add_tail(&protocol->protocol_list, &pnp_protocols);
-        spin_unlock(&pnp_lock);
-
         protocol->number = nodenum;
         dev_set_name(&protocol->dev, "pnp%d", nodenum);
-        return device_register(&protocol->dev);
+
+        list_add_tail(&protocol->protocol_list, &pnp_protocols);
+
+        mutex_unlock(&pnp_lock);
+
+        ret = device_register(&protocol->dev);
+        if (ret)
+                pnp_remove_protocol(protocol);
+
+        return ret;
 }
 
 /**
@@ -80,9 +95,7 @@ int pnp_register_protocol(struct pnp_protocol *protocol)
  */
 void pnp_unregister_protocol(struct pnp_protocol *protocol)
 {
-        spin_lock(&pnp_lock);
-        list_del(&protocol->protocol_list);
-        spin_unlock(&pnp_lock);
+        pnp_remove_protocol(protocol);
         device_unregister(&protocol->dev);
 }
 
@@ -157,18 +170,36 @@ struct pnp_dev *pnp_alloc_dev(struct pnp_protocol *protocol, int id,
         return dev;
 }
 
+static void pnp_delist_device(struct pnp_dev *dev)
+{
+        mutex_lock(&pnp_lock);
+        list_del(&dev->global_list);
+        list_del(&dev->protocol_list);
+        mutex_unlock(&pnp_lock);
+}
+
 int __pnp_add_device(struct pnp_dev *dev)
 {
+        int ret;
+
         pnp_fixup_device(dev);
         dev->status = PNP_READY;
-        spin_lock(&pnp_lock);
+
+        mutex_lock(&pnp_lock);
+
         list_add_tail(&dev->global_list, &pnp_global);
         list_add_tail(&dev->protocol_list, &dev->protocol->devices);
-        spin_unlock(&pnp_lock);
-        if (dev->protocol->can_wakeup)
+
+        mutex_unlock(&pnp_lock);
+
+        ret = device_register(&dev->dev);
+        if (ret)
+                pnp_delist_device(dev);
+        else if (dev->protocol->can_wakeup)
                 device_set_wakeup_capable(&dev->dev,
                                 dev->protocol->can_wakeup(dev));
-        return device_register(&dev->dev);
+
+        return ret;
 }
 
 /*
@@ -203,10 +234,7 @@ int pnp_add_device(struct pnp_dev *dev)
 
 void __pnp_remove_device(struct pnp_dev *dev)
 {
-        spin_lock(&pnp_lock);
-        list_del(&dev->global_list);
-        list_del(&dev->protocol_list);
-        spin_unlock(&pnp_lock);
+        pnp_delist_device(dev);
         device_unregister(&dev->dev);
 }
 
diff --git a/drivers/pnp/driver.c b/drivers/pnp/driver.c
index 4e57d3370368..153a493b5413 100644
--- a/drivers/pnp/driver.c
+++ b/drivers/pnp/driver.c
@@ -58,22 +58,22 @@ static const struct pnp_device_id *match_device(struct pnp_driver *drv,
 
 int pnp_device_attach(struct pnp_dev *pnp_dev)
 {
-        spin_lock(&pnp_lock);
+        mutex_lock(&pnp_lock);
         if (pnp_dev->status != PNP_READY) {
-                spin_unlock(&pnp_lock);
+                mutex_unlock(&pnp_lock);
                 return -EBUSY;
         }
         pnp_dev->status = PNP_ATTACHED;
-        spin_unlock(&pnp_lock);
+        mutex_unlock(&pnp_lock);
         return 0;
 }
 
 void pnp_device_detach(struct pnp_dev *pnp_dev)
 {
-        spin_lock(&pnp_lock);
+        mutex_lock(&pnp_lock);
         if (pnp_dev->status == PNP_ATTACHED)
                 pnp_dev->status = PNP_READY;
-        spin_unlock(&pnp_lock);
+        mutex_unlock(&pnp_lock);
         pnp_disable_dev(pnp_dev);
 }
 
diff --git a/drivers/pnp/pnpacpi/core.c b/drivers/pnp/pnpacpi/core.c
index d2b780aade89..5153d1d69aee 100644
--- a/drivers/pnp/pnpacpi/core.c
+++ b/drivers/pnp/pnpacpi/core.c
@@ -248,6 +248,7 @@ static int __init pnpacpi_add_device(struct acpi_device *device)
         if (!dev)
                 return -ENOMEM;
 
+        ACPI_COMPANION_SET(&dev->dev, device);
         dev->data = device;
         /* .enabled means the device can decode the resources */
         dev->active = device->status.enabled;
@@ -290,11 +291,9 @@ static int __init pnpacpi_add_device(struct acpi_device *device)
                 return error;
         }
 
-        error = acpi_bind_one(&dev->dev, device);
-
         num++;
 
-        return error;
+        return 0;
 }
 
 static acpi_status __init pnpacpi_add_device_handler(acpi_handle handle,