aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
-rw-r--r--ipc/util.c13
1 files changed, 8 insertions, 5 deletions
diff --git a/ipc/util.c b/ipc/util.c
index 3fdfabfdd9c3..b99038699fee 100644
--- a/ipc/util.c
+++ b/ipc/util.c
@@ -583,19 +583,22 @@ struct kern_ipc_perm *ipc_lock(struct ipc_ids *ids, int id)
583 rcu_read_lock(); 583 rcu_read_lock();
584 out = ipc_obtain_object_idr(ids, id); 584 out = ipc_obtain_object_idr(ids, id);
585 if (IS_ERR(out)) 585 if (IS_ERR(out))
586 goto err1; 586 goto err;
587 587
588 spin_lock(&out->lock); 588 spin_lock(&out->lock);
589 589
590 /* ipc_rmid() may have already freed the ID while ipc_lock 590 /*
591 * was spinning: here verify that the structure is still valid 591 * ipc_rmid() may have already freed the ID while ipc_lock()
592 * was spinning: here verify that the structure is still valid.
593 * Upon races with RMID, return -EIDRM, thus indicating that
594 * the ID points to a removed identifier.
592 */ 595 */
593 if (ipc_valid_object(out)) 596 if (ipc_valid_object(out))
594 return out; 597 return out;
595 598
596 spin_unlock(&out->lock); 599 spin_unlock(&out->lock);
597 out = ERR_PTR(-EINVAL); 600 out = ERR_PTR(-EIDRM);
598err1: 601err:
599 rcu_read_unlock(); 602 rcu_read_unlock();
600 return out; 603 return out;
601} 604}