aboutsummaryrefslogtreecommitdiffstats
path: root/tools
diff options
context:
space:
mode:
authorTaeung Song <treeze.taeung@gmail.com>2014-09-23 21:33:37 -0400
committerArnaldo Carvalho de Melo <acme@redhat.com>2014-09-26 11:32:58 -0400
commit52e0283497ccb1e675d56c9499cc2cc5ec271094 (patch)
treefa77ce32a71cb84c7372b5de67efa85fa04636f9 /tools
parenta5c2a4c9561cbbd374231bd341936dae716df9dd (diff)
perf tools: Modify error code for when perf_session__new() fails
Because perf_session__new() can fail for more reasons than just ENOMEM, modify error code(ENOMEM or EINVAL) to -1. Signed-off-by: Taeung Song <treeze.taeung@gmail.com> Acked-by: Jiri Olsa <jolsa@kernel.org> Acked-by: Namhyung Kim <namhyung@kernel.org> Cc: Jiri Olsa <jolsa@redhat.com> Cc: Namhyung Kim <namhyung@kernel.org> Link: http://lkml.kernel.org/r/1411522417-9917-1-git-send-email-treeze.taeung@gmail.com Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
Diffstat (limited to 'tools')
-rw-r--r--tools/perf/builtin-annotate.c2
-rw-r--r--tools/perf/builtin-diff.c2
-rw-r--r--tools/perf/builtin-evlist.c2
-rw-r--r--tools/perf/builtin-inject.c2
-rw-r--r--tools/perf/builtin-kmem.c2
-rw-r--r--tools/perf/builtin-kvm.c4
-rw-r--r--tools/perf/builtin-lock.c2
-rw-r--r--tools/perf/builtin-mem.c2
-rw-r--r--tools/perf/builtin-report.c2
-rw-r--r--tools/perf/builtin-script.c2
-rw-r--r--tools/perf/builtin-timechart.c2
-rw-r--r--tools/perf/builtin-top.c2
-rw-r--r--tools/perf/builtin-trace.c2
13 files changed, 14 insertions, 14 deletions
diff --git a/tools/perf/builtin-annotate.c b/tools/perf/builtin-annotate.c
index d4da6929597f..be5939418425 100644
--- a/tools/perf/builtin-annotate.c
+++ b/tools/perf/builtin-annotate.c
@@ -340,7 +340,7 @@ int cmd_annotate(int argc, const char **argv, const char *prefix __maybe_unused)
340 340
341 annotate.session = perf_session__new(&file, false, &annotate.tool); 341 annotate.session = perf_session__new(&file, false, &annotate.tool);
342 if (annotate.session == NULL) 342 if (annotate.session == NULL)
343 return -ENOMEM; 343 return -1;
344 344
345 symbol_conf.priv_size = sizeof(struct annotation); 345 symbol_conf.priv_size = sizeof(struct annotation);
346 symbol_conf.try_vmlinux_path = true; 346 symbol_conf.try_vmlinux_path = true;
diff --git a/tools/perf/builtin-diff.c b/tools/perf/builtin-diff.c
index 190d0b6b28cc..a3ce19f7aebd 100644
--- a/tools/perf/builtin-diff.c
+++ b/tools/perf/builtin-diff.c
@@ -683,7 +683,7 @@ static int __cmd_diff(void)
683 d->session = perf_session__new(&d->file, false, &tool); 683 d->session = perf_session__new(&d->file, false, &tool);
684 if (!d->session) { 684 if (!d->session) {
685 pr_err("Failed to open %s\n", d->file.path); 685 pr_err("Failed to open %s\n", d->file.path);
686 ret = -ENOMEM; 686 ret = -1;
687 goto out_delete; 687 goto out_delete;
688 } 688 }
689 689
diff --git a/tools/perf/builtin-evlist.c b/tools/perf/builtin-evlist.c
index 66e12f55c052..0f93f859b782 100644
--- a/tools/perf/builtin-evlist.c
+++ b/tools/perf/builtin-evlist.c
@@ -28,7 +28,7 @@ static int __cmd_evlist(const char *file_name, struct perf_attr_details *details
28 28
29 session = perf_session__new(&file, 0, NULL); 29 session = perf_session__new(&file, 0, NULL);
30 if (session == NULL) 30 if (session == NULL)
31 return -ENOMEM; 31 return -1;
32 32
33 evlist__for_each(session->evlist, pos) 33 evlist__for_each(session->evlist, pos)
34 perf_evsel__fprintf(pos, details, stdout); 34 perf_evsel__fprintf(pos, details, stdout);
diff --git a/tools/perf/builtin-inject.c b/tools/perf/builtin-inject.c
index 3a62b6b3c8fd..de99ca1bb942 100644
--- a/tools/perf/builtin-inject.c
+++ b/tools/perf/builtin-inject.c
@@ -460,7 +460,7 @@ int cmd_inject(int argc, const char **argv, const char *prefix __maybe_unused)
460 file.path = inject.input_name; 460 file.path = inject.input_name;
461 inject.session = perf_session__new(&file, true, &inject.tool); 461 inject.session = perf_session__new(&file, true, &inject.tool);
462 if (inject.session == NULL) 462 if (inject.session == NULL)
463 return -ENOMEM; 463 return -1;
464 464
465 if (symbol__init(&inject.session->header.env) < 0) 465 if (symbol__init(&inject.session->header.env) < 0)
466 return -1; 466 return -1;
diff --git a/tools/perf/builtin-kmem.c b/tools/perf/builtin-kmem.c
index 23762187a219..f295141025bc 100644
--- a/tools/perf/builtin-kmem.c
+++ b/tools/perf/builtin-kmem.c
@@ -698,7 +698,7 @@ int cmd_kmem(int argc, const char **argv, const char *prefix __maybe_unused)
698 698
699 session = perf_session__new(&file, false, &perf_kmem); 699 session = perf_session__new(&file, false, &perf_kmem);
700 if (session == NULL) 700 if (session == NULL)
701 return -ENOMEM; 701 return -1;
702 702
703 symbol__init(&session->header.env); 703 symbol__init(&session->header.env);
704 704
diff --git a/tools/perf/builtin-kvm.c b/tools/perf/builtin-kvm.c
index 1e639d6265cc..d8bf2271f4ea 100644
--- a/tools/perf/builtin-kvm.c
+++ b/tools/perf/builtin-kvm.c
@@ -1058,7 +1058,7 @@ static int read_events(struct perf_kvm_stat *kvm)
1058 kvm->session = perf_session__new(&file, false, &kvm->tool); 1058 kvm->session = perf_session__new(&file, false, &kvm->tool);
1059 if (!kvm->session) { 1059 if (!kvm->session) {
1060 pr_err("Initializing perf session failed\n"); 1060 pr_err("Initializing perf session failed\n");
1061 return -EINVAL; 1061 return -1;
1062 } 1062 }
1063 1063
1064 symbol__init(&kvm->session->header.env); 1064 symbol__init(&kvm->session->header.env);
@@ -1361,7 +1361,7 @@ static int kvm_events_live(struct perf_kvm_stat *kvm,
1361 */ 1361 */
1362 kvm->session = perf_session__new(&file, false, &kvm->tool); 1362 kvm->session = perf_session__new(&file, false, &kvm->tool);
1363 if (kvm->session == NULL) { 1363 if (kvm->session == NULL) {
1364 err = -ENOMEM; 1364 err = -1;
1365 goto out; 1365 goto out;
1366 } 1366 }
1367 kvm->session->evlist = kvm->evlist; 1367 kvm->session->evlist = kvm->evlist;
diff --git a/tools/perf/builtin-lock.c b/tools/perf/builtin-lock.c
index 92790ed7af45..e7ec71589da6 100644
--- a/tools/perf/builtin-lock.c
+++ b/tools/perf/builtin-lock.c
@@ -862,7 +862,7 @@ static int __cmd_report(bool display_info)
862 session = perf_session__new(&file, false, &eops); 862 session = perf_session__new(&file, false, &eops);
863 if (!session) { 863 if (!session) {
864 pr_err("Initializing perf session failed\n"); 864 pr_err("Initializing perf session failed\n");
865 return -ENOMEM; 865 return -1;
866 } 866 }
867 867
868 symbol__init(&session->header.env); 868 symbol__init(&session->header.env);
diff --git a/tools/perf/builtin-mem.c b/tools/perf/builtin-mem.c
index 8b4a87fe3858..24db6ffe2957 100644
--- a/tools/perf/builtin-mem.c
+++ b/tools/perf/builtin-mem.c
@@ -124,7 +124,7 @@ static int report_raw_events(struct perf_mem *mem)
124 &mem->tool); 124 &mem->tool);
125 125
126 if (session == NULL) 126 if (session == NULL)
127 return -ENOMEM; 127 return -1;
128 128
129 if (mem->cpu_list) { 129 if (mem->cpu_list) {
130 ret = perf_session__cpu_bitmap(session, mem->cpu_list, 130 ret = perf_session__cpu_bitmap(session, mem->cpu_list,
diff --git a/tools/perf/builtin-report.c b/tools/perf/builtin-report.c
index 8c0b3f22412a..ac145fae0521 100644
--- a/tools/perf/builtin-report.c
+++ b/tools/perf/builtin-report.c
@@ -720,7 +720,7 @@ int cmd_report(int argc, const char **argv, const char *prefix __maybe_unused)
720repeat: 720repeat:
721 session = perf_session__new(&file, false, &report.tool); 721 session = perf_session__new(&file, false, &report.tool);
722 if (session == NULL) 722 if (session == NULL)
723 return -ENOMEM; 723 return -1;
724 724
725 if (report.queue_size) { 725 if (report.queue_size) {
726 ordered_events__set_alloc_size(&session->ordered_events, 726 ordered_events__set_alloc_size(&session->ordered_events,
diff --git a/tools/perf/builtin-script.c b/tools/perf/builtin-script.c
index 02dce9295e2c..b9b9e58a6c39 100644
--- a/tools/perf/builtin-script.c
+++ b/tools/perf/builtin-script.c
@@ -1744,7 +1744,7 @@ int cmd_script(int argc, const char **argv, const char *prefix __maybe_unused)
1744 1744
1745 session = perf_session__new(&file, false, &script.tool); 1745 session = perf_session__new(&file, false, &script.tool);
1746 if (session == NULL) 1746 if (session == NULL)
1747 return -ENOMEM; 1747 return -1;
1748 1748
1749 if (header || header_only) { 1749 if (header || header_only) {
1750 perf_session__fprintf_info(session, stdout, show_full_info); 1750 perf_session__fprintf_info(session, stdout, show_full_info);
diff --git a/tools/perf/builtin-timechart.c b/tools/perf/builtin-timechart.c
index 48eea6cd2f5b..35b425b6293f 100644
--- a/tools/perf/builtin-timechart.c
+++ b/tools/perf/builtin-timechart.c
@@ -1605,7 +1605,7 @@ static int __cmd_timechart(struct timechart *tchart, const char *output_name)
1605 int ret = -EINVAL; 1605 int ret = -EINVAL;
1606 1606
1607 if (session == NULL) 1607 if (session == NULL)
1608 return -ENOMEM; 1608 return -1;
1609 1609
1610 symbol__init(&session->header.env); 1610 symbol__init(&session->header.env);
1611 1611
diff --git a/tools/perf/builtin-top.c b/tools/perf/builtin-top.c
index 832fb527ed90..5c16ba2dcf08 100644
--- a/tools/perf/builtin-top.c
+++ b/tools/perf/builtin-top.c
@@ -929,7 +929,7 @@ static int __cmd_top(struct perf_top *top)
929 929
930 top->session = perf_session__new(NULL, false, NULL); 930 top->session = perf_session__new(NULL, false, NULL);
931 if (top->session == NULL) 931 if (top->session == NULL)
932 return -ENOMEM; 932 return -1;
933 933
934 machines__set_symbol_filter(&top->session->machines, symbol_filter); 934 machines__set_symbol_filter(&top->session->machines, symbol_filter);
935 935
diff --git a/tools/perf/builtin-trace.c b/tools/perf/builtin-trace.c
index fe39dc620179..c70e69ea1c5d 100644
--- a/tools/perf/builtin-trace.c
+++ b/tools/perf/builtin-trace.c
@@ -2250,7 +2250,7 @@ static int trace__replay(struct trace *trace)
2250 2250
2251 session = perf_session__new(&file, false, &trace->tool); 2251 session = perf_session__new(&file, false, &trace->tool);
2252 if (session == NULL) 2252 if (session == NULL)
2253 return -ENOMEM; 2253 return -1;
2254 2254
2255 if (symbol__init(&session->header.env) < 0) 2255 if (symbol__init(&session->header.env) < 0)
2256 goto out; 2256 goto out;