diff options
author | Namhyung Kim <namhyung@kernel.org> | 2017-01-18 00:14:57 -0500 |
---|---|---|
committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2017-02-14 18:25:42 -0500 |
commit | 85df621b18e2f20731a1a6eb4defd8b704487064 (patch) | |
tree | 22d5e2e843227a2444ff84322cc1d24390dd3f2c /tools/perf/ui | |
parent | 6b4af0dab8934b046776a65fdd6e91658f500060 (diff) |
perf diff: Fix -o/--order option behavior (again)
commit a1c9f97f0b64e6337d9cfcc08c134450934fdd90 upstream.
Commit 21e6d8428664 ("perf diff: Use perf_hpp__register_sort_field
interface") changed list_add() to perf_hpp__register_sort_field().
This resulted in a behavior change since the field was added to the tail
instead of the head. So the -o option is mostly ignored due to its
order in the list.
This patch fixes it by adding perf_hpp__prepend_sort_field().
Signed-off-by: Namhyung Kim <namhyung@kernel.org>
Acked-by: Jiri Olsa <jolsa@kernel.org>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
Fixes: 21e6d8428664 ("perf diff: Use perf_hpp__register_sort_field interface")
Link: http://lkml.kernel.org/r/20170118051457.30946-2-namhyung@kernel.org
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'tools/perf/ui')
-rw-r--r-- | tools/perf/ui/hist.c | 6 |
1 files changed, 6 insertions, 0 deletions
diff --git a/tools/perf/ui/hist.c b/tools/perf/ui/hist.c index 37388397b5bc..2cfedef04e13 100644 --- a/tools/perf/ui/hist.c +++ b/tools/perf/ui/hist.c | |||
@@ -521,6 +521,12 @@ void perf_hpp_list__register_sort_field(struct perf_hpp_list *list, | |||
521 | list_add_tail(&format->sort_list, &list->sorts); | 521 | list_add_tail(&format->sort_list, &list->sorts); |
522 | } | 522 | } |
523 | 523 | ||
524 | void perf_hpp_list__prepend_sort_field(struct perf_hpp_list *list, | ||
525 | struct perf_hpp_fmt *format) | ||
526 | { | ||
527 | list_add(&format->sort_list, &list->sorts); | ||
528 | } | ||
529 | |||
524 | void perf_hpp__column_unregister(struct perf_hpp_fmt *format) | 530 | void perf_hpp__column_unregister(struct perf_hpp_fmt *format) |
525 | { | 531 | { |
526 | list_del(&format->list); | 532 | list_del(&format->list); |