aboutsummaryrefslogtreecommitdiffstats
path: root/tools/build
diff options
context:
space:
mode:
authorArnaldo Carvalho de Melo <acme@redhat.com>2016-07-12 11:19:09 -0400
committerArnaldo Carvalho de Melo <acme@redhat.com>2016-07-12 14:20:41 -0400
commit1c1a3a4729aae712c55e001e151ef008d030d4a7 (patch)
tree62fd90d09b08cf1a48eaa85ea8a21d7b2cc55b5d /tools/build
parentc8a3f7de76717a994c208e137156c077b1e93092 (diff)
perf tools: Add feature detection for gelf_getnote()
That is not present on some libelf implementations, such as the one used in Alpine Linux: libelf-0.8.13. This ends up disabling the SDT code, that relies on this function. One alternative would be to provide an weak fallback implementation or the open coded variant used by the buildid sysfs notes reading code. Cc: Adrian Hunter <adrian.hunter@intel.com> Cc: Ananth N Mavinakayanahalli <ananth@linux.vnet.ibm.com> Cc: Brendan Gregg <brendan.d.gregg@gmail.com> Cc: David Ahern <dsahern@gmail.com> Cc: Hemant Kumar <hemant@linux.vnet.ibm.com> Cc: Jiri Olsa <jolsa@kernel.org> Cc: Masami Hiramatsu <mhiramat@kernel.org> Cc: Namhyung Kim <namhyung@kernel.org> Cc: Peter Zijlstra <peterz@infradead.org> Cc: Wang Nan <wangnan0@huawei.com> Link: http://lkml.kernel.org/n/tip-82lh22ybedy9b9lych8xj12g@git.kernel.org Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
Diffstat (limited to 'tools/build')
-rw-r--r--tools/build/Makefile.feature1
-rw-r--r--tools/build/feature/Makefile4
-rw-r--r--tools/build/feature/test-all.c5
-rw-r--r--tools/build/feature/test-libelf-gelf_getnote.c7
4 files changed, 17 insertions, 0 deletions
diff --git a/tools/build/Makefile.feature b/tools/build/Makefile.feature
index 3dd529bb0604..fe12bee57418 100644
--- a/tools/build/Makefile.feature
+++ b/tools/build/Makefile.feature
@@ -40,6 +40,7 @@ FEATURE_TESTS_BASIC := \
40 libbfd \ 40 libbfd \
41 libelf \ 41 libelf \
42 libelf-getphdrnum \ 42 libelf-getphdrnum \
43 libelf-gelf_getnote \
43 libelf-getshdrstrndx \ 44 libelf-getshdrstrndx \
44 libelf-mmap \ 45 libelf-mmap \
45 libnuma \ 46 libnuma \
diff --git a/tools/build/feature/Makefile b/tools/build/feature/Makefile
index 674711629ef0..d6017c1abdb0 100644
--- a/tools/build/feature/Makefile
+++ b/tools/build/feature/Makefile
@@ -17,6 +17,7 @@ FILES= \
17 test-cplus-demangle.bin \ 17 test-cplus-demangle.bin \
18 test-libelf.bin \ 18 test-libelf.bin \
19 test-libelf-getphdrnum.bin \ 19 test-libelf-getphdrnum.bin \
20 test-libelf-gelf_getnote.bin \
20 test-libelf-getshdrstrndx.bin \ 21 test-libelf-getshdrstrndx.bin \
21 test-libelf-mmap.bin \ 22 test-libelf-mmap.bin \
22 test-libnuma.bin \ 23 test-libnuma.bin \
@@ -99,6 +100,9 @@ $(OUTPUT)test-libelf-mmap.bin:
99$(OUTPUT)test-libelf-getphdrnum.bin: 100$(OUTPUT)test-libelf-getphdrnum.bin:
100 $(BUILD) -lelf 101 $(BUILD) -lelf
101 102
103$(OUTPUT)test-libelf-gelf_getnote.bin:
104 $(BUILD) -lelf
105
102$(OUTPUT)test-libelf-getshdrstrndx.bin: 106$(OUTPUT)test-libelf-getshdrstrndx.bin:
103 $(BUILD) -lelf 107 $(BUILD) -lelf
104 108
diff --git a/tools/build/feature/test-all.c b/tools/build/feature/test-all.c
index 7433cca33306..843aed024a3a 100644
--- a/tools/build/feature/test-all.c
+++ b/tools/build/feature/test-all.c
@@ -49,6 +49,10 @@
49# include "test-libelf-getphdrnum.c" 49# include "test-libelf-getphdrnum.c"
50#undef main 50#undef main
51 51
52#define main main_test_libelf_gelf_getnote
53# include "test-libelf-gelf_getnote.c"
54#undef main
55
52#define main main_test_libelf_getshdrstrndx 56#define main main_test_libelf_getshdrstrndx
53# include "test-libelf-getshdrstrndx.c" 57# include "test-libelf-getshdrstrndx.c"
54#undef main 58#undef main
@@ -153,6 +157,7 @@ int main(int argc, char *argv[])
153 main_test_dwarf(); 157 main_test_dwarf();
154 main_test_dwarf_getlocations(); 158 main_test_dwarf_getlocations();
155 main_test_libelf_getphdrnum(); 159 main_test_libelf_getphdrnum();
160 main_test_libelf_gelf_getnote();
156 main_test_libelf_getshdrstrndx(); 161 main_test_libelf_getshdrstrndx();
157 main_test_libunwind(); 162 main_test_libunwind();
158 main_test_libaudit(); 163 main_test_libaudit();
diff --git a/tools/build/feature/test-libelf-gelf_getnote.c b/tools/build/feature/test-libelf-gelf_getnote.c
new file mode 100644
index 000000000000..d78cf4d5271f
--- /dev/null
+++ b/tools/build/feature/test-libelf-gelf_getnote.c
@@ -0,0 +1,7 @@
1#include <stdlib.h>
2#include <gelf.h>
3
4int main(void)
5{
6 return gelf_getnote(NULL, 0, NULL, NULL, NULL);
7}