selinux: use kmemdup in security_sid_to_context_core()

Signed-off-by: Rasmus Villemoes <linux@rasmusvillemoes.dk>
Acked-by: Stephen Smalley <sds@tycho.nsa.gov>
Signed-off-by: Paul Moore <pmoore@redhat.com>

1 files changed, 2 insertions, 2 deletions

diff --git a/security/selinux/ss/services.c b/security/selinux/ss/services.c
index c550df0e0ff1..994c824a34c6 100644
--- a/security/selinux/ss/services.c
+++ b/security/selinux/ss/services.c
@@ -1259,12 +1259,12 @@ static int security_sid_to_context_core(u32 sid, char **scontext,
                         *scontext_len = strlen(initial_sid_to_string[sid]) + 1;
                         if (!scontext)
                                 goto out;
-                        scontextp = kmalloc(*scontext_len, GFP_ATOMIC);
+                        scontextp = kmemdup(initial_sid_to_string[sid],
+                                            *scontext_len, GFP_ATOMIC);
                         if (!scontextp) {
                                 rc = -ENOMEM;
                                 goto out;
                         }
-                        strcpy(scontextp, initial_sid_to_string[sid]);
                         *scontext = scontextp;
                         goto out;
                 }