diff options
author | Chuck Lever <chuck.lever@oracle.com> | 2016-05-02 14:41:22 -0400 |
---|---|---|
committer | Anna Schumaker <Anna.Schumaker@Netapp.com> | 2016-05-17 15:47:59 -0400 |
commit | 88b18a120332cada6ff4adb9b5b7b6e4bbb653e5 (patch) | |
tree | a9e47a4b695b982b8123316d6d6dd6b20f5512f4 /net | |
parent | cce6deeb56aa8aad1d3154d70ea419cf25967f5c (diff) |
xprtrdma: Update comments in rpcrdma_marshal_req()
Update documenting comments to reflect code changes over the past
year.
Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
Tested-by: Steve Wise <swise@opengridcomputing.com>
Reviewed-by: Sagi Grimberg <sagi@grimberg.me>
Signed-off-by: Anna Schumaker <Anna.Schumaker@Netapp.com>
Diffstat (limited to 'net')
-rw-r--r-- | net/sunrpc/xprtrdma/rpc_rdma.c | 18 |
1 files changed, 4 insertions, 14 deletions
diff --git a/net/sunrpc/xprtrdma/rpc_rdma.c b/net/sunrpc/xprtrdma/rpc_rdma.c index 0105e65ad17f..c7c9bbbf758c 100644 --- a/net/sunrpc/xprtrdma/rpc_rdma.c +++ b/net/sunrpc/xprtrdma/rpc_rdma.c | |||
@@ -494,13 +494,10 @@ static void rpcrdma_inline_pullup(struct rpc_rqst *rqst) | |||
494 | * Marshal a request: the primary job of this routine is to choose | 494 | * Marshal a request: the primary job of this routine is to choose |
495 | * the transfer modes. See comments below. | 495 | * the transfer modes. See comments below. |
496 | * | 496 | * |
497 | * Uses multiple RDMA IOVs for a request: | 497 | * Prepares up to two IOVs per Call message: |
498 | * [0] -- RPC RDMA header, which uses memory from the *start* of the | 498 | * |
499 | * preregistered buffer that already holds the RPC data in | 499 | * [0] -- RPC RDMA header |
500 | * its middle. | 500 | * [1] -- the RPC header/data |
501 | * [1] -- the RPC header/data, marshaled by RPC and the NFS protocol. | ||
502 | * [2] -- optional padding. | ||
503 | * [3] -- if padded, header only in [1] and data here. | ||
504 | * | 501 | * |
505 | * Returns zero on success, otherwise a negative errno. | 502 | * Returns zero on success, otherwise a negative errno. |
506 | */ | 503 | */ |
@@ -624,13 +621,6 @@ rpcrdma_marshal_req(struct rpc_rqst *rqst) | |||
624 | __func__, transfertypes[wtype], hdrlen, rpclen, | 621 | __func__, transfertypes[wtype], hdrlen, rpclen, |
625 | headerp, base, rdmab_lkey(req->rl_rdmabuf)); | 622 | headerp, base, rdmab_lkey(req->rl_rdmabuf)); |
626 | 623 | ||
627 | /* | ||
628 | * initialize send_iov's - normally only two: rdma chunk header and | ||
629 | * single preregistered RPC header buffer, but if padding is present, | ||
630 | * then use a preregistered (and zeroed) pad buffer between the RPC | ||
631 | * header and any write data. In all non-rdma cases, any following | ||
632 | * data has been copied into the RPC header buffer. | ||
633 | */ | ||
634 | req->rl_send_iov[0].addr = rdmab_addr(req->rl_rdmabuf); | 624 | req->rl_send_iov[0].addr = rdmab_addr(req->rl_rdmabuf); |
635 | req->rl_send_iov[0].length = hdrlen; | 625 | req->rl_send_iov[0].length = hdrlen; |
636 | req->rl_send_iov[0].lkey = rdmab_lkey(req->rl_rdmabuf); | 626 | req->rl_send_iov[0].lkey = rdmab_lkey(req->rl_rdmabuf); |