aboutsummaryrefslogtreecommitdiffstats
path: root/net
diff options
context:
space:
mode:
authorChuck Lever <chuck.lever@oracle.com>2017-03-11 15:52:47 -0500
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>2017-03-26 07:05:57 -0400
commit87144ec25091a516c1674494bd95f8966a480eec (patch)
tree599b8e2c87047e4ff227d154fe8a6122c264f354 /net
parent69efd8e21246b56125e94dc4292d02423c14b49e (diff)
xprtrdma: Squelch kbuild sparse complaint
commit eed50879d64ab1b9f76445dbab822e43a098b309 upstream. New complaint from kbuild for 4.9.y: net/sunrpc/xprtrdma/verbs.c:489:19: sparse: incompatible types in comparison expression (different type sizes) verbs.c: 489 max_sge = min(ia->ri_device->attrs.max_sge, RPCRDMA_MAX_SEND_SGES); I can't reproduce this running sparse here. Likewise, "make W=1 net/sunrpc/xprtrdma/verbs.o" never indicated any issue. A little poking suggests that because the range of its values is small, gcc can make the actual width of RPCRDMA_MAX_SEND_SGES smaller than the width of an unsigned integer. Fixes: 16f906d66cd7 ("xprtrdma: Reduce required number of send SGEs") Signed-off-by: Chuck Lever <chuck.lever@oracle.com> Signed-off-by: Anna Schumaker <Anna.Schumaker@Netapp.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'net')
-rw-r--r--net/sunrpc/xprtrdma/verbs.c3
1 files changed, 2 insertions, 1 deletions
diff --git a/net/sunrpc/xprtrdma/verbs.c b/net/sunrpc/xprtrdma/verbs.c
index e2c37061edbe..69502fa68a3c 100644
--- a/net/sunrpc/xprtrdma/verbs.c
+++ b/net/sunrpc/xprtrdma/verbs.c
@@ -486,7 +486,8 @@ rpcrdma_ep_create(struct rpcrdma_ep *ep, struct rpcrdma_ia *ia,
486 struct ib_cq *sendcq, *recvcq; 486 struct ib_cq *sendcq, *recvcq;
487 int rc; 487 int rc;
488 488
489 max_sge = min(ia->ri_device->attrs.max_sge, RPCRDMA_MAX_SEND_SGES); 489 max_sge = min_t(unsigned int, ia->ri_device->attrs.max_sge,
490 RPCRDMA_MAX_SEND_SGES);
490 if (max_sge < RPCRDMA_MIN_SEND_SGES) { 491 if (max_sge < RPCRDMA_MIN_SEND_SGES) {
491 pr_warn("rpcrdma: HCA provides only %d send SGEs\n", max_sge); 492 pr_warn("rpcrdma: HCA provides only %d send SGEs\n", max_sge);
492 return -ENOMEM; 493 return -ENOMEM;