diff options
author | Julia Lawall <julia.lawall@lip6.fr> | 2015-09-13 08:15:27 -0400 |
---|---|---|
committer | David S. Miller <davem@davemloft.net> | 2015-09-15 19:49:43 -0400 |
commit | 20471ed4d403a5f4de6aa0c10cd1e446f7f2b3c7 (patch) | |
tree | 630ba6aacb5bbd35dc66bf2323d2b0e723e9e092 /net | |
parent | adf78edac09f9640cd9676571586c4be46fb527c (diff) |
dccp: drop null test before destroy functions
Remove unneeded NULL test.
The semantic patch that makes this change is as follows:
(http://coccinelle.lip6.fr/)
// <smpl>
@@
expression x;
@@
-if (x != NULL)
\(kmem_cache_destroy\|mempool_destroy\|dma_pool_destroy\)(x);
@@
expression x;
@@
-if (x != NULL) {
\(kmem_cache_destroy\|mempool_destroy\|dma_pool_destroy\)(x);
x = NULL;
-}
// </smpl>
Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net')
-rw-r--r-- | net/dccp/ackvec.c | 12 | ||||
-rw-r--r-- | net/dccp/ccid.c | 3 |
2 files changed, 5 insertions, 10 deletions
diff --git a/net/dccp/ackvec.c b/net/dccp/ackvec.c index bd9e718c2a20..3de0d0362d7f 100644 --- a/net/dccp/ackvec.c +++ b/net/dccp/ackvec.c | |||
@@ -398,12 +398,8 @@ out_err: | |||
398 | 398 | ||
399 | void dccp_ackvec_exit(void) | 399 | void dccp_ackvec_exit(void) |
400 | { | 400 | { |
401 | if (dccp_ackvec_slab != NULL) { | 401 | kmem_cache_destroy(dccp_ackvec_slab); |
402 | kmem_cache_destroy(dccp_ackvec_slab); | 402 | dccp_ackvec_slab = NULL; |
403 | dccp_ackvec_slab = NULL; | 403 | kmem_cache_destroy(dccp_ackvec_record_slab); |
404 | } | 404 | dccp_ackvec_record_slab = NULL; |
405 | if (dccp_ackvec_record_slab != NULL) { | ||
406 | kmem_cache_destroy(dccp_ackvec_record_slab); | ||
407 | dccp_ackvec_record_slab = NULL; | ||
408 | } | ||
409 | } | 405 | } |
diff --git a/net/dccp/ccid.c b/net/dccp/ccid.c index 83498975165f..90f77d08cc37 100644 --- a/net/dccp/ccid.c +++ b/net/dccp/ccid.c | |||
@@ -95,8 +95,7 @@ static struct kmem_cache *ccid_kmem_cache_create(int obj_size, char *slab_name_f | |||
95 | 95 | ||
96 | static void ccid_kmem_cache_destroy(struct kmem_cache *slab) | 96 | static void ccid_kmem_cache_destroy(struct kmem_cache *slab) |
97 | { | 97 | { |
98 | if (slab != NULL) | 98 | kmem_cache_destroy(slab); |
99 | kmem_cache_destroy(slab); | ||
100 | } | 99 | } |
101 | 100 | ||
102 | static int __init ccid_activate(struct ccid_operations *ccid_ops) | 101 | static int __init ccid_activate(struct ccid_operations *ccid_ops) |