diff options
author | Jakub Kicinski <jakub.kicinski@netronome.com> | 2016-06-06 11:16:47 -0400 |
---|---|---|
committer | David S. Miller <davem@davemloft.net> | 2016-06-07 19:27:14 -0400 |
commit | 1a0f7d2984f3864e64a43714b4a0999b5a27cff5 (patch) | |
tree | 0f7acc82153b28cbc827d6c72c1be184dc2b76a1 /net | |
parent | 7b01b8e847d00cf9cf0c2c3aa8fdfc4126dca024 (diff) |
net: cls_u32: fix error code for invalid flags
'err' variable is not set in this test, we would return whatever
previous test set 'err' to.
Signed-off-by: Jakub Kicinski <jakub.kicinski@netronome.com>
Acked-by: Sridhar Samudrala <sridhar.samudrala@intel.com>
Acked-by: John Fastabend <john.r.fastabend@intel.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net')
-rw-r--r-- | net/sched/cls_u32.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/net/sched/cls_u32.c b/net/sched/cls_u32.c index 079b43b3c5d2..b17e090f2fe1 100644 --- a/net/sched/cls_u32.c +++ b/net/sched/cls_u32.c | |||
@@ -863,7 +863,7 @@ static int u32_change(struct net *net, struct sk_buff *in_skb, | |||
863 | if (tb[TCA_U32_FLAGS]) { | 863 | if (tb[TCA_U32_FLAGS]) { |
864 | flags = nla_get_u32(tb[TCA_U32_FLAGS]); | 864 | flags = nla_get_u32(tb[TCA_U32_FLAGS]); |
865 | if (!tc_flags_valid(flags)) | 865 | if (!tc_flags_valid(flags)) |
866 | return err; | 866 | return -EINVAL; |
867 | } | 867 | } |
868 | 868 | ||
869 | n = (struct tc_u_knode *)*arg; | 869 | n = (struct tc_u_knode *)*arg; |